Sitelet https://github.com/msgwing/ZeroSMTP/pull/230
Skip to content

docs: add HP OAuth compatibility - #230

Merged
msgwing merged 2 commits into
msgwing:mainfrom
Mohitingale13:docs/add-hp-oauth
Aug 23, 2026
Merged

msgwing merged 2 commits into
msgwing:mainfrom
Mohitingale13:docs/add-hp-oauth

Conversation

@Mohitingale13

Copy link
Copy Markdown
Contributor

What does this PR change?

This PR adds HP's OAuth 2.0 capabilities to the device compatibility dataset (resolves #209).

Research & Evidence:

  • HP documents OAuth 2.0 support (Microsoft 365/Outlook) for their Enterprise and Managed printers running FutureSmart firmware 5.7 and newer.
  • HP also explicitly states that certain LaserJet Pro models (e.g., M478-M479, M428-M429f) do NOT support OAuth 2.0.
  • Evidence link: https://support.hp.com/nz-en/document/ish_13623350-13600809-16

Implementation details:

  • Used partial status because of the explicit firmware and product family divide (FutureSmart 5.7+ vs. LaserJet Pro).
  • Left the models array empty to avoid implying our negative examples were an exhaustive list.
  • Generated docs locally and ran the --check validation successfully. Did not update the global updated review date.

Checklist

  • Credentials are read from ZEROSMTP_* environment variables, not hardcoded
  • No certificate verification is disabled/bypassed anywhere in the diff
  • Port 587 (STARTTLS) or 465 (implicit SSL/TLS) only — never 25
  • Code comments/docs are in English (see CONTRIBUTING.md)
  • If you added or changed a language example: it builds/runs locally...
  • If you changed a dependency version...

@github-actions github-actions Bot added the docs label Aug 22, 2026
@msgwing

msgwing commented Aug 23, 2026

Copy link
Copy Markdown
Owner

Thank you — and the same apology as on #223: the delay was ours.

The eleven required checks never ran, because Require approval for first-time contributors was left at GitHub's default and the workflows sat waiting for a
button nobody was watching. Nothing to do with your change. Approved now, CI is
running.

This one is the better of the two, and specifically because of what it refuses
to claim:

You marked it partial and then named the models that do not support OAuth.
M478-M479 and M428-M429f. An HP row reading "OAuth available" would be true for
FutureSmart 5.7 Enterprise and actively harmful to somebody holding a LaserJet
Pro, who would wait for firmware that is not coming instead of planning around
it. Naming the exclusions is worth more than the inclusions here, and most
submissions leave them out.

The firmware floor is in the note rather than the status. FutureSmart 5.7
and newer - that is the detail somebody needs before they start, and it is not
in the status field where it would get lost.

Two small things:

  • data/devices.json lost its trailing newline, and the entry before yours got
    its closing brace pulled onto the same line - "...repointed." },. The
    JSON parses, so this is cosmetic, but the diff is noisier than the change.
  • This and docs: add Lexmark OAuth compatibility #223 both edit data/devices.json, so whichever merges second will
    need a rebase. No action needed yet; I will say which way round once CI is
    green on both.

This and #223 are the first contributions to this repository from anybody
outside it. Both are going in.

@msgwing
msgwing enabled auto-merge August 23, 2026 09:41
@msgwing
msgwing merged commit 8f1670e into msgwing:main Aug 23, 2026
24 checks passed
@msgwing

msgwing commented Aug 23, 2026

Copy link
Copy Markdown
Owner

Merged. Both of yours are in — the compatibility list is at 17 entries and HP
and Lexmark are two of the largest gaps it had.

Three things happened on your branch that you did not do, so you are not left
wondering:

I pushed a merge commit to it. #223 landed first and both pull requests
edited data/devices.json, so this one conflicted. Rather than ask you to
rebase I resolved it here: main's file, plus your HP entry, then the generator
re-run so the table and the new page match. Your entry is unchanged. The
trailing newline is back too.

The red device-table check was my bug, not yours. A validator I added the
day before imports yaml, and the pip install pyyaml in that job sat in a
step below it, so it died before reaching the install. Fixed in #233. Nothing
in your change ever caused it.

Workflows no longer wait on approval for you. Once #223 merged you stopped
being a first-time contributor, so CI on this one started by itself.

If you want a third, the same gap exists for Sharp, Toshiba and Synology, and
data/devices.json is the only file that needs touching. The rule that matters
is the one you already followed twice: a vendor's own published page as
evidence, and a status that does not claim more than the page does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add HP to the OAuth compatibility list (needs one vendor link)

2 participants