You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Used check-advisory status since Lexmark applies this to multiple models (CS/CX/XC/MX series) but does not provide a single, universal compatibility matrix.
Left the models array empty to avoid falsely claiming an exhaustive model list.
Generated docs locally and ran the --check validation successfully. Did not update the global updated review date to keep the PR strictly focused on the Lexmark addition.
Thank you — and an apology for the wait, which was our fault and not yours.
The eleven required checks never started on this. Not because of anything in
the change: this repository had Require approval for first-time contributors
left at GitHub's default, so the workflows sat in a queue waiting for a
maintainer to press a button nobody was watching for. Your pull request could
not have merged no matter how good it was. I have approved the runs and CI is
going now. The setting is being dealt with separately so the next person does
not hit it.
On the change itself, three things you got right that people usually do not:
The evidence link is a Lexmark page, not a forum thread. That is the one
rule data/devices.json cannot bend on — a row without a vendor's own
statement behind it eventually sends somebody to buy hardware they did not
need.
check-advisory rather than available. FW24 and newer supporting OAuth is
not the same claim as "Lexmark supports OAuth", and your note says exactly that.
Somebody on older firmware reading an optimistic row would lose a day before
finding out.
You ran the generator.docs/DEVICE-COMPATIBILITY.md and the new page under docs/devices/ are generated from the JSON and CI rejects the two disagreeing.
Most first pull requests here hand-edit the table and get bounced.
One small thing, and it is genuinely small: data/devices.json should end with
a newline. If CI complains about formatting that is what it means.
For what it is worth, this is the first contribution to this repository from
somebody outside it. The compatibility list is the one thing here that nobody
else has, and it only grows this way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change?
This PR adds Lexmark's OAuth 2.0 capabilities to the device compatibility dataset (resolves #211).
Research & Evidence:
Implementation details:
check-advisorystatus since Lexmark applies this to multiple models (CS/CX/XC/MX series) but does not provide a single, universal compatibility matrix.modelsarray empty to avoid falsely claiming an exhaustive model list.--checkvalidation successfully. Did not update the globalupdatedreview date to keep the PR strictly focused on the Lexmark addition.