fix(ci): pyyaml instalowany przed krokami, ktore go importuja - #233
Merged
Merged
Conversation
tools/check-action.py was added yesterday and imports yaml. The pip install for pyyaml lived inside the last step of the same job, so every run of device-table since has died on ModuleNotFoundError before reaching it. The first person to hit it was an outside contributor, on their first pull request, on a change to a JSON file that has nothing to do with any of this. Their pull request showed a red required check with my defect in it. The install is its own step now, directly after setup-python, so adding a step that needs a dependency cannot silently depend on the order of steps below it. Worth naming the shape of this one rather than just fixing it: putting setup inside the step that happened to need it worked for exactly as long as that step was the only one. It was correct when written and became wrong when something was added above it, and nothing was watching for that - the same failure as a stale comment, in a workflow file.
6 tasks
This was referenced Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tools/check-action.pydodany wczoraj importujeyaml. Instalacjapyyamlsiedziała wewnątrz ostatniego kroku tego samego zadania — więc każdy przebiegdevice-tableod tamtej pory umiera naModuleNotFoundError, zanim do niej dojdzie.Pierwszą osobą, która na to trafiła, był kontrybutor z zewnątrz — przy swoim pierwszym pull requeście, na zmianie w pliku JSON, która nie ma z tym nic wspólnego. Zobaczył czerwone wymagane sprawdzenie z moim błędem w środku.
Instalacja jest teraz osobnym krokiem, zaraz po
setup-python, więc dodanie kroku wymagającego zależności nie może po cichu zależeć od kolejności kroków pod nim.Warto nazwać kształt tego błędu, a nie tylko go naprawić: wsadzenie instalacji do kroku, który akurat jej potrzebował, działało dokładnie tak długo, jak długo był to jedyny taki krok. Było poprawne, gdy powstawało, i stało się błędne, gdy coś dodano wyżej — a nic tego nie pilnowało. To ta sama porażka co nieaktualny komentarz, tyle że w pliku workflow.