Automated cherry pick of #18600: nodeup: don't mutate the cluster spec when clearing authenticator config - #18602
Merged
kubernetes-prow[bot] merged 1 commit intoJul 16, 2026
Conversation
BuildNodeUpConfig assigned the shared Authentication pointer into the nodeup config and then replaced its AWS field with an empty struct, wiping spec.authentication.aws on the live cluster object. Since kubernetes#18215 moved addon rendering to task run time, the aws-iam-authenticator manifest rendered after this mutation, losing backendMode, clusterID and identityMappings. Copy the struct before clearing the field, and extend the complex integration test to cover backendMode: CRD with identity mappings.
hakman
approved these changes
Jul 16, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubernetes-prow
Bot
merged commit Jul 16, 2026
bdafac6
into
kubernetes:release-1.36
18 checks passed
social4hyq
pushed a commit
to social4hyq/homebrew-core
that referenced
this pull request
Sep 20, 2026
kops 1.36.1 Created-by: HarmonybrewBot Commit-by: HarmonybrewBot Merged-by: HarmonybrewBot Description: Created by `brew bump` --- Created with `brew bump-formula-pr`.<details> <summary>release notes</summary> <pre>## What's Changed * Automated cherry pick of #18600: nodeup: don't mutate the cluster spec when clearing authenticator config by @rifelpet in kubernetes/kops#18602 * Automated cherry pick of #18631: hetzner: Ignore WellKnownServices when comparing load balancers by @hakman in kubernetes/kops#18633 * Release 1.36.1 by @hakman in kubernetes/kops#18634 **Full Changelog**: https://github.com/kubernetes/kops/compare/v1.36.0...v1.36.1</pre> <p>View the full release notes at <a href="/sitelet?url=https%3A%2F%2Fgithub.com%2Fkubernetes%2Fkops%2Fpull%2F%253Ca%2520href%3D"https://github.com/kubernetes/kops/releases/tag/v1.36.1">https://github.com/kubernetes/kops/releases/tag/v1.36.1</a>.</p">https://github.com/kubernetes/kops/releases/tag/v1.36.1">https://github.com/kubernetes/kops/releases/tag/v1.36.1</a>.</p> </details> <hr> See merge request: Harmonybrew/homebrew-core!15315
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick of #18600 on release-1.36.
#18600: nodeup: don't mutate the cluster spec when clearing authenticator config
For details on the cherry pick process, see the cherry pick requests page.
What type of PR is this?