nodeup: don't mutate the cluster spec when clearing authenticator config - #18600
Merged
kubernetes-prow[bot] merged 1 commit intoJul 16, 2026
Merged
kubernetes-prow[bot] merged 1 commit into
kubernetes-prow[bot] merged 1 commit into
Conversation
Member
Author
Member
Author
|
/retest |
1 similar comment
Member
Author
|
/retest |
Member
|
Can we check for other api fields that could be in this same situation? |
Member
Author
I did a quick check, nothing popped up... |
hakman
force-pushed
the
fix-aws-iam-authenticator-addon
branch
from
July 16, 2026 11:55
0155a74 to
01bd103
Compare
BuildNodeUpConfig assigned the shared Authentication pointer into the nodeup config and then replaced its AWS field with an empty struct, wiping spec.authentication.aws on the live cluster object. Since kubernetes#18215 moved addon rendering to task run time, the aws-iam-authenticator manifest rendered after this mutation, losing backendMode, clusterID and identityMappings. Copy the struct before clearing the field, and extend the complex integration test to cover backendMode: CRD with identity mappings.
hakman
force-pushed
the
fix-aws-iam-authenticator-addon
branch
from
July 16, 2026 11:56
01bd103 to
26dcc14
Compare
rifelpet
approved these changes
Jul 16, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubernetes-prow Bot
added a commit
that referenced
this pull request
Jul 16, 2026
…00-origin-release-1.36 Automated cherry pick of #18600: nodeup: don't mutate the cluster spec when clearing authenticator config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BuildNodeUpConfig assigned the shared Authentication pointer into the nodeup config and then replaced its AWS field with an empty struct, wiping spec.authentication.aws on the live cluster object. Since #18215 moved addon rendering to task run time, the aws-iam-authenticator manifest rendered after this mutation, losing backendMode, clusterID and identityMappings.
Copy the struct before clearing the field, and extend the complex integration test to cover backendMode: CRD with identity mappings.