[material_ui] port drawer tests over from flutter/widgets by navaronbracke · Pull Request #12711 · flutter/packages

navaronbracke · 2026-09-01T08:57:01Z

This PR moves tests from packages/flutter under widgets/drawer_test.dart into material_ui.

Most tests were moved verbatim, except for a few tests that I renamed, because the test name was not very clear.
The drawer control tests for Material 2/3 that already existed were updated to test some additional behavior.

Part of flutter/flutter#177028

See flutter/flutter#192106 which removes the tests in flutter/flutter

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩²

navaronbracke · 2026-09-01T08:58:43Z

    state.openDrawer();

    await tester.pump();
+    expect(find.text('Archive'), findsOneWidget);


This is ported over from the original test: https://github.com/flutter/flutter/blob/master/packages/flutter/test/widgets/drawer_test.dart#L32

navaronbracke · 2026-09-01T08:59:19Z


    expect(find.text('header'), findsOneWidget);
+
+    Navigator.pop(savedContext);


This is ported over from the original test https://github.com/flutter/flutter/blob/master/packages/flutter/test/widgets/drawer_test.dart#L35-L39

gemini-code-assist

Code Review

This pull request ports drawer tests from flutter/widgets into material_ui, updating existing tests to verify drawer dismissal animations and adding several new tests covering tap, hover, gesture cancellation, and semantics behaviors. The review feedback suggests replacing hardcoded strings in the semantics tests (such as 'Dismiss' and 'Navigation menu') with localized values from DefaultMaterialLocalizations to make the tests robust against localization changes.

gemini-code-assist · 2026-09-01T08:59:43Z

+      await tester.pump(const Duration(milliseconds: 100));
+
+      expect(semantics, includesNodeWith(actions: <SemanticsAction>[SemanticsAction.tap]));
+      expect(semantics, includesNodeWith(label: 'Dismiss'));


Avoid using the hardcoded string 'Dismiss' for the semantics label. Instead, use const DefaultMaterialLocalizations().modalBarrierDismissLabel to ensure the test is robust against localization changes and matches the implementation's localized values.

Suggested change

expect(semantics, includesNodeWith(label: 'Dismiss'));

expect(semantics, includesNodeWith(label: const DefaultMaterialLocalizations().modalBarrierDismissLabel));

gemini-code-assist · 2026-09-01T08:59:43Z

+        includesNodeWith(actions: <SemanticsAction>[SemanticsAction.tap, SemanticsAction.focus]),
+      ),
+    );
+    expect(semantics, isNot(includesNodeWith(label: 'Dismiss')));


Avoid using the hardcoded string 'Dismiss' for the semantics label. Instead, use const DefaultMaterialLocalizations().modalBarrierDismissLabel to ensure the test is robust against localization changes and matches the implementation's localized values.

Suggested change

expect(semantics, isNot(includesNodeWith(label: 'Dismiss')));

expect(semantics, isNot(includesNodeWith(label: const DefaultMaterialLocalizations().modalBarrierDismissLabel)));

gemini-code-assist · 2026-09-01T08:59:43Z

+    expect(
+      semantics,
+      includesNodeWith(
+        label: 'Navigation menu',
+        flags: <SemanticsFlag>[SemanticsFlag.scopesRoute, SemanticsFlag.namesRoute],
+      ),
+    );


Avoid using the hardcoded string 'Navigation menu' for the semantics label. Instead, use const DefaultMaterialLocalizations().drawerLabel to ensure the test is robust against localization changes and matches the implementation's localized values.

Suggested change

expect(

semantics,

includesNodeWith(

label: 'Navigation menu',

flags: <SemanticsFlag>[SemanticsFlag.scopesRoute, SemanticsFlag.namesRoute],

),

);

expect(

semantics,

includesNodeWith(

label: const DefaultMaterialLocalizations().drawerLabel,

flags: <SemanticsFlag>[SemanticsFlag.scopesRoute, SemanticsFlag.namesRoute],

),

);

navaronbracke · 2026-09-01T08:59:53Z

  testWidgets('Material3 - Drawer control test', (WidgetTester tester) async {
    const containerKey = Key('container');

+    late BuildContext savedContext;


The same changes as the test above were applied here, since we have the M2/M3 split

navaronbracke · 2026-09-01T09:00:11Z

    semantics.dispose();
  }, variant: TargetPlatformVariant.only(TargetPlatform.android));

+  testWidgets('Drawer tap test', (WidgetTester tester) async {


Moved over verbatim

navaronbracke · 2026-09-01T09:00:18Z

+    expect(find.text('drawer'), findsNothing);
+  });
+
+  testWidgets('Drawer hover test', (WidgetTester tester) async {


Moved over verbatim

navaronbracke · 2026-09-01T09:01:00Z

    expect(finder, findsNothing);
  });

+  testWidgets('Close drawer with navigator pop', (WidgetTester tester) async {


Moved over verbatim, except for the test name: https://github.com/flutter/flutter/blob/master/packages/flutter/test/widgets/drawer_test.dart#L245

navaronbracke · 2026-09-01T09:02:20Z

+    expect(buttonPressed, equals(true));
+  });
+
+  testWidgets('Drawer closing can be canceled by gesture (LTR)', (WidgetTester tester) async {


Moved over verbatim, except for the test name: https://github.com/flutter/flutter/blob/master/packages/flutter/test/widgets/drawer_test.dart#L146

navaronbracke · 2026-09-01T09:02:32Z

+    await gesture.up();
+  });
+
+  testWidgets('Drawer closing can be canceled by gesture (RTL)', (WidgetTester tester) async {


Same for this test

navaronbracke · 2026-09-01T09:03:16Z

  });

+  testWidgets(
+    'Dismissible Drawer includes button in semantic tree',


Moved over verbatim, except for the test name: https://github.com/flutter/flutter/blob/master/packages/flutter/test/widgets/drawer_test.dart#L293

navaronbracke · 2026-09-01T09:03:47Z

+    }),
+  );
+
+  testWidgets('Dismissible Drawer is hidden on Android (back button is used to dismiss)', (


Moved over verbatim, except for the test name: https://github.com/flutter/flutter/blob/master/packages/flutter/test/widgets/drawer_test.dart#L324

The description sounds still a bit inaccurate because we are not really testing whether the drawer is hidden but the a11y label. How about

Suggested change

testWidgets('Dismissible Drawer is hidden on Android (back button is used to dismiss)', (

testWidgets('Dismissible Drawer barrier is hidden from semantics on Android (back button is used to dismiss)', (

navaronbracke · 2026-09-01T09:04:02Z

    await pumpDrawerWithTheme(TargetPlatform.iOS);
  }, variant: TargetPlatformVariant.all());

+  testWidgets('Drawer contains route semantics flags', (WidgetTester tester) async {


Moved over verbatim

elliette

I think the changelog entry should be removed, otherwise LGTM! Thanks for porting these tests over.

QuncCccccc

Overall looks good to me. Just left a few comments:)! Thanks a lot for your contribution!

QuncCccccc · 2026-09-02T23:26:10Z

+    }),
+  );
+
+  testWidgets('Dismissible Drawer is hidden on Android (back button is used to dismiss)', (


The description sounds still a bit inaccurate because we are not really testing whether the drawer is hidden but the a11y label. How about

Suggested change

testWidgets('Dismissible Drawer is hidden on Android (back button is used to dismiss)', (

testWidgets('Dismissible Drawer barrier is hidden from semantics on Android (back button is used to dismiss)', (

QuncCccccc

LGTM. Thank you for the contribution!

…er#192485) flutter/packages@9af9c60...36e088a 2026-09-09 daniel.leon@cloudsufi.com [quick_actions] Adopt code-excerpts for README (flutter/packages#12643) 2026-09-08 65155920+0xharkirat@users.noreply.github.com [camera_web] Fix TypeError when reading the torch capability (flutter/packages#12647) 2026-09-08 gibbonsj97@gmail.com [google_maps_flutter_web] Avoid replacing advanced marker content on move (flutter/packages#11952) 2026-09-08 mit@google.com [material_ui][cupertino_ui] Change issue tracker label in pubspec.yaml (flutter/packages#12792) 2026-09-08 saurabhmirajkar000@gmail.com [material_ui] Fix FilledButton Material 3 default style docs (flutter/packages#12620) 2026-09-08 21270878+elliette@users.noreply.github.com [infra] Use a modified no-response workflow in flutter/packages (flutter/packages#12745) 2026-09-08 21270878+elliette@users.noreply.github.com [material_ui] Migrate M3 Banner template to use new gen_defaults (flutter/packages#12734) 2026-09-08 engine-flutter-autoroll@skia.org Roll Flutter from 63170e9 to b444e78 (13 revisions) (flutter/packages#12791) 2026-09-08 fluttergithubbot@gmail.com Sync release-go_router-18.0.1 to main (flutter/packages#12725) 2026-09-08 fluttergithubbot@gmail.com Sync release-material_ui-1.1.1 to main (flutter/packages#12726) 2026-09-08 stuartmorgan@google.com [tool] Adopt `platform` 3.2.0 (flutter/packages#12789) 2026-09-07 50643541+Mairramer@users.noreply.github.com [material_ui] Fix SliverGeometry maxPaintExtent assertion in CarouselView.weighted (flutter/packages#12563) 2026-09-05 engine-flutter-autoroll@skia.org Roll Flutter from 5a6cfa7 to 63170e9 (15 revisions) (flutter/packages#12767) 2026-09-04 engine-flutter-autoroll@skia.org Manual roll Flutter from 70797e1 to 5a6cfa7 (52 revisions) (flutter/packages#12760) 2026-09-04 brackenavaron@gmail.com [material_ui] port drawer tests over from flutter/widgets (flutter/packages#12711) 2026-09-04 tarrinneal@gmail.com add cooldown (flutter/packages#12708) 2026-09-04 joeldumasbg@gmail.com [in_app_purchase] Support StoreKit 2 introductory offer eligibility JWS (flutter/packages#12584) 2026-09-04 21270878+elliette@users.noreply.github.com [material_ui] Migrate M3 Badge template to use new gen_defaults (flutter/packages#12733) 2026-09-04 stuartmorgan@google.com [google_maps_flutter] Convert heatmap controller to Swift (flutter/packages#12713) 2026-09-04 97480502+b-luk@users.noreply.github.com [material_ui] Remove unused `maintainState` constructor parameter in `scaffold_test.dart` (flutter/packages#12754) 2026-09-04 a1rwulf@users.noreply.github.com [video_player_avfoundation] Route video over AirPlay (flutter/packages#12490) 2026-09-04 jerome.dellamaria@proton.me [google_fonts] Add google_fonts_lite file to allow tree-shaking of the other huge files (flutter/packages#11433) 2026-09-04 engine-flutter-autoroll@skia.org Roll Flutter from 0cbd1a4 to 70797e1 (27 revisions) (flutter/packages#12727) 2026-09-04 stuartmorgan@google.com Update Chrome for stable tests (flutter/packages#12747) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

) This PR moves tests from `packages/flutter` under `widgets/drawer_test.dart` into material_ui. Most tests were moved verbatim, except for a few tests that I renamed, because the test name was not very clear. The drawer control tests for Material 2/3 that already existed were updated to test some additional behavior. Part of flutter/flutter#177028 See flutter/flutter#192106 which removes the tests in flutter/flutter ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

port drawer tests over from flutter/widgets

bad25b4

flutter-dashboard Bot added the CICD Run CI/CD label Sep 1, 2026

github-actions Bot added p: material_ui triage-design Should be looked at in design triage labels Sep 1, 2026

navaronbracke commented Sep 1, 2026

View reviewed changes

gemini-code-assist Bot reviewed Sep 1, 2026

View reviewed changes

navaronbracke commented Sep 1, 2026

View reviewed changes

navaronbracke mentioned this pull request Sep 1, 2026

[cross_imports] Remove widgets/drawer_test.dart flutter/flutter#192106

Closed

11 tasks done

elliette requested review from QuncCccccc and elliette September 1, 2026 21:25

elliette added the override: no changelog needed Override the check requiring CHANGELOG updates for most changes label Sep 2, 2026

elliette approved these changes Sep 2, 2026

View reviewed changes

Comment thread packages/material_ui/pending_changelogs/change_2026_09_01_1788252909308.yaml Outdated

QuncCccccc reviewed Sep 2, 2026

View reviewed changes

fix test name, remove changelog entry since the change is test only

07a2315

navaronbracke requested a review from QuncCccccc September 3, 2026 06:21

QuncCccccc approved these changes Sep 3, 2026

View reviewed changes

elliette added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 3, 2026

auto-submit Bot merged commit e9e34ec into flutter:main Sep 4, 2026
13 checks passed

navaronbracke deleted the move_drawer_tests_from_flutterwidgets branch September 4, 2026 21:24

This was referenced Sep 7, 2026

Roll Packages from 9af9c6076d79 to 2c91ffef3ad5 (12 revisions) flutter/flutter#192378

Closed

Roll Packages from 9af9c6076d79 to c0b28f64cec2 (13 revisions) flutter/flutter#192381

Closed


		expect(find.text('header'), findsOneWidget);

		Navigator.pop(savedContext);

	expect(semantics, includesNodeWith(label: 'Dismiss'));
	expect(semantics, includesNodeWith(label: const DefaultMaterialLocalizations().modalBarrierDismissLabel));

	expect(semantics, isNot(includesNodeWith(label: 'Dismiss')));
	expect(semantics, isNot(includesNodeWith(label: const DefaultMaterialLocalizations().modalBarrierDismissLabel)));

	testWidgets('Dismissible Drawer is hidden on Android (back button is used to dismiss)', (
	testWidgets('Dismissible Drawer barrier is hidden from semantics on Android (back button is used to dismiss)', (

Conversation

navaronbracke commented Sep 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Footnotes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Sep 1, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Sep 1, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Sep 1, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

elliette left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

navaronbracke commented Sep 1, 2026 •

edited

Loading