Repository navigation
[infra] Use a modified no-response workflow in flutter/packages - #12745
Merged
Merged
Conversation
elliette
marked this pull request as ready for review
September 3, 2026 22:01
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new GitHub Actions script, .github/scripts/no-response.js, which automates the closure of inactive pull requests labeled 'waiting for response' after 21 days. Feedback on this implementation suggests optimizing API usage by setting per_page: 100 across all paginated requests to prevent rate limiting. Additionally, the feedback recommends using optional chaining to safeguard against runtime errors when accessing nested properties of events and commits, and addressing a potential bug where deleted users could falsely trigger response detection.
tarrinneal
approved these changes
Sep 3, 2026
Comment on lines
+9
to
+10
| # Schedule for every 15 minutes. | ||
| - cron: '*/15 * * * *' |
Contributor
There was a problem hiding this comment.
I don't know what the norm is for our cron length for this type of thing, but I feel like every 15 minutes is a bit more than necessary. nbd probably
Member
Author
There was a problem hiding this comment.
Bumped to every 30 mins. 15 is what flutter/flutter is currently using for this label, we can switch down to 15 if the lag between when a contributor responds on a PR and when the label is removed is too slow.
Contributor
|
autosubmit label was removed for flutter/packages/12745, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
pull Bot
pushed a commit
to Mattlk13/flutter
that referenced
this pull request
Sep 9, 2026
…er#192485) flutter/packages@9af9c60...36e088a 2026-09-09 daniel.leon@cloudsufi.com [quick_actions] Adopt code-excerpts for README (flutter/packages#12643) 2026-09-08 65155920+0xharkirat@users.noreply.github.com [camera_web] Fix TypeError when reading the torch capability (flutter/packages#12647) 2026-09-08 gibbonsj97@gmail.com [google_maps_flutter_web] Avoid replacing advanced marker content on move (flutter/packages#11952) 2026-09-08 mit@google.com [material_ui][cupertino_ui] Change issue tracker label in pubspec.yaml (flutter/packages#12792) 2026-09-08 saurabhmirajkar000@gmail.com [material_ui] Fix FilledButton Material 3 default style docs (flutter/packages#12620) 2026-09-08 21270878+elliette@users.noreply.github.com [infra] Use a modified no-response workflow in flutter/packages (flutter/packages#12745) 2026-09-08 21270878+elliette@users.noreply.github.com [material_ui] Migrate M3 Banner template to use new gen_defaults (flutter/packages#12734) 2026-09-08 engine-flutter-autoroll@skia.org Roll Flutter from 63170e9 to b444e78 (13 revisions) (flutter/packages#12791) 2026-09-08 fluttergithubbot@gmail.com Sync release-go_router-18.0.1 to main (flutter/packages#12725) 2026-09-08 fluttergithubbot@gmail.com Sync release-material_ui-1.1.1 to main (flutter/packages#12726) 2026-09-08 stuartmorgan@google.com [tool] Adopt `platform` 3.2.0 (flutter/packages#12789) 2026-09-07 50643541+Mairramer@users.noreply.github.com [material_ui] Fix SliverGeometry maxPaintExtent assertion in CarouselView.weighted (flutter/packages#12563) 2026-09-05 engine-flutter-autoroll@skia.org Roll Flutter from 5a6cfa7 to 63170e9 (15 revisions) (flutter/packages#12767) 2026-09-04 engine-flutter-autoroll@skia.org Manual roll Flutter from 70797e1 to 5a6cfa7 (52 revisions) (flutter/packages#12760) 2026-09-04 brackenavaron@gmail.com [material_ui] port drawer tests over from flutter/widgets (flutter/packages#12711) 2026-09-04 tarrinneal@gmail.com add cooldown (flutter/packages#12708) 2026-09-04 joeldumasbg@gmail.com [in_app_purchase] Support StoreKit 2 introductory offer eligibility JWS (flutter/packages#12584) 2026-09-04 21270878+elliette@users.noreply.github.com [material_ui] Migrate M3 Badge template to use new gen_defaults (flutter/packages#12733) 2026-09-04 stuartmorgan@google.com [google_maps_flutter] Convert heatmap controller to Swift (flutter/packages#12713) 2026-09-04 97480502+b-luk@users.noreply.github.com [material_ui] Remove unused `maintainState` constructor parameter in `scaffold_test.dart` (flutter/packages#12754) 2026-09-04 a1rwulf@users.noreply.github.com [video_player_avfoundation] Route video over AirPlay (flutter/packages#12490) 2026-09-04 jerome.dellamaria@proton.me [google_fonts] Add google_fonts_lite file to allow tree-shaking of the other huge files (flutter/packages#11433) 2026-09-04 engine-flutter-autoroll@skia.org Roll Flutter from 0cbd1a4 to 70797e1 (27 revisions) (flutter/packages#12727) 2026-09-04 stuartmorgan@google.com Update Chrome for stable tests (flutter/packages#12747) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/packages
that referenced
this pull request
Sep 9, 2026
…ter#12745) Resolves flutter/flutter#191756 Allows us to use the `waiting for response` label on PRs. PRs with that label will be auto-closed after 21 days of no response. Copies the existing flutter/flutter [`no-response.yaml`](https://github.com/flutter/flutter/blob/71d1e7f487a3a8fd3a220b5a5b3c9d0061af79ee/.github/workflows/no-response.yaml) and [`no-response.js`](https://github.com/flutter/flutter/blob/fdb1d09ef8187cac7dd99daf261c5a8df28a618e/.github/scripts/no-response.js) files to flutter/packages, but removes all the issue-specific logic since issues are disabled on flutter/packages so we only need this to work for PRs. ## Pre-Review Checklist **Test exemption: Github workflow change.** **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
victorsanni
pushed a commit
to victorsanni/packages
that referenced
this pull request
Sep 9, 2026
…ter#12745) Resolves flutter/flutter#191756 Allows us to use the `waiting for response` label on PRs. PRs with that label will be auto-closed after 21 days of no response. Copies the existing flutter/flutter [`no-response.yaml`](https://github.com/flutter/flutter/blob/71d1e7f487a3a8fd3a220b5a5b3c9d0061af79ee/.github/workflows/no-response.yaml) and [`no-response.js`](https://github.com/flutter/flutter/blob/fdb1d09ef8187cac7dd99daf261c5a8df28a618e/.github/scripts/no-response.js) files to flutter/packages, but removes all the issue-specific logic since issues are disabled on flutter/packages so we only need this to work for PRs. ## Pre-Review Checklist **Test exemption: Github workflow change.** **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves flutter/flutter#191756
Allows us to use the
waiting for responselabel on PRs. PRs with that label will be auto-closed after 21 days of no response.Copies the existing flutter/flutter
no-response.yamlandno-response.jsfiles to flutter/packages, but removes all the issue-specific logic since issues are disabled on flutter/packages so we only need this to work for PRs.Pre-Review Checklist
[shared_preferences]///).Test exemption: Github workflow change.
If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2