Repository navigation
[cross_imports] Remove widgets/drawer_test.dart - #192106
Closed
navaronbracke wants to merge 1 commit into
Closed
navaronbracke wants to merge 1 commit into
navaronbracke wants to merge 1 commit into
Conversation
11 tasks done
justinmc
self-requested a review
September 1, 2026 22:24
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Sep 4, 2026
This PR moves tests from `packages/flutter` under `widgets/drawer_test.dart` into material_ui. Most tests were moved verbatim, except for a few tests that I renamed, because the test name was not very clear. The drawer control tests for Material 2/3 that already existed were updated to test some additional behavior. Part of flutter/flutter#177028 See flutter/flutter#192106 which removes the tests in flutter/flutter ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
victorsanni
pushed a commit
to victorsanni/packages
that referenced
this pull request
Sep 9, 2026
) This PR moves tests from `packages/flutter` under `widgets/drawer_test.dart` into material_ui. Most tests were moved verbatim, except for a few tests that I renamed, because the test name was not very clear. The drawer control tests for Material 2/3 that already existed were updated to test some additional behavior. Part of flutter/flutter#177028 See flutter/flutter#192106 which removes the tests in flutter/flutter ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
victorsanni
pushed a commit
to victorsanni/packages
that referenced
this pull request
Sep 9, 2026
) This PR moves tests from `packages/flutter` under `widgets/drawer_test.dart` into material_ui. Most tests were moved verbatim, except for a few tests that I renamed, because the test name was not very clear. The drawer control tests for Material 2/3 that already existed were updated to test some additional behavior. Part of flutter/flutter#177028 See flutter/flutter#192106 which removes the tests in flutter/flutter ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
navaronbracke
force-pushed
the
remove_drawer_tests_in_widgets
branch
from
September 14, 2026 06:50
611d2ec to
8034d34
Compare
victorsanni
approved these changes
Sep 25, 2026
Contributor
|
autosubmit label was removed for flutter/flutter/192106, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR. |
navaronbracke
force-pushed
the
remove_drawer_tests_in_widgets
branch
from
September 25, 2026 21:34
8034d34 to
1a3d11d
Compare
Contributor
|
An existing Git SHA, To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with |
Contributor
Author
|
Not sure what happened, but Github decided to close the PR after I told it to rebase through it's UI :( Pushed an empty commit to reopen it |
7 of 10 tasks
Contributor
Author
|
This is apparently superseded by #188486 which landed yesterday :P |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the drawer_test.dart under flutter/widgets.
This file contained two sets of tests:
These two tests are moved verbatim in flutter/packages#12711 with a change to their test name.
That only leaves the regression testing gap of the original two tests in widgets/drawer_test.dart
However, that should be covered with the test at https://github.com/flutter/flutter/blob/master/packages/flutter/test/widgets/modal_barrier_test.dart#L468
"Dismissible ModalBarrier includes button in semantic tree on iOS, macOS and android"
The only difference there is that Drawer does something different for Android, but that is up to the test in material_ui now.
Part of #177415
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.