Repository navigation
Move drawer tests from widgets to material - #188486
Conversation
There was a problem hiding this comment.
Code Review
This pull request consolidates drawer-related tests by moving several test cases—including control, tap, hover, drag, navigator, and semantics tests—from a deleted test file into packages/flutter/test/material/drawer_test.dart. There are no review comments, and I have no feedback to provide.
|
Given this a cross import fixing widgets importing material (versus material importing something bad), this is not a critical change for pre-release of material_ui. As such, I've marked this PR as not ready to port to flutter/packages yet. The changes not in the material or cupertino libraries will remain here, so this PR will need to be split in the future. (P.S. it also looks like this should update the allow list for cross imports) |
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Hey @Swiftaxe it looks like the analyzer is failing, can you take a look? |
4767798 to
4b1ed1b
Compare
Thanks for notifying me @Piinks. I pushed a fix and rebased against master. If there is anything else, I will be traveling for two weeks and will have limited ability to fix anything, but I will address anything as soon as I'm back. 😊 |
Renzo-Olivares
left a comment
There was a problem hiding this comment.
Mostly LGTM, but I had one small comment.
4b1ed1b to
cf03ace
Compare
|
It's time to land this PR! Thank you for waiting. Our plan is to no longer land changes in
As always, let me know if you need any help, and I appreciate your contribution! For guidance, instructions, and more details on this porting, see #188444. |
cf03ace to
0271e56
Compare
This PR has been split. Please find the Material UI changes in flutter/packages#12925 |
0271e56 to
6e31ca6
Compare
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
6e31ca6 to
32777ce
Compare
|
Hi @Swiftaxe Just to check in, did we do the same thing? I opened #192106 a while back, but it got a bit stale with code review. Apparently mine was outdated, so I rebased, but then it disappeared into nothingness with 0 changed files. Your PR landed yesterday, so that explains the timing. Thanks for helping out on cleaning up the test, though! |
|
@navaronbracke Thanks for investigating it and the contribution all the same! |
Relocating drawer tests that are testing Material widgets into the
materials folderMaterial UI package.This test is listed under #177415, but belongs under #177414.
While #177415 instructs against moving tests, these tests only test materials widgets and should be moved per #177414.
Following #177414's guidance for tests that fundamentally test Material, the tests are moved into the existing test/material/drawer_test.dart, and the misplaced test/widgets/drawer_test.dart is deleted.
Note: this PR has been split, and the tests are being moved into Material UI package flutter/packages#12925
Part of #177415
This PR does not require any changes to the flutter/tests repo.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.