Sitelet https://github.com/DiscUtils/DiscUtils/pull/60
Skip to content

Fix issue with incorrect signing - #60

Merged
LordMike merged 1 commit into
masterfrom
fix-signing
Aug 1, 2017
Merged

Fix issue with incorrect signing#60
LordMike merged 1 commit into
masterfrom
fix-signing

Conversation

@LordMike

@LordMike LordMike commented Aug 1, 2017

Copy link
Copy Markdown
Member

Fixes #58

@LordMike

LordMike commented Aug 1, 2017

Copy link
Copy Markdown
Member Author

Seems to have worked. I'm unsure what PublicSign is for (it's not set by VS)

..\DiscUtils.0.12.2-alpha.symbols\lib\netstandard1.5>sn -vf DiscUtils.dll

Microsoft (R) .NET Framework Strong Name Utility  Version 4.0.30319.0
Copyright (c) Microsoft Corporation.  All rights reserved.

Assembly 'DiscUtils.dll' is valid

@LordMike
LordMike merged commit 1da39bf into master Aug 1, 2017
@TripleEmcoder

TripleEmcoder commented Aug 1, 2017

Copy link
Copy Markdown

Here's an explanation of PublicSign (a.k.a. "OSS signing"):
https://github.com/dotnet/corefx/blob/master/Documentation/project-docs/public-signing.md

I'm new to this feature as well, but I think it's safe to disable it for DiscUtils.

@zivillian zivillian mentioned this pull request Aug 12, 2017
Merged
zivillian pushed a commit to ahdde/DiscUtils that referenced this pull request Aug 12, 2017
Bianco Veigel
Fix issue with incorrect signing (port DiscUtils#60)
04e0874
LordMike added a commit that referenced this pull request Aug 16, 2017
@LordMike
Release 0.13.0-alpha
f3efdf9 
Includes PRs:
#17, #18, #21, #22, #23, #27, #30, #31, #33, #34, #35, #36, #38, #39, #40, #41, #48, #51, #52, #55, #60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LordMike @TripleEmcoder