Don't attempt to parse the DTD for Plist files - #31

@LordMike Can you take a look at this? Thanks!

The default value of ProhibitDtd in XmlReaderSettings is true

so just passing a new instance of XmlReaderSettings to XmlReader.Create would be more "efficient", but your solution seems to be more specific about the desired settings.

In .NET Framework version 4.0 [...] The ProhibitDtd property has been deprecated

If I'm correct, your change would introduce a compiler warning.

you can set the DtdProcessing property to Ignore, which will [...] simply skip over it and not process it

I guess this is what you intended for .NET > 4.0.

(I haven't tested this and the linked documentation mentions only a beta version, so this might be incorrect.)

Totally forgot about this one.

Will we ever encounter PList files that use custom entities?

Would it be better to let DtdProcessing be an option the user sets, through some settings object?

@zivillian I perhaps misunderstood your comment; but this PR is not changing the value of ProhibitDtd; but it is setting DtdProcessing to Ignore on .NET 4 and above.

@LordMike

Will we ever encounter PList files that use custom entities?

I'm fairly sure that we will never encounter a Plist file with custom entities. Plist files can be serialized in various formats, XML being one of them. Plist doesn't have the notion of entities so you will not see any entities in the XML files generated by XML.

Would it be better to let DtdProcessing be an option the user sets, through some settings object?

Basically, on .NET 4.0 and above (this includes Core), DtdProcessing is always prohibited, so it must be set to Ignore, otherwise it won't work. You will never want to do DTD processing on Plist files, so I don't think there is any value to letting the user change that value.

@LordMike @zivillian Back from vacation, rebased the PR, the build now passes, let me know if this is good to go.

@qmfrederik It looks like I've misread your code - judging the comments and the changes this should be fine.

@qmfrederik put a note in the ifdef where you set the DtdIgnore property explaining that i MUST be set to Ignore on anything by net20. Then it should be good to go.

@LordMike Should be good to go now ;-)