enable unittests for net45 - #37
Conversation
|
|
To be clear: I only disabled The condition was actually stolen from an asp.net core example (or the MS docs), but I have no idea, what the reason behind this condition is since I was not able to find any useful documentation. |
|
I've rebased onto #60 and also enabled the unit tests for net45 in appveyor. There is still an issue with parallel test execution on net45 (thus the failing build) - I will look into this. |
|
The last commit disables parallel test execution, which fixes the build. Since the whole discutils project is not thread safe, I guess there is no benefit in trying to make the collections of registered modules thread safe. |
|
Thanks! |
This PR enables unit test support for the net452 framework (the lowest supported by xunit 2.2.0). Since the xunit runner is signed, I had to disable PublisSign (at least for the windows platform) - otherwise the clr would refuse to load the assemblies.
As an optimization I've also disable the creation of nuget packages for debug builds (to speed up build and test time).
The is still an issue with the sample data tests for xfs and lvm2 failing with an OutOfMemoryException on 32Bit under net452. As a workaround the runner can be started as 64bit using the following commandline:
There is also an option for VS.
To prevent a possibly broken CI I've modified the appveyor.yml to run only the netcoreapp1.1 tests.
There are still many known problems with xunit and net452 like having to delete temporary folders and restarting VS to be able to run those tests from within VS, but those are out of scope for this project.