Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft for discussion. This works on my M1 Mac, and I haven't tested it anywhere else.
Why:
nw0.71.1 has noosx-arm64build (dl.nwjs.io returns 404), so the Mac app only runs under Rosetta.Changes
nw→ 0.104.1, which shipsosx-arm64.package-lock.jsonis deliberately left out: mine regenerated as lockfile v3 (7,500 lines). Please regenerate it with your npm.tasks/release_osx.js:Contents/Versionsto the bundle root. It left a strayFrameworks/there, which breakscodesign --verify.Info.plistinstead of replacing it with the old template. This also sets the bundle identifier tocom.cryptotrust.onlykey; change it as you prefer.hdiutilwhenappdmgcan't be installed. It didn't build on Node 26.tray.js: on macOS, skipautoLaunch.isEnabled()at startup. It calls System Events via AppleScript, which raises an Automation permission popup at launch. The stored preference is used instead, and the OS is still asked when the menu item is clicked.OnlyKeyWizard.js/OnlyKeyComm.js/dialog-links.js: on nw 0.104 on macOS, the page sometimes stays inreadyState: "loading", soDOMContentLoadedandloadnever fire, and the wizard and HID init never run. It happens reliably when the app is launched from the Dock. Both inits are now idempotent and are also called from the last script on the page. This is a workaround; I didn't find the root cause.Tested: macOS on M1, OnlyKey DUO firmware v3.0.3. It detects the key and reads its unlocked state, launched from both the Dock and the terminal. I haven't tested Windows, Linux, the auto-updater or the other feature tabs.
I also saw #242 (6.0.0). This merges cleanly on top of it.
🤖 Generated with Claude Code