You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In particular, move unittest-related files in idlelib.idle_test to a new test/test_idle directory and split test/test_idle.py into test_idle/__init__.py and test_idle/__main__.py. This is a followup to #54781 and similar issues before and after. Note that I want idle_test and any non-unittest files (at least htest.py and part of README.txt) left as they are.
Other core developers want this for consistency, as best explained by Victor Stinner in #93839 (comment). None of those benefits apply to me, and there are costs to the change that could or would make IDLE development harder, perhaps significantly so.
The costs come from some of idlelib's special features as a package: a) it comprises about 60 modules, far more than any other stdlib package; b) the test suite is underdeveloped relative to at least some other packages, so there are (or should be) relatively more future test changes to be impacted; c) PEP 434 allows name changes and backports not allowed elsewhere in the stdlib, so there are many more of these.
Search and replacement: a multifile recursive search currently displays all hits in idlelib and idlelib.idle_test with one command and puts all hits in one window. When editing any idlelib file, Alt-F3 opens IDLE's grep with idlelib as the default search directory. Having to give the command twice and having the results in two windows would be a pain. (IDLE's grep could special case recursive searches in idlelib to include test.test_idle.)
Existing PRs: I would guess that there are at least 20 current PRs that modify IDLE tests. Will they all break or will old paths be automatically mapped to new paths. If they will break, I would want an automated fix (for just main) or else dispose of most of them before moving the tests.
Backports: currently, code backports, which are nearly always done, are accompanied by any corresponding test changes. Victor claims in gh-95069: Move Lib/idlelib/idle_test/ to Lib/test/test_idle/ #94145 that git will always (my emphasis) map new paths in a PR to the old paths. (This would require that it keep a reverse dictionary of path changes.) I would like to see this work before I believe this.
I removed IDLE from the previous issue so it could be closed as done and so I could state my objections clearly. I believe I intended to close this after giving others a chance to comment and perhaps to give myself to think more and test a revised PR, which is not available.
In particular, move unittest-related files in idlelib.idle_test to a new test/test_idle directory and split
test/test_idle.pyintotest_idle/__init__.pyandtest_idle/__main__.py. This is a followup to #54781 and similar issues before and after. Note that I want idle_test and any non-unittest files (at least htest.py and part of README.txt) left as they are.Other core developers want this for consistency, as best explained by Victor Stinner in #93839 (comment). None of those benefits apply to me, and there are costs to the change that could or would make IDLE development harder, perhaps significantly so.
The costs come from some of idlelib's special features as a package: a) it comprises about 60 modules, far more than any other stdlib package; b) the test suite is underdeveloped relative to at least some other packages, so there are (or should be) relatively more future test changes to be impacted; c) PEP 434 allows name changes and backports not allowed elsewhere in the stdlib, so there are many more of these.
Search and replacement: a multifile recursive search currently displays all hits in idlelib and idlelib.idle_test with one command and puts all hits in one window. When editing any idlelib file, Alt-F3 opens IDLE's grep with idlelib as the default search directory. Having to give the command twice and having the results in two windows would be a pain. (IDLE's grep could special case recursive searches in idlelib to include test.test_idle.)
Existing PRs: I would guess that there are at least 20 current PRs that modify IDLE tests. Will they all break or will old paths be automatically mapped to new paths. If they will break, I would want an automated fix (for just main) or else dispose of most of them before moving the tests.
Backports: currently, code backports, which are nearly always done, are accompanied by any corresponding test changes. Victor claims in gh-95069: Move Lib/idlelib/idle_test/ to Lib/test/test_idle/ #94145 that git will always (my emphasis) map new paths in a PR to the old paths. (This would require that it keep a reverse dictionary of path changes.) I would like to see this work before I believe this.
Linked PRs
idlelib.idle_testtotest.test_idle#115444