Repository navigation
Change base OS image to Ubuntu-24.04 in CI testing #122544
Description
Activity
- addedtype-featureA feature request or enhancementA feature request or enhancement
on Aug 1, 2024 - changed the title
[-]Change base OS image to Ubuntu-24.04 in ci.yaml[/-][+]Change base OS image to Ubuntu-24.04 in CI testing[/+]on Aug 1, 2024 Thanks for the report, we're using
ubuntu-22.04in Read the Docs, Azure Pipelines and GitHub Actions:❯ rg ubuntu-22.04 .readthedocs.yml 11: os: ubuntu-22.04 .azure-pipelines/ci.yml 8: vmImage: ubuntu-22.04 .azure-pipelines/pr.yml 8: vmImage: ubuntu-22.04 20: vmImage: ubuntu-22.04 .github/workflows/build.yml 47: runs-on: ubuntu-22.04 198: runs-on: ubuntu-22.04 264: runs-on: ubuntu-22.04 378: runs-on: ubuntu-22.04 .github/workflows/reusable-wasi.yml 12: runs-on: ubuntu-22.04 .github/workflows/reusable-tsan.yml 22: runs-on: ubuntu-22.04 .github/workflows/reusable-ubuntu.yml 17: runs-on: ubuntu-22.04
Yes, let's upgrade, assuming all the dependencies and everything installs fine.
Would you like to open some PRs? I suggest a separate PR for each of Read the Docs, Azure Pipelines and GitHub Actions.
Sure!, Of course, I'd love to contribute to this, let me first investigate if it would affect the result of CI testing if just simply change
ubuntu-22.04toubuntu-24.04.Reacted by Hugo van KemenadeWe are also using Ubuntu 22.04 for generating the configure script in the Docker image but I don't think we should change this one. This is in
Tools/build/regen-configure.sh(I don't know whether the CI/CD is using its own packages or whether is using the docker script to check the configuration scripts)The comment at the top says they should match:
cpython/Tools/build/regen-configure.sh
Lines 5 to 8 in fda6bd8
# The check_generated_files job of .github/workflows/build.yml must kept in # sync with this script. Use the same container image than the job so the job # doesn't need to run autoreconf in a container. IMAGE="ubuntu:22.04" Which should be the same as this one:
cpython/.github/workflows/build.yml
Lines 43 to 47 in fda6bd8
check_generated_files: name: 'Check if generated files are up to date' # Don't use ubuntu-latest but a specific version to make the job # reproducible: to get the same tools versions (autoconf, aclocal, ...) runs-on: ubuntu-22.04 The comment at the top says they should match:
Oh then we should update both of them then! (and I'll need to update my PR in the devguide as well)
Some other
ymlfile based onubunut-latest, for exmaple: injit.yml. based on
https://github.com/actions/runner-images description,ubuntu-latestis actuallyubuntu-22.04, should those file mentionedubuntu-latestneed to upgrade ubuntu version ?architecture: x86_64runner: ubuntu-latest compiler: gcc - target: x86_64-unknown-linux-gnu/clang architecture: x86_64 runner: ubuntu-latest compiler: clang - target: aarch64-unknown-linux-gnu/gcc architecture: aarch64 runner: ubuntu-latest compiler: gcc - target: aarch64-unknown-linux-gnu/clang architecture: aarch64 runner: ubuntu-latest compiler: clangNo, let's not change any
ubuntu-latest.In fact, https://github.com/actions/runner-images?tab=readme-ov-file#available-images says
ubuntu-24.04is still beta, maybe we should wait until it is in GA (General Availability)?Do you know when GA is planned?
Reacted by ÉricAccording to there discussion in
actions/runner-images#9691
The GA will be somewhere in August-2024, I think it should be soon.I think we can move all CI-testing step-by-step.
First change trivial CI testiing(like readthedocs) toubuntu-24.04to make sure everything works correctly.
If everthing goes well, then we can wait its GA and move core part(like checking JIT) toubuntu-24.04gradually- added a commit that references this issue
on Aug 2, 2024 20 remaining items
- added a commit that references this issue
on Nov 22, 2024 - added a commit that references this issue
on Jan 11, 2025 - added a commit that references this issue
on Feb 18, 2025
In current
ci.yml, base OS image isubuntu-22.04, should we move to the latest LTS verion:ubuntu-24.04?To go further, if we should replace all current CI testing which run on
ubuntu-22.04toubuntu-24.04?Linked PRs