Sitelet https://github.com/nodejs/node/issues/238#top
Skip to content

Intl #238

Description

@rvagg

This has landed in joyent/node from what I understand and from nodejs/node-v0.x-archive#7676 (comment) it seems that we may be adjusting builds to do ./configure --with-intl=small-icu and vcbuild.bat small-icu if we are to stay in step.

As far as I know @piscisaureus has been the only one to raise objections to the way Intl is being handled, specifically with regard to the download step and increase in binary size even with small-icu. Is there anything we need to discuss here or is that a discussion for joyent/node and we're just going to follow along?

Then there's our impending 1.0.0-alpha release. I'd really like to see the Intl changes land in io.js ASAP so we can get them properly tested in our CI and be part of our initial release. Then we just have to agree about the build configuration for release.

  • Action: someone land the Intl changes here please
  • Action: discussion required about how io.js handles Intl, whether small-icu is enabled for releases and what we enable for general CI builds

Activity

  1. bnoordhuis commented on Jan 6, 2015

    @bnoordhuis
    Member
  2. bnoordhuis commented on Jan 6, 2015

    @bnoordhuis
    Member

    By the way:

    Then there's our impending 1.0.0-alpha release. I'd really like to see the Intl changes land in io.js ASAP so we can get them properly tested in our CI and be part of our initial release.

    This is the case after yesterday's merge in commit 94e1475.

  3. added this to the milestone on Jan 12, 2015
  4. rvagg commented on Jan 12, 2015

    @rvagg
    MemberAuthor

    put on the v1.0.0 milestone as this needs a final decision, we didn't get much TC engagement in the last meeting on this and I want to be sure we want to go live with 1.0.0 without even small-icu

  5. bnoordhuis commented on Jan 12, 2015

    @bnoordhuis
    Member

    I want to be sure we want to go live with 1.0.0 without even small-icu

    +1 from me. Intl is a nice-to-have at this point, not a blocker.

  6. rvagg commented on Jan 13, 2015

    @rvagg
    MemberAuthor

    going to cross this off the list for the purposes of 1.0.0 now, confirmation from @bnoordhuis and @piscisaureus is enough for me (particularly given that they are the ESL members of the TC)

  7. ruimarinho commented on Jan 13, 2015

    @ruimarinho

    Just my two cents - we should postpone this and discuss how we want to integrate with Intl more thoroughly. Shipping with small-icu which, afaik, is equivalent to ship the full API but with just English support, doesn't bring anything special to the table to 1.0.0. @rvagg shouldn't this be re-added to the next tc-agenda (after 1.0.0)?

  8. rvagg commented on Jan 13, 2015

    @rvagg
    MemberAuthor

    @ruimarinho perhaps, if you feel it important enough then you could remind us prior to a TC meeting, I'm not going to label it right now

  9. added a commit that references this issue on Jan 13, 2015
  10. removed this from the milestone on Jan 29, 2015
  11. keithamus commented on Feb 12, 2015

    @keithamus

    I have no idea if this will be helpful to anyone (seems like maintains are very much aware of this), but I'm currently working on a PR for testing Intl support on Kangax's Compat Table.

    Here's the ouput:
    screen shot 2015-02-12 at 21 39 44

  12. rvagg commented on Feb 13, 2015

    @rvagg
    MemberAuthor

    We have a standing item to try and get @srl295 on to a TC meeting to discuss this in more depth, I'll keep chipping away at him and we may get him to agree some time! The main concerns are about packing size and @piscisaureus has been doing some work on that too.

  13. srl295 commented on Feb 13, 2015

    @srl295
    Member

    @rvagg yes and - as to size - faq entry and my nodesummit presentation discusses some. .. i'm working on some other PRs around the data packaging and docs also.

  14. srl295 commented on Feb 19, 2015

    @srl295
    Member

    @rvagg hi, was any of the above related to your questions?

  15. rvagg commented on Feb 19, 2015

    @rvagg
    MemberAuthor

    wasn't so much me that had questions, the TC is likely to remain a -0 on bundling Intl support for the moment because of concerns about size

  16. 27 remaining items

  17. jasnell commented on Jul 19, 2015

    @jasnell
    Member

    @silverwind : yeah, this was discussed on the last tsc call. @srl295 and I have the action to get that PR put together. Realistically it'll be early to mid next week.

  18. silverwind commented on Jul 19, 2015

    @silverwind
    Contributor

    @jasnell great!

    FYI, #2165 doesn't strictly depend on it if we delegate unicode normalization to the user, but it'd be nice to point users to String.prototype.normalize as an advice.

  19. added
    buildIssues and PRs related to Node.js builds or CI infrastructure.
    on Jul 20, 2015
  20. srl295 commented on Jul 22, 2015

    @srl295
    Member

    porting to io.js's master

    @silverwind yes my issue for doing that is #26 and I"m working on doing exactly that

  21. added
    i18n-apiIssues and PRs related to Node.js internationalization support.
    on Aug 10, 2015
  22. srl295 commented on Aug 11, 2015

    @srl295
    Member

    As I understand it, this specific issue should be closed when #2264 lands. Please let me know if anyone understands differently.

  23. added a commit that references this issue on Aug 13, 2015
  24. srl295 commented on Aug 13, 2015

    @srl295
    Member

    Landed in 2781333

  25. srl295 commented on Dec 16, 2015

    @srl295
    Member

    Postscript: ICU upstream is going to adopt a plaintext license as formatted for node. http://bugs.icu-project.org/trac/ticket/12037

  26. jasnell commented on Dec 16, 2015

    @jasnell
    Member
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    buildIssues and PRs related to Node.js builds or CI infrastructure.i18n-apiIssues and PRs related to Node.js internationalization support.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions