Sitelet https://github.com/kubernetes/test-infra/pull/37492
Skip to content

Adding CONTROL_PLANE_SIZE env - #37492

Closed
YahiaBadr wants to merge 1 commit into
kubernetes:masterfrom
YahiaBadr:agentic-tests
Closed

Adding CONTROL_PLANE_SIZE env#37492
YahiaBadr wants to merge 1 commit into
kubernetes:masterfrom
YahiaBadr:agentic-tests

Conversation

@YahiaBadr

@YahiaBadr YahiaBadr commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@kubernetes-prow kubernetes-prow Bot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 20, 2026
@kubernetes-prow
kubernetes-prow Bot requested review from mm4tt and wojtek-t July 20, 2026 12:03
@kubernetes-prow kubernetes-prow Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 20, 2026
@kubernetes-prow

kubernetes-prow Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Hi @YahiaBadr. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow

kubernetes-prow Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: YahiaBadr
Once this PR has been reviewed and has the lgtm label, please assign serathius for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added area/config Issues or PRs related to code in /config area/jobs sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 20, 2026
Qqkyu
Qqkyu reviewed Jul 20, 2026
View reviewed changes

@Qqkyu Qqkyu left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2026
@serathius

serathius commented Jul 20, 2026

Copy link
Copy Markdown
Member

What's the diff here? What is the default here?

@YahiaBadr

YahiaBadr commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

What's the diff here? What is the default here?

https://github.com/kubernetes/kops/blob/master/tests/e2e/scenarios/scalability/run-test.sh#L136

c5.2xlarge (aws machine)

@serathius

serathius commented Jul 20, 2026

Copy link
Copy Markdown
Member

Ok, seems like the defaulting is AWS specific, can we update the run-test.sh to have a separate sensible default for GCE?

@YahiaBadr

YahiaBadr commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

Ok, seems like the defaulting is AWS specific, can we update the run-test.sh to have a separate sensible default for GCE?

Sure, done kubernetes/kops#18612

@YahiaBadr

YahiaBadr commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

No need for the PR as kubernetes/kops#18612 is merged

@YahiaBadr YahiaBadr closed this Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mm4tt mm4tt Awaiting requested review from mm4tt
@wojtek-t wojtek-t Awaiting requested review from wojtek-t
1 more reviewer
@Qqkyu Qqkyu Qqkyu left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@Qqkyu Qqkyu

Labels

area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@YahiaBadr @serathius @Qqkyu