scaletest: report experiment variant after kubetest2 runs - #18485
Conversation
| "${CLUSTERLOADER2_ARGS[@]}" | ||
| "${CLUSTERLOADER2_ARGS[@]}" || rc=$? | ||
|
|
||
| # Add the variant after kubetest2, which would otherwise overwrite metadata.json. |
There was a problem hiding this comment.
Are you saying there is no feature of kubetest that would ask it to add this metadata for us? We need to hack around and add it ourselves.
There was a problem hiding this comment.
I didn't find anything around it, we're the only ones trying to setup a custom testgrid. dra doesn't use kubetest2 so they had no problems with the metadata injection. Can probably add a feature in kubetest2 but that will probably take some effort/time
There was a problem hiding this comment.
Sounds good, thanks for looking into that.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: serathius The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm cancel |
7520d00 to
70848b4
Compare
Working around |
|
/lgtm |
The variant added in #18476 shows up as "missing" in the TestGrid column header:
https://testgrid.k8s.io/sig-scalability-gce#pull-kubernetes-e2e-gce-master-scale-performance-5000
The metadata.json write needs to happen after the kubetest2 command finishes, otherwise kubetest2 overwrites it.
Part of kubernetes/test-infra#37273
/assign @serathius