Sitelet https://github.com/kubernetes/kops/commit/70848b43d1a9243058f9ea11850288f71cdec7f0
Skip to content

Commit 70848b4

Browse files
committed
scaletest: report experiment variant after kubetest2 runs
1 parent 795502a commit 70848b4

1 file changed

Lines changed: 10 additions & 6 deletions

File tree

‎tests/e2e/scenarios/scalability/run-test.sh‎

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,6 @@
1717
set -e
1818
set -x
1919

20-
# Report the experiment variant so TestGrid can show it as a column header.
21-
if [[ -n "${ARTIFACTS:-}" ]]; then
22-
echo "{\"variant\":\"${EXPERIMENT_VARIANT:-base}\"}" > "${ARTIFACTS}/metadata.json"
23-
fi
24-
2520
make test-e2e-install
2621

2722
REPO_ROOT=$(git rev-parse --show-toplevel)
@@ -261,6 +256,7 @@ if [[ "${SCALE_SCENARIO:performance}" == "correctness" ]]; then
261256
--skip-regex="\[Driver:.gcepd\]|\[Serial\]|\[Disruptive\]|\[Flaky\]|\[Feature:([^L].*|L[^o].*|Lo[^a].*|Loa[^d].*)\]\[KubeUp\]" \
262257
--parallel=25
263258
else
259+
rc=0
264260
kubetest2 kops "${KUBETEST2_ARGS[@]}" \
265261
--up \
266262
--kubernetes-version="${K8S_VERSION}" \
@@ -270,5 +266,13 @@ else
270266
--provider="${CLOUD_PROVIDER}" \
271267
--repo-root="${GOPATH}"/src/k8s.io/perf-tests \
272268
--kube-config="${HOME}/.kube/config" \
273-
"${CLUSTERLOADER2_ARGS[@]}"
269+
"${CLUSTERLOADER2_ARGS[@]}" || rc=$?
270+
271+
# Add the variant after kubetest2, which would otherwise overwrite metadata.json.
272+
if [[ -n "${ARTIFACTS:-}" ]]; then
273+
if jq --arg v "${EXPERIMENT_VARIANT:-base}" '. + {variant:$v}' "${ARTIFACTS}/metadata.json" >"${ARTIFACTS}/metadata.json.tmp"; then
274+
mv "${ARTIFACTS}/metadata.json.tmp" "${ARTIFACTS}/metadata.json" || true
275+
fi
276+
fi
277+
exit $rc
274278
fi

0 commit comments

Comments
 (0)