dump: add --node-dump-timeout flag for per-node dump timeout - #18443
Merged
k8s-ci-robot merged 1 commit intoJun 8, 2026
Merged
Conversation
Jefftree
force-pushed
the
dump-scope-nodetimeout-to-connect
branch
from
June 3, 2026 23:12
ce30ce2 to
4f63bb5
Compare
Jefftree
force-pushed
the
dump-scope-nodetimeout-to-connect
branch
from
June 3, 2026 23:50
4f63bb5 to
88bf147
Compare
Member
Author
|
/assign @hakman |
Member
|
/lgtm |
Member
Author
|
I spoke to @hakman who mentioned that it's not ideal to change the default as that blocks 5 node clusters for ~25mins instead of ~5. Would it be possible to add another param to make this configurable for scalability tests then? |
Jefftree
force-pushed
the
dump-scope-nodetimeout-to-connect
branch
from
June 5, 2026 23:09
88bf147 to
36052d5
Compare
hakman
approved these changes
Jun 8, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the per-node log dump timeout configurable with a new --node-dump-timeout flag (default unchanged at 1m) so scale tests can raise it
Fixes #18442