Sitelet https://github.com/kubernetes/kops/pull/18260
Skip to content

azure: encode storage account in azureblob:// URLs - #18260

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
hakman:azure-embed-st-account
May 6, 2026
Merged

k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
hakman:azure-embed-st-account

Conversation

@hakman

@hakman hakman commented May 1, 2026

Copy link
Copy Markdown
Member

Move the Azure storage account name from the AZURE_STORAGE_ACCOUNT env var into the URL so each azureblob:// path is self-contained. New format: azureblob://{account}/{container}/{key}.

The env var is no longer read by kops; the legacy URL form is rejected with a migration error pointing users at the new shape.

/cc @rifelpet @justinsb

@k8s-ci-robot
k8s-ci-robot requested review from justinsb and rifelpet May 1, 2026 13:55
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. area/api area/documentation area/nodeup labels May 1, 2026
@hakman

hakman commented May 1, 2026

Copy link
Copy Markdown
Member Author

/test pull-kops-e2e-azure-cni-cilium

@hakman
hakman force-pushed the azure-embed-st-account branch from 1a19654 to a5d6563 Compare May 1, 2026 20:27
@hakman

hakman commented May 1, 2026

Copy link
Copy Markdown
Member Author

/test pull-kops-e2e-azure-cni-cilium

Move the Azure storage account name from the AZURE_STORAGE_ACCOUNT env
var into the URL so each azureblob:// path is self-contained. New
format: azureblob://{account}/{container}/{key}.

The env var is no longer read by kops; the legacy URL form is rejected
with a migration error pointing users at the new shape.

Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
@hakman
hakman force-pushed the azure-embed-st-account branch from a5d6563 to acf08f5 Compare May 2, 2026 03:29
@hakman

hakman commented May 2, 2026

Copy link
Copy Markdown
Member Author

/test pull-kops-e2e-azure-cni-cilium

@hakman

hakman commented May 2, 2026

Copy link
Copy Markdown
Member Author

All tests are green now.

@hakman

hakman commented May 2, 2026

Copy link
Copy Markdown
Member Author

/test all

@rifelpet rifelpet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 5, 2026
@hakman

hakman commented May 6, 2026

Copy link
Copy Markdown
Member Author

/approve

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2026
@hakman

hakman commented May 6, 2026

Copy link
Copy Markdown
Member Author

/test all

@hakman

hakman commented May 6, 2026

Copy link
Copy Markdown
Member Author

/test pull-kops-e2e-k8s-gce-cilium

@k8s-ci-robot
k8s-ci-robot merged commit 2ae8ea1 into kubernetes:master May 6, 2026
29 checks passed
k8s-ci-robot added a commit that referenced this pull request May 12, 2026
…-upstream-release-1.35

Automated cherry pick of #18260: azure: encode storage account in azureblob:// URLs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/documentation area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants