Remove TODO for signed and unordered comparisons - #791
Merged
Merged
Conversation
We no longer need those builtins: - PR gpuweb#772 added type rules for signed integer comparisons - Resolution of gpuweb#706 is to not have unordered floating point comparisons as a direct language feature.
dj2
approved these changes
May 19, 2020
kvark
approved these changes
May 20, 2020
JusSn
pushed a commit
to JusSn/gpuweb
that referenced
this pull request
Jun 8, 2020
We no longer need those builtins: - PR gpuweb#772 added type rules for signed integer comparisons - Resolution of gpuweb#706 is to not have unordered floating point comparisons as a direct language feature.
JusSn
pushed a commit
to JusSn/gpuweb
that referenced
this pull request
Jun 8, 2020
We no longer need those builtins: - PR gpuweb#772 added type rules for signed integer comparisons - Resolution of gpuweb#706 is to not have unordered floating point comparisons as a direct language feature.
ben-clayton
added a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
Apparently you cannot use a Promise that has had `.finally()` called on it for other `.then()` / `.finally()` type uses, you *must* use the returned Promise. Fixes weird failures that have been observed in the Chromium CTS roll.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We no longer need those builtins:
signed integer comparisons
have unordered floating point comparisons as a direct language
feature.