Add type rules for binary operators by dneto0 · Pull Request #772 · gpuweb/gpuweb

dneto0 · 2020-05-12T22:54:41Z

Fixes #726

dneto0 · 2020-05-12T22:55:26Z

I think I got all the binary operators in the grammar.

The matrix ones are confusing, please check. I'm going off matrixNxM means N columns an M rows.

dneto0 · 2020-05-14T18:48:33Z

Also fixes #707

dj2 · 2020-05-19T17:29:40Z

+       <td>Component-wise logical shift right (OpShiftRightLogical)
+  <tr><td>*e1* : i32<br>
+          *e2* : i32<br>
+       <td class="nowrap">`e1 >> e2` : u32


Ah, right. I forgot about that.

It turns out we have >> and >>> exactly opposite to what Java does.
https://docs.oracle.com/javase/tutorial/java/nutsandbolts/op3.html

I'll file an issue for that.

I filed #790

dj2 · 2020-05-19T17:29:50Z

+  <tr><td>*e1* : *T*<br>
+          *e2* : *T*<br>
+          *T* is vec*N*&lt;i32&gt;
+       <td class="nowrap">`e1 >> e2` : *T*


Sorry, I've lost the context now.

Usually it's a ditto to the comment above, so I'm guessing this is in reference to >> vs >>>?

dj2 · 2020-05-19T17:38:37Z

+  <tr><td>*e1* : u32<br>
+          *e2* : u32<br>
+       <td class="nowrap">`e1 != e2` : bool
+       <td>Inequality (OpIEqual)


OpINotEqual ?

dj2 · 2020-05-19T17:40:00Z

+       <td>Component-wise equality (OpIEqual)
+  <tr><td>*e1* : *T*<br>
+          *e2* : *T*<br>
+          *T* is vec*N*&ltin;i32&gt;


dj2 · 2020-05-19T17:40:44Z

+          *e2* : *T*<br>
+          *T* is vec*N*&lt;u32&gt;
+       <td class="nowrap">`e1 != e2` : vec*N*&lt;bool&gt;
+       <td>Component-wise inequality (OpIEqual)


OpINotEqual

grorg · 2020-05-19T18:30:48Z

Discussed at the 2020-05-19 meeting.

pow2clk · 2020-05-19T18:39:07Z

+  <tr><td>*e1* : *T*<br> *e2* : *T*<br> *T* is *FloatVec*<td>`e1 / e2` : *T*<td>Component-wise floating point division (OpFDiv)
+  <tr><td>*e1* : *T*<br> *e2* : *T*<br> *T* is *IntVec* with unsigned component<td>`e1 % e2` : *T*<td>Component-wise unsigned integer modulus (OpUMod)
+  <tr><td>*e1* : *T*<br> *e2* : *T*<br> *T* is *IntVec* with signed component<td>`e1 % e2` : *T*<td>Component-wise signed integer remainder (OpSMod)
+  <tr><td>*e1* : *T*<br> *e2* : *T*<br> *T* is *FloatVec*<td>`e1 % e2` : *T*<td>Component-wise floating point division (OpFMod)


Not division, remainder or modulus.

Fixed in next commit to "modulus"

pow2clk · 2020-05-19T18:43:52Z

+  <tr><td>*e1* : u32<br> *e2* : u32<td>`e1 / e2` : u32<td>Unsigned integer division (OpUDiv)
+  <tr><td>*e1* : i32<br> *e2* : i32<td>`e1 / e2` : i32<td>Signed integer division (OpSDiv)
+  <tr><td>*e1* : f32<br> *e2* : f32<td>`e1 / e2` : f32<td>Floating point division (OpFAdd)
+  <tr><td>*e1* : u32<br> *e2* : u32<td>`e1 % e2` : u32<td>Unsigned integer modulus (OpUMod)


Is it helpful to draw a distinction between modulus and remainder for an unsigned number? The difference concerns negative numbers. For clarity and consistency, could we not call them something different here?

Good question. I would say these are the type rules, and are not a complete spec of how arithmetic works. I expect we'll need a whole other section to specify the behaviours of operations. We may end up migrating descriptions over to that new section. I am coming around to the need for a larger scale reorg of the spec.

pow2clk · 2020-05-19T19:10:51Z

+          *T* is *FloatVec*
+      <td>`e1 * e2` : *T*<br>
+          `e2 * e1` : *T*
+      <td>Scalar multiplication of vector (OpVectorTimesScalar)


I think it would be helpful to say "multiplication of a vector and a scalar"

Fixed in c495d96

pow2clk · 2020-05-19T19:11:02Z

+          *T* is mat*N*x*M*&lt;f32&gt;
+      <td>`e1 * e2` : *T*<br>
+          `e2 * e1` : *T*
+      <td>Scalar multiplication of matrix (OpMatrixTimesScalar)


I think it would be helpful to say "multiplication of a matrix and a scalar"

fixed in commit c495d96

pow2clk · 2020-05-19T19:14:53Z

+          *e2* : mat*M*x*K*&lt;f32&gt;<br>
+      <td>`e1 * e2` : mat*M*x*N*&lt;f32&gt;<br>
+      <td>Matrix times matrix (OpMatrixTimesMatrix)
+</table>


I don't see matrix x matrix multiplication in here. I expect we follow the same rules we learned in trigonometry class, but it might be worth mentioning for completeness.

? Matrix times matrix is at line 1773-1776

We no longer need those builtins: - PR gpuweb#772 added type rules for signed integer comparisons - Resolution of gpuweb#706 is to not have unordered floating point comparisons as a direct language feature.

We no longer need those builtins: - PR #772 added type rules for signed integer comparisons - Resolution of #706 is to not have unordered floating point comparisons as a direct language feature.

Fixes gpuweb#726

- Use >>> as it's used in the grammar - Fix typographical < - Fix comments about correspondence to OpINotEqual

Fixes gpuweb#825

kainino0x · 2020-06-02T23:18:45Z

+  <tr><td>`SHIFT_RIGHT`<td>>>
  <tr><td>`LESS_THAN`<td><
  <tr><td>`LESS_THAN_EQUAL`<td><=
  <tr><td>`SHIFT_LEFT`<td><<


nit: These should really (eventually) be escaped somehow to avoid weird html parsing issues. I'd just put them in code tags: `<<` etc.

We no longer need those builtins: - PR gpuweb#772 added type rules for signed integer comparisons - Resolution of gpuweb#706 is to not have unordered floating point comparisons as a direct language feature.

dneto0 requested review from kdashg and litherum May 12, 2020 22:54

dneto0 mentioned this pull request May 13, 2020

Missing mapping for OpFRem, and MODULO token missing #702

Closed

dneto0 added wgsl resolved Resolved - waiting for a change to the WGSL specification wgsl WebGPU Shading Language Issues labels May 14, 2020

dneto0 added this to the MVP milestone May 14, 2020

grorg mentioned this pull request May 18, 2020

Rule for mixed-signedness operands to integer div, rem, less-than, greater-than, less-or-equal, greater-or-equal #707

Closed

dj2 reviewed May 19, 2020

View reviewed changes

pow2clk reviewed May 19, 2020

View reviewed changes

dneto0 mentioned this pull request May 19, 2020

Remove TODO for signed and unordered comparisons #791

Merged

dj2 approved these changes May 21, 2020

View reviewed changes

dneto0 added 6 commits June 2, 2020 15:04

Add type rules for binary operators

1afb319

Fixes gpuweb#726

Fixes from review

f67a3c0

- Use >>> as it's used in the grammar - Fix typographical < - Fix comments about correspondence to OpINotEqual

Fix description of floating point modulus

4db97b3

Update description of scalar * matrix, vector

db8a37d

Fix result type for signed >>>

be0e472

Remove >>>. Right shift depends on operand type

bf66713

Fixes gpuweb#825

dneto0 force-pushed the wgsl-binary-operator-type-rules branch from d53a82f to bf66713 Compare June 2, 2020 19:10

dneto0 mentioned this pull request Jun 2, 2020

Should logical-right-shift have a distinct spelling from arithmetic-right-shift? #825

Closed

kainino0x reviewed Jun 2, 2020

View reviewed changes

dj2 approved these changes Jun 3, 2020

View reviewed changes

dj2 merged commit ef51db4 into gpuweb:master Jun 3, 2020

dj2 mentioned this pull request Jun 9, 2020

>>> should be logical right shift and >> should be arithmetic right shift #790

Closed

ben-clayton pushed a commit to ben-clayton/gpuweb that referenced this pull request Sep 6, 2022

Add no-op function .url() to class TestBuilder (gpuweb#772)

e42f534

Conversation

dneto0 commented May 12, 2020

Uh oh!

dneto0 commented May 12, 2020

Uh oh!

dneto0 commented May 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

grorg commented May 19, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kainino0x Jun 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dneto0 commented May 14, 2020 •

edited

Loading

kainino0x Jun 2, 2020 •

edited

Loading