Sitelet https://github.com/gpuweb/gpuweb/pull/2823
Skip to content

Validate unknown texture usage bits - #2823

Merged
kainino0x merged 3 commits into
gpuweb:mainfrom
kainino0x:split-texture-validation
May 6, 2022
Merged

Validate unknown texture usage bits#2823
kainino0x merged 3 commits into
gpuweb:mainfrom
kainino0x:split-texture-validation

Conversation

@kainino0x

@kainino0x kainino0x commented May 4, 2022 •
edited by pr-preview Bot
Loading

Copy link
Copy Markdown
Contributor

💥 Error: 500 Internal Server Error 💥

PR Preview failed to build. (Last tried on May 6, 2022, 12:59 AM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 CSS Spec Preprocessor - CSS Spec Preprocessor is the web service used to build Bikeshed specs.

🔗 Related URL

<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>500 Internal Server Error</title>
</head><body>
<h1>Internal Server Error</h1>
<p>The server encountered an internal error or
misconfiguration and was unable to complete
your request.</p>
<p>Please contact the server administrator at 
 [no address given] to inform them of the time this error occurred,
 and the actions you performed just before this error.</p>
<p>More information about this error may be available
in the server error log.</p>
<hr>
<address>Apache/2.4.10 (Debian) Server at api.csswg.org Port 443</address>
</body></html>

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

@kainino0x kainino0x added the copyediting Pure editorial stuff (copyediting, *.bs file syntax, etc.) label May 4, 2022
@kainino0x kainino0x added this to the V1.0 milestone May 4, 2022
@kainino0x
kainino0x requested a review from toji May 4, 2022 21:00
@kainino0x kainino0x mentioned this pull request May 4, 2022
Merged
@github-actions

github-actions Bot commented May 4, 2022

Copy link
Copy Markdown
Contributor

Previews, as seen when this build job started (264c1c4):
WebGPU | IDL
WGSL
Explainer

toji
toji approved these changes May 5, 2022
View reviewed changes

@toji toji left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kainino0x
kainino0x enabled auto-merge (squash) May 6, 2022 00:59
@kainino0x
kainino0x merged commit c49de75 into gpuweb:main May 6, 2022
github-actions Bot added a commit that referenced this pull request May 6, 2022
@kainino0x @github-actions
Validate unknown texture usage bits (#2823)
4968274 
SHA: c49de75
Reason: push, by @kainino0x

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions

github-actions Bot commented May 6, 2022

Copy link
Copy Markdown
Contributor

Previews, as seen when this build job started (1db2e1c):
WebGPU | IDL
WGSL
Explainer

github-actions Bot added a commit that referenced this pull request May 6, 2022
@kainino0x @github-actions
Validate unknown texture usage bits (#2823)
615138f 
SHA: c49de75
Reason: push, by @kainino0x

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions Bot added a commit that referenced this pull request May 6, 2022
@kainino0x @github-actions
Validate unknown texture usage bits (#2823)
2478732 
SHA: c49de75
Reason: push, by @kainino0x

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
jdarpinian pushed a commit to jdarpinian/gpuweb that referenced this pull request Aug 12, 2022
@kainino0x @jdarpinian
Validate unknown texture usage bits (gpuweb#2823)
102467c 
* no-op: Move GPUTextureDescriptor validation into an algorithm

* editorial: Restrict bits in GPUTextureDescriptor.usage
@kainino0x
kainino0x deleted the split-texture-validation branch November 17, 2022 01:35
@kainino0x kainino0x added the needs-cts-issue This change requires tests (or would need tests if accepted), but may not have a CTS issue filed yet label Nov 17, 2022
@lokokung

lokokung commented Nov 30, 2022

Copy link
Copy Markdown
Contributor

Removing 'needs-cts-issue' label with update in draft issue with the name: val: createTexture:texture_usage

@lokokung lokokung removed the needs-cts-issue This change requires tests (or would need tests if accepted), but may not have a CTS issue filed yet label Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@toji toji toji approved these changes

Assignees

No one assigned

Labels

copyediting Pure editorial stuff (copyediting, *.bs file syntax, etc.)

Projects

None yet

Milestone

Milestone 0

Development

Successfully merging this pull request may close these issues.

3 participants

@kainino0x @lokokung @toji