Sitelet https://github.com/gpuweb/gpuweb/pull/2821
Skip to content

Validate canvas configuration in configure() - #2821

Merged
kainino0x merged 9 commits into
gpuweb:mainfrom
kainino0x:configure-early-error
May 16, 2022
Merged

Validate canvas configuration in configure()#2821
kainino0x merged 9 commits into
gpuweb:mainfrom
kainino0x:configure-early-error

Conversation

@kainino0x

@kainino0x kainino0x commented May 4, 2022 •
edited by pr-preview Bot
Loading

Copy link
Copy Markdown
Contributor

Dependent on #2823

Moves the validation of the GPUCanvasConfiguration to configure(), instead of doing it implicitly later in getCurrentTexture().

💥 Error: 500 Internal Server Error 💥

PR Preview failed to build. (Last tried on May 16, 2022, 10:29 PM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 CSS Spec Preprocessor - CSS Spec Preprocessor is the web service used to build Bikeshed specs.

🔗 Related URL

<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>500 Internal Server Error</title>
</head><body>
<h1>Internal Server Error</h1>
<p>The server encountered an internal error or
misconfiguration and was unable to complete
your request.</p>
<p>Please contact the server administrator at 
 [no address given] to inform them of the time this error occurred,
 and the actions you performed just before this error.</p>
<p>More information about this error may be available
in the server error log.</p>
<hr>
<address>Apache/2.4.10 (Debian) Server at api.csswg.org Port 443</address>
</body></html>

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

kainino0x
kainino0x commented May 4, 2022
View reviewed changes
Comment thread spec/index.bs Outdated
@kainino0x kainino0x added the tacit resolution candidate Editors may be able to resolve and move to tacit resolution queue label May 4, 2022
@github-actions

This comment was marked as outdated.

Sign in to view
@kainino0x
kainino0x force-pushed the configure-early-error branch from 66ec47d to b6e633f Compare May 4, 2022 20:40
@kainino0x
kainino0x force-pushed the configure-early-error branch from b6e633f to f419a4d Compare May 4, 2022 20:43
@github-actions

This comment was marked as outdated.

Sign in to view
@kainino0x
kainino0x force-pushed the configure-early-error branch from f419a4d to df47e31 Compare May 4, 2022 20:55
@kainino0x kainino0x mentioned this pull request May 4, 2022
Merged
@kainino0x
kainino0x marked this pull request as ready for review May 4, 2022 21:01
@kainino0x
kainino0x requested a review from toji May 4, 2022 21:01
@kainino0x

kainino0x commented May 4, 2022

Copy link
Copy Markdown
Contributor Author

@toji PTAL (ignore the first two commits, those are #2823)

@github-actions

github-actions Bot commented May 4, 2022

Copy link
Copy Markdown
Contributor

Previews, as seen when this build job started (df47e31):
WebGPU | IDL
WGSL
Explainer

toji
toji approved these changes May 5, 2022
View reviewed changes

@toji toji left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There's some minor questions that I have about how this will interact with the canvas size changes we discussed this morning, but I'm happy to leave those to the follow-up change. This feels significantly cleaner than what we previously had in the meantime.

@kainino0x kainino0x added tacit resolution queue Editors have agreed and intend to land if no feedback is given and removed tacit resolution candidate Editors may be able to resolve and move to tacit resolution queue tacit resolution queue Editors have agreed and intend to land if no feedback is given labels May 6, 2022
@kainino0x kainino0x added this to the V1.0 milestone May 6, 2022
@kainino0x kainino0x mentioned this pull request May 6, 2022
Merged
@kainino0x kainino0x removed the tacit resolution queue Editors have agreed and intend to land if no feedback is given label May 16, 2022
@kainino0x
kainino0x enabled auto-merge (squash) May 16, 2022 22:14
@kainino0x
kainino0x disabled auto-merge May 16, 2022 22:20
@kainino0x
kainino0x enabled auto-merge (squash) May 16, 2022 22:20
@kainino0x
kainino0x force-pushed the configure-early-error branch from c2a2d8f to 25fa086 Compare May 16, 2022 22:28
@kainino0x
kainino0x merged commit f1fe2b7 into gpuweb:main May 16, 2022
@kainino0x
kainino0x deleted the configure-early-error branch May 16, 2022 22:34
@github-actions

github-actions Bot commented May 16, 2022

Copy link
Copy Markdown
Contributor

Previews, as seen when this build job started (25fa086):
WebGPU | IDL
WGSL
Explainer

github-actions Bot added a commit that referenced this pull request May 16, 2022
@kainino0x @github-actions
Validate canvas configuration in configure() (#2821)
a0d965f 
SHA: f1fe2b7
Reason: push, by @kainino0x

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions Bot added a commit that referenced this pull request May 16, 2022
@kainino0x @github-actions
Validate canvas configuration in configure() (#2821)
c6b2dbc 
SHA: f1fe2b7
Reason: push, by @kainino0x

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions Bot added a commit that referenced this pull request May 16, 2022
@kainino0x @github-actions
Validate canvas configuration in configure() (#2821)
9a5e172 
SHA: f1fe2b7
Reason: push, by @kainino0x

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@kainino0x kainino0x mentioned this pull request May 18, 2022
Closed
@kainino0x kainino0x added the needs-cts-issue This change requires tests (or would need tests if accepted), but may not have a CTS issue filed yet label Jun 29, 2022
jdarpinian pushed a commit to jdarpinian/gpuweb that referenced this pull request Aug 12, 2022
@kainino0x @jdarpinian
Validate canvas configuration in configure() (gpuweb#2821)
59e4da6 
* no-op: Move GPUTextureDescriptor validation into an algorithm

* editorial: Restrict bits in GPUTextureDescriptor.usage

* Validate canvas configuration in configure()

* handle OffscreenCanvas

* reword redundant validation
@lokokung lokokung removed the needs-cts-issue This change requires tests (or would need tests if accepted), but may not have a CTS issue filed yet label Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@toji toji toji approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Milestone 0

Development

Successfully merging this pull request may close these issues.

3 participants

@kainino0x @toji @lokokung