Sitelet https://github.com/googleapis/google-cloud-java/issues/396
Skip to content

In ServiceApi classes, consider how to expose the underlying gRPC layer for advanced use cases. #396

Description

@garrettjonesgoogle

We may want to expose the channel and 1 or more gRPC stubs for advanced use cases not met by the generated methods in the wrapper.

Activity

  1. aozarov commented on Nov 19, 2015

    @aozarov
    Contributor

    I wonder, if we decide to do that, if returning the ServiceApiSettings wouldn't be preferred.

    As a side not (related to the suggestion), I wonder if in ApiUtils.settingsWithChannels we should not configure the newly created channel (if setting didn't include channel) with settings.getCredentials if it
    is not null?

    Also, if we decide to return the ServiceApiSettings reference that was created by ApiUtils.ServiceApiSettings then I think we need also to populate the other fields (such as Credentials,
    ServicePath and Port).

  2. garrettjonesgoogle commented on Mar 21, 2016

    @garrettjonesgoogle
    ContributorAuthor

    The code has changed a bit since Arie's comment - ApiUtils is now gone, and ServiceApiSettings now handles the population of the default channel itself. I think Arie's concerns are addressed now.

    I'm unsure if we currently have a demonstrated need to expose the gRPC layer through the Api classes - it is already accessible from its own package, which is a dependency.

    @aozarov , what are your thoughts?

  3. garrettjonesgoogle commented on Nov 22, 2016

    @garrettjonesgoogle
    ContributorAuthor

    The Service Api classes now expose the corresponding Settings classes. Resolving this issue.

  4. added a commit that references this issue on Sep 15, 2022
  5. added a commit that references this issue on Dec 22, 2025
  6. added a commit that references this issue on Jan 6, 2026
  7. added a commit that references this issue on Jan 22, 2026
  8. added a commit that references this issue on Mar 11, 2026
  9. added a commit that references this issue on Mar 23, 2026
    da55e2b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

🚨 criticalP0 critical issue. Requires immediate fixapi: pubsubIssues related to the Pub/Sub API.triage meI really want to be triaged.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions