docs: document the processing and chunk configuration types - #33
Open
xperiandri wants to merge 1 commit into
Open
xperiandri wants to merge 1 commit into
xperiandri wants to merge 1 commit into
Conversation
- `AwaitParallel` and `AwaitSequentialParallel` send up to `MaxConcurrent` values to the selector at once and queue the others, instead of sending all values at once. - `ProcessingOptions`: document every field, `Default`, `Parallel`, `MaxConcurrent` and `AwaitOperation`. `ConfigureAwait` configures only R3's await of the selector result, not the awaits inside the selector, and `CancelOnCompleted` also discards the queued elements. - `ChunkConfiguration`: document every case and case field, and point from `ChunkWindowBoundaries` to `chunkByBoundaries`; the helpers read the default time provider when they are called. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 5, 2026
This was referenced Oct 5, 2026
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The MaxConcurrent documentation incorrectly implies unlimited concurrency for non-parallel configurations.
Review effort: Balanced
Findings: 1
What changed in this PR
Documents processing and chunk configuration APIs and updates repository guidance accordingly.
Changes:
- Documents processing options, await modes, and chunk configurations.
- Clarifies helper timing and cancellation behavior.
| File | Description |
|---|---|
src/FSharp.Control.R3/ProcessingOptions.fs |
Adds XML documentation for processing and chunk APIs. |
.github/copilot-instructions.md |
Updates the file’s listed responsibility. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| /// Processes all elements concurrently without a limit, capturing the synchronization context. | ||
| static member Parallel = ``parallel`` | ||
|
|
||
| /// The concurrency limit of the parallel configurations; -1 (no limit) for every other configuration. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Proposed Changes
Part of splitting #22 into small pull requests that can be reviewed one at a time. It is stacked on #32 (
fix/chunk-length-validation), so it shows only its own change; merge #32 first.Documentation only, apart from moving the
ChunkConfigurationcase fields onto their own lines so that each can carry a doc comment:AwaitParallelandAwaitSequentialParallelsend up toMaxConcurrentvalues to the selector at once and queue the others, instead of sending all values at once.ProcessingOptions: every field,Default,Parallel,MaxConcurrentandAwaitOperation.ConfigureAwaitconfigures only R3's await of the selector result, not the awaits inside the selector, andCancelOnCompletedalso discards the queued elements.ChunkConfiguration: every case and case field, with a pointer fromChunkWindowBoundariestochunkByBoundaries; the helpers read the default time provider when they are called.Types of changes
What types of changes does your code introduce to FSharp.Control.R3?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
The documented behaviour is pinned by
ProcessingOptionsTests.fs,MapAsyncTests.fsandChunkTests.fsin #22.Stack – every pull request is based on the one before it, so each shows only its own change. Merge them in this order:
AwaitOperationConfigurationcases withAwait#23 refactor!: prefixAwaitOperationConfigurationcases withAwaitmapAsyncoptions eagerly #24 fix: validate the concurrency limit ofmapAsyncoptions eagerlyyield/zerosynchronously to keep element order #25 fix(rxquery): emityield/zerosynchronously to keep element ordersumBywithUnchecked.defaultof#26 fix(rxquery)!: stop seedingsumBywithUnchecked.defaultofrxqueryWithto cancel the terminal query operators #27 feat(rxquery): addrxqueryWithto cancel the terminal query operatorsofSeqreachable asObservable.ofSeq#29 feat(observable)!: makeofSeqreachable asObservable.ofSeqObservable.choosetake avoptionchooser, addObservableOption#30 feat(observable)!: makeObservable.choosetake avoptionchooser, addObservableOptionchunkByBoundariesfor boundaries of any element type #31 feat(observable): addchunkByBoundariesfor boundaries of any element typecancellationTokenfromtoLookup#35 fix(async)!: remove the ignoredcancellationTokenfromtoLookupiterAsyncthroughForEachAsyncinstead ofCountAsync#37 fix: wait foriterAsyncthroughForEachAsyncinstead ofCountAsynciterAsyncreliably and never lose a failure of its action #38 fix: stopiterAsyncreliably and never lose a failure of its actionofTaskconfigureAwaittotrue#39 fix(task)!: defaultofTaskconfigureAwaittotruetoArrayandtoListinto theTask.Observablemodule #40 feat(task)!: movetoArrayandtoListinto theTask.Observablemodulebind,catchandmapAsync#42 docs: document the R3 1.3.1 limitations ofbind,catchandmapAsync🤖 Generated with Claude Code