feat(observable)!: make ofSeq reachable as Observable.ofSeq - #29
Open
xperiandri wants to merge 1 commit into
Open
xperiandri wants to merge 1 commit into
xperiandri wants to merge 1 commit into
Conversation
`Observable.ofSeq` was undefined (FS0039) after `open FSharp.Control.R3`, because the member lived on a type in an AutoOpen module nested inside the non-AutoOpen `Observable` module. `ofSeq` moves to the new AutoOpen `ObservableFactories` module that sits directly in the namespace, with an overload taking a `CancellationToken`. Name resolution of `Observable.ofSeq` finds no such function in the modules named `Observable` and falls through to the type, the same way `Observable.ofTask` resolves after opening `FSharp.Control.R3.Task`. BREAKING CHANGE: the `Observable.Extensions` type is removed. After `open FSharp.Control.R3` the bare type name `Observable` refers to `FSharp.Control.R3.ObservableFactories.Observable`: write `open type R3.Observable` and extend `R3.Observable` by its full name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 5, 2026
This was referenced Oct 5, 2026
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation achieves the intended name resolution, with only minor documentation corrections remaining.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Makes ofSeq accessible as Observable.ofSeq after opening FSharp.Control.R3.
Changes:
- Adds sequence factory overloads with optional cancellation support.
- Removes the previous nested factory type.
- Documents the resulting breaking API changes.
| File | Description |
|---|---|
ObservableFactories.fs |
Adds the new factory type and overloads. |
Observable.fs |
Removes the previous nested factory. |
FSharp.Control.R3.fsproj |
Includes the new source file. |
CHANGELOG.md |
Records API additions and breaking changes. |
.github/copilot-instructions.md |
Updates the documented project structure. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| ### Changed | ||
|
|
||
| - **Breaking:** `AwaitOperationConfiguration` cases are prefixed with `Await` (`AwaitSequential`, `AwaitParallel 4`, ...) so they no longer collide with `System.Threading.Tasks.Parallel` | ||
| - **Breaking:** the `Observable.Extensions` type is replaced by `Observable.ofSeq` |
| open R3 | ||
|
|
||
| /// <summary> | ||
| /// Factories of observable sequences that are reachable through the type name <c>Observable</c> |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Proposed Changes
Part of splitting #22 into small pull requests that can be reviewed one at a time. It is stacked on #28 (
docs/rxquery), so it shows only its own change; merge #28 first.Observable.ofSeqwas undefined (FS0039) afteropen FSharp.Control.R3, because the member lived on a type in an AutoOpen module nested inside the non-AutoOpenObservablemodule.ofSeqmoves to the new AutoOpenObservableFactoriesmodule that sits directly in the namespace, with an overload taking aCancellationToken. Name resolution ofObservable.ofSeqfinds no such function in the modules namedObservableand falls through to the type, the same wayObservable.ofTaskresolves after openingFSharp.Control.R3.Task. R3's own factories, such asObservable.Range, still resolve through the same name.Types of changes
What types of changes does your code introduce to FSharp.Control.R3?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
Breaking change: the
Observable.Extensionstype is removed. Afteropen FSharp.Control.R3the bare type nameObservablerefers toFSharp.Control.R3.ObservableFactories.Observable: writeopen type R3.Observableand extendR3.Observableby its full name.Tests (in #22): the
ofSeqtests ofObservableTests.fs(synchronous emission, a new enumeration per subscription, cancellation, enumeration exceptions, early unsubscription) and two scenarios ofIntegrationTests.fs.Stack – every pull request is based on the one before it, so each shows only its own change. Merge them in this order:
AwaitOperationConfigurationcases withAwait#23 refactor!: prefixAwaitOperationConfigurationcases withAwaitmapAsyncoptions eagerly #24 fix: validate the concurrency limit ofmapAsyncoptions eagerlyyield/zerosynchronously to keep element order #25 fix(rxquery): emityield/zerosynchronously to keep element ordersumBywithUnchecked.defaultof#26 fix(rxquery)!: stop seedingsumBywithUnchecked.defaultofrxqueryWithto cancel the terminal query operators #27 feat(rxquery): addrxqueryWithto cancel the terminal query operatorsofSeqreachable asObservable.ofSeq#29 feat(observable)!: makeofSeqreachable asObservable.ofSeq← this pull requestObservable.choosetake avoptionchooser, addObservableOption#30 feat(observable)!: makeObservable.choosetake avoptionchooser, addObservableOptionchunkByBoundariesfor boundaries of any element type #31 feat(observable): addchunkByBoundariesfor boundaries of any element typecancellationTokenfromtoLookup#35 fix(async)!: remove the ignoredcancellationTokenfromtoLookupiterAsyncthroughForEachAsyncinstead ofCountAsync#37 fix: wait foriterAsyncthroughForEachAsyncinstead ofCountAsynciterAsyncreliably and never lose a failure of its action #38 fix: stopiterAsyncreliably and never lose a failure of its actionofTaskconfigureAwaittotrue#39 fix(task)!: defaultofTaskconfigureAwaittotruetoArrayandtoListinto theTask.Observablemodule #40 feat(task)!: movetoArrayandtoListinto theTask.Observablemodulebind,catchandmapAsync#42 docs: document the R3 1.3.1 limitations ofbind,catchandmapAsync🤖 Generated with Claude Code