Repository navigation
[material_ui] Don't clip MenuItemButton.leadingIcon - #12986
Merged
auto-submit[bot] merged 3 commits intoSep 25, 2026
Merged
auto-submit[bot] merged 3 commits into
auto-submit[bot] merged 3 commits into
Conversation
QuncCccccc
force-pushed
the
menu-item-button-leading-icon-clip
branch
2 times, most recently
from
September 23, 2026 01:52
b0f4ad6 to
6707fc5
Compare
`_MenuItemLabel` wrapped the leading `Row` in a hard-coded `ClipRect` when `overflowAxis` is vertical, which clipped `leadingIcon` to its own bounds. This hid any decoration painting outside those bounds, such as a `Badge`, and shaved the antialiased edge off ordinary icons. `trailingIcon`, `shortcut`, and `submenuIcon` are not wrapped, so the leading slot was the odd one out. The inner `ClipRect` around the label, which is what actually bounds long text, is unchanged.
QuncCccccc
force-pushed
the
menu-item-button-leading-icon-clip
branch
from
September 23, 2026 01:54
6707fc5 to
d6bce8d
Compare
QuncCccccc
marked this pull request as ready for review
September 23, 2026 16:51
elliette
approved these changes
Sep 24, 2026
navaronbracke
approved these changes
Sep 25, 2026
elliette
reviewed
Sep 25, 2026
| ); | ||
|
|
||
| // The label itself is still clipped so that long labels truncate. | ||
| expect(find.ancestor(of: find.text('Item'), matching: find.byType(ClipRect)), findsOneWidget); |
Member
There was a problem hiding this comment.
[optional] Could we test with a long string to make sure it is clipped?
github-merge-queue Bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 28, 2026
flutter/packages@e55e7ac...ba0364a 2026-09-26 stuartmorgan@google.com [google_maps_flutter] Indicate that default iOS impl is discoraged (flutter/packages#12872) 2026-09-26 36861262+QuncCccccc@users.noreply.github.com [material_ui] Add Material 3 Expressive IconButton (flutter/packages#12832) 2026-09-25 jessiewong401@gmail.com Plugin example apps to 9.3.1 (flutter/packages#13019) 2026-09-25 36861262+QuncCccccc@users.noreply.github.com [material_ui] Don't clip MenuItemButton.leadingIcon (flutter/packages#12986) 2026-09-25 36861262+QuncCccccc@users.noreply.github.com [material_ui] Migrate M3 ExpansionTile template to use new gen_defaults (flutter/packages#12920) 2026-09-25 149176071+m1roxx@users.noreply.github.com [two_dimensional_scrollables] Exclude trailing pinned spans from the non-pinned range (flutter/packages#12666) 2026-09-25 36861262+QuncCccccc@users.noreply.github.com [material_ui] Migrate M3 Drawer template to use new gen_defaults (flutter/packages#12916) 2026-09-25 36861262+QuncCccccc@users.noreply.github.com [material_ui] Migrate M3 Divider template to use new gen_defaults (flutter/packages#12915) 2026-09-25 instantni.med@gmail.com [google_maps_flutter_web] Fix AdvancedMarker anchors on web (flutter/packages#11966) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_MenuItemLabelwrapped the leadingRowin a hard-codedClipRectwhenoverflowAxisis vertical, which clippedleadingIconto its own bounds. This clips any decoration painting outside those bounds, such as aBadge.This PR is to remove the
ClipRectso leading icons won't be incorrectly clipped.Fixes flutter/flutter#192732
Before
After
Pre-Review Checklist
[shared_preferences]///).