Sitelet https://github.com/flutter/packages/pull/12872
Skip to content

[google_maps_flutter] Indicate that default iOS impl is discoraged - #12872

Merged
auto-submit[bot] merged 3 commits into
flutter:mainfrom
stuartmorgan-g:maps-ios-discourage-default
Sep 26, 2026
Merged

auto-submit[bot] merged 3 commits into
flutter:mainfrom
stuartmorgan-g:maps-ios-discourage-default

Conversation

@stuartmorgan-g

Copy link
Copy Markdown
Collaborator

Updates the app-facing package's README to tell clients to pick either the SDK 9 or SDK 10 package, explicitly discouraging using the default implementation.

As discussed in flutter/flutter#119108 this is an interim step until either:

  • Flutter drops support for iOS 15, or
  • we decide that it's okay to potentially cause minor regressions for clients with apps that require iOS 16+ by making the endorsed implementation the _sdk9 variant, rather than the legacy version that will auto-select SDK 10 for those users.

Follow-up to flutter/flutter#119108

Pre-Review Checklist

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2

Updates the app-facing package's README to tell clients to pick either
the SDK 9 or SDK 10 package, explicitly discouraging using the default
implementation.

As discussed in flutter/flutter#119108 this is
an interim step until either:
- Flutter drops support for iOS 15, or
- we decide that it's okay to potentially cause minor regressions for
  clients with apps that require iOS 16+ by making the endorsed
  implementation the `_sdk9` variant, rather than the legacy version
  that will auto-select SDK 10 for those users.

Follow-up to flutter/flutter#119108
@stuartmorgan-g

Copy link
Copy Markdown
Collaborator Author

FWIW I still think we should just make the endorsed implementation _sdk9 and not worry about the potential minor regressions that clients can easily resolve just by selecting _sdk10 (we just got yet another report from someone confused by the warning from flutter about google_maps_flutter_ios not supporting SwiftPM). But since we haven't done that yet, we should at least do this for now.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the package version to 2.18.1, increases the minimum supported SDK versions to Flutter 3.47 and Dart 3.13, and updates the README to indicate that the default iOS implementation is legacy while raising the minimum iOS support to iOS 15. The review feedback correctly identifies that the default iOS implementation package is referred to as google_maps_ios instead of google_maps_flutter_ios in both the README and CHANGELOG.

Comment thread packages/google_maps_flutter/google_maps_flutter/CHANGELOG.md Outdated
Comment thread packages/google_maps_flutter/google_maps_flutter/README.md Outdated
@stuartmorgan-g

Copy link
Copy Markdown
Collaborator Author

This is blocked on flutter/flutter#193032

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 26, 2026
@auto-submit
auto-submit Bot merged commit ba0364a into flutter:main Sep 26, 2026
13 checks passed
github-merge-queue Bot pushed a commit to flutter/flutter that referenced this pull request Sep 28, 2026
flutter/packages@e55e7ac...ba0364a

2026-09-26 stuartmorgan@google.com [google_maps_flutter] Indicate that
default iOS impl is discoraged (flutter/packages#12872)
2026-09-26 36861262+QuncCccccc@users.noreply.github.com [material_ui]
Add Material 3 Expressive IconButton (flutter/packages#12832)
2026-09-25 jessiewong401@gmail.com Plugin example apps to 9.3.1
(flutter/packages#13019)
2026-09-25 36861262+QuncCccccc@users.noreply.github.com [material_ui]
Don't clip MenuItemButton.leadingIcon (flutter/packages#12986)
2026-09-25 36861262+QuncCccccc@users.noreply.github.com [material_ui]
Migrate M3 ExpansionTile template to use new gen_defaults
(flutter/packages#12920)
2026-09-25 149176071+m1roxx@users.noreply.github.com
[two_dimensional_scrollables] Exclude trailing pinned spans from the
non-pinned range (flutter/packages#12666)
2026-09-25 36861262+QuncCccccc@users.noreply.github.com [material_ui]
Migrate M3 Drawer template to use new gen_defaults
(flutter/packages#12916)
2026-09-25 36861262+QuncCccccc@users.noreply.github.com [material_ui]
Migrate M3 Divider template to use new gen_defaults
(flutter/packages#12915)
2026-09-25 instantni.med@gmail.com [google_maps_flutter_web] Fix
AdvancedMarker anchors on web (flutter/packages#11966)

If this roll has caused a breakage, revert this CL and set the roller
to dry run mode using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD p: google_maps_flutter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants