Repository navigation
[camera_android_camerax] Bump cameraxVersion to 1.6.2, remove concurrent-futures workaround - #12698
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request updates the cameraxVersion from 1.6.1 to 1.6.2 in build.gradle.kts and removes the explicit androidx.concurrent:concurrent-futures dependency workaround along with its associated regression test, ConcurrentFuturesDependencyTest.java. The package version is bumped to 0.7.4+8 in pubspec.yaml and documented in CHANGELOG.md. There are no review comments, and I have no feedback to provide.
camera-core 1.6.2 includes an upstream fix removing the JSpecify type-use annotation that required consumers to explicitly declare androidx.concurrent:concurrent-futures on their compile classpath (https://issuetracker.google.com/issues/543937345). With 1.6.2, that workaround (added previously) is no longer needed, so this removes the explicit dependency and its regression test.
c77b740 to
da512c3
Compare
camsim99
left a comment
There was a problem hiding this comment.
LGTM! and thank you so much for actually verify the fix is in 1.6.2!
Updated CameraX dependencies to version 1.6.2 and removed workaround for concurrent futures.
gmackall
left a comment
There was a problem hiding this comment.
lgtm but we should remove the integration test note from the changelog as it is intended to be user facing documentation (and so not contain test details)
Co-authored-by: Gray Mackall <34871572+gmackall@users.noreply.github.com>
|
Thanks for your work on both the workaround and the upstream fix inclusion! |
…ent-futures workaround (flutter#12698) Bumps `cameraxVersion` from 1.6.1 to 1.6.2. This release includes an upstream fix (https://issuetracker.google.com/issues/543937345) removing the JSpecify type-use annotation that required consumers to explicitly declare `androidx.concurrent:concurrent-futures` on their compile classpath. With 1.6.2, that workaround (added in flutter#12373) is no longer needed, so this PR removes the explicit dependency and its regression test. Verified the fix is actually present in the published 1.6.2 artifact by decompiling `SurfaceRequest.class` from `camera-core-1.6.2.aar` — the `mSurfaceRecreationCompleter` field no longer carries the JSpecify `@NonNull` type annotation that caused the original compile failure. Fixes flutter/flutter#190505 ## Pre-Review Checklist
|
Heads up: the release workflow run for this merge commit got cancelled — https://github.com/flutter/packages/actions/runs/34403230241/job/102639930809 It hit the 6-hour timeout while waiting on a handful of checks that appear to have gotten stuck in "queued" and never actually started:
Every other commit's release run right before and after this one succeeded normally, so this looks like an isolated infra hiccup rather than a persistent tree issue. Since release runs are scoped to their own triggering commit, |
|
…er#192550) flutter/packages@36e088a...8a35b16 2026-09-10 36861262+QuncCccccc@users.noreply.github.com [material_ui] Migrate M3 buttons template to use new gen_defaults (flutter/packages#12744) 2026-09-09 victorsanniay@gmail.com [cupertino_ui]Add awaitNotRequired to Future-returning callsites without await (flutter/packages#12817) 2026-09-09 victorsanniay@gmail.com [material_ui] Add awaitNotRequired annotation to material_ui (flutter/packages#12622) 2026-09-09 victor.orozco@cloudsufi.com [image_picker] Add native tests for photo-library access and UIImagePicker completion (flutter/packages#12540) 2026-09-09 hashemp206@yahoo.com [material_ui][cupertino_ui] allow page routes to opt out of route semantics - flutter#182556 (flutter/packages#12674) 2026-09-09 victor.orozco@cloudsufi.com [image_picker] Add native tests for pick results, camera access, and presentation (flutter/packages#12539) 2026-09-09 laishereu@gmail.com [cupertino_ui] Fix platform view sheet transitions (flutter/packages#12565) 2026-09-09 150371713+dhc-tech@users.noreply.github.com [camera_android_camerax] Bump cameraxVersion to 1.6.2, remove concurrent-futures workaround (flutter/packages#12698) 2026-09-09 116356835+AbdeMohlbi@users.noreply.github.com `[material_ui]` replace identical checks with equality when dealing with enums (flutter/packages#12633) 2026-09-09 engine-flutter-autoroll@skia.org Roll Flutter from b444e78 to 63b9518 (21 revisions) (flutter/packages#12814) 2026-09-09 116356835+AbdeMohlbi@users.noreply.github.com `[cupertino_ui]` replace identical checks with equality when dealing with enums (flutter/packages#12632) 2026-09-09 tarrinneal@gmail.com [pigeon] add support for multiple swift outputs (flutter/packages#12720) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bumps
cameraxVersionfrom 1.6.1 to 1.6.2. This release includes an upstreamfix (https://issuetracker.google.com/issues/543937345) removing the JSpecify
type-use annotation that required consumers to explicitly declare
androidx.concurrent:concurrent-futureson their compile classpath. With1.6.2, that workaround (added in #12373) is no longer needed, so this PR
removes the explicit dependency and its regression test.
Verified the fix is actually present in the published 1.6.2 artifact by
decompiling
SurfaceRequest.classfromcamera-core-1.6.2.aar— themSurfaceRecreationCompleterfield no longer carries the JSpecify@NonNulltype annotation that caused the original compile failure.Fixes flutter/flutter#190505
Pre-Review Checklist
0.7.4+8).///). N/A — no public API surface changed, only a build-file dependency version bump.ConcurrentFuturesDependencyTest) existed solely to guard the now-unnecessary workaround dependency from [camera_android_camerax] Add explicit concurrent-futures dependency #12373, so deleting it alongside the dependency is correct rather than requiring a replacement test.