`[material_ui]` replace identical checks with equality when dealing with enums by AbdeMohlbi · Pull Request #12633 · flutter/packages

AbdeMohlbi · 2026-08-26T09:39:00Z

related PRs:

Fix enum instances comparison to use equality == since dart has the correct behavior now flutter#191537
Update more enum instances comparison to use equality == since dart has the correct behavior now flutter#191788
[cupertino_ui] replace identical checks with equality when dealing with enums #12632
see
Generalize constant equality to use primitive equality dart-lang/language#1811
Allow == on Enum values in const expressions. dart-lang/language#312
more info :
Analyzer incorrectly reports "In constant expressions, operands of this operator must be of type 'bool', 'num', 'String' or 'null'" for == operator with enum operand dart-lang/sdk#26980
const_eval_throws_exception error dart-lang/sdk#36511
CFE produces the following error in flutter code when constant_update_2018 flag is turned on dart-lang/sdk#36564
VM fails to report an error when equality comparing enums in a const context dart-lang/sdk#36528

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩²

…ith enums

AbdeMohlbi · 2026-08-26T09:39:57Z

i think this is a refactoring with no semantic change so it should be covered by existing tests

gemini-code-assist

Code Review

This pull request replaces identity checks with equality operators for textInputAction and keyboardType in TextField's assertions, and adds a corresponding changelog entry. There are no review comments, and I have no feedback to provide.

elliette · 2026-09-01T21:33:18Z

Thanks for the contribution! You haven’t checked off any of the items in the PR checklist above, so I’m assuming this is a work in progress and am marking it as a Draft. Please review the checklist, updating the PR as appropriate, and when that’s complete please feel free to mark the PR as ready for review.

AbdeMohlbi · 2026-09-01T21:36:20Z

Thanks for the contribution! You haven’t checked off any of the items in the PR checklist above, so I’m assuming this is a work in progress and am marking it as a Draft. Please review the checklist, updating the PR as appropriate, and when that’s complete please feel free to mark the PR as ready for review.

My bad i did update the description

gemini-code-assist

Code Review

This pull request replaces identical checks with standard equality operators (!=) when comparing textInputAction and keyboardType in TextField's assertions. It also adds a corresponding changelog entry for this patch. There are no review comments, and I have no feedback to provide.

QuncCccccc · 2026-09-08T21:39:30Z

Hello, I'm still seeing missing checkboxes. Could you double check whether all items have been checked:)? Before that, I'll convert this to a draft. Thanks a lot for your contribution!

gemini-code-assist

Code Review

This pull request updates the assertion in the TextField constructor to use standard inequality operators (!=) instead of !identical() when comparing textInputAction and keyboardType. I have no feedback to provide.

…with enums (#12632) previous PRs: - flutter/flutter#191537 - flutter/flutter#191788 - #12633 see - dart-lang/language#1811 - dart-lang/language#312 more info : - dart-lang/sdk#26980 - dart-lang/sdk#36511 - dart-lang/sdk#36564 - dart-lang/sdk#36528 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

…with enums (flutter#12632) previous PRs: - flutter/flutter#191537 - flutter/flutter#191788 - flutter#12633 see - dart-lang/language#1811 - dart-lang/language#312 more info : - dart-lang/sdk#26980 - dart-lang/sdk#36511 - dart-lang/sdk#36564 - dart-lang/sdk#36528 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

dkwingsmt

LGTM

…with enums (flutter#12632) previous PRs: - flutter/flutter#191537 - flutter/flutter#191788 - flutter#12633 see - dart-lang/language#1811 - dart-lang/language#312 more info : - dart-lang/sdk#26980 - dart-lang/sdk#36511 - dart-lang/sdk#36564 - dart-lang/sdk#36528 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

…ith enums (flutter#12633) related PRs: - flutter/flutter#191537 - flutter/flutter#191788 - flutter#12632 see - dart-lang/language#1811 - dart-lang/language#312 more info : - dart-lang/sdk#26980 - dart-lang/sdk#36511 - dart-lang/sdk#36564 - dart-lang/sdk#36528 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

…as the correct behavior now (flutter#191788) Related PRs: - flutter#191537 - flutter/packages#12633 - flutter/packages#12632 see - dart-lang/language#1811 - dart-lang/language#312 more info : - dart-lang/sdk#26980 - dart-lang/sdk#36511 - dart-lang/sdk#36564 - dart-lang/sdk#36528 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…er#192550) flutter/packages@36e088a...8a35b16 2026-09-10 36861262+QuncCccccc@users.noreply.github.com [material_ui] Migrate M3 buttons template to use new gen_defaults (flutter/packages#12744) 2026-09-09 victorsanniay@gmail.com [cupertino_ui]Add awaitNotRequired to Future-returning callsites without await (flutter/packages#12817) 2026-09-09 victorsanniay@gmail.com [material_ui] Add awaitNotRequired annotation to material_ui (flutter/packages#12622) 2026-09-09 victor.orozco@cloudsufi.com [image_picker] Add native tests for photo-library access and UIImagePicker completion (flutter/packages#12540) 2026-09-09 hashemp206@yahoo.com [material_ui][cupertino_ui] allow page routes to opt out of route semantics - flutter#182556 (flutter/packages#12674) 2026-09-09 victor.orozco@cloudsufi.com [image_picker] Add native tests for pick results, camera access, and presentation (flutter/packages#12539) 2026-09-09 laishereu@gmail.com [cupertino_ui] Fix platform view sheet transitions (flutter/packages#12565) 2026-09-09 150371713+dhc-tech@users.noreply.github.com [camera_android_camerax] Bump cameraxVersion to 1.6.2, remove concurrent-futures workaround (flutter/packages#12698) 2026-09-09 116356835+AbdeMohlbi@users.noreply.github.com `[material_ui]` replace identical checks with equality when dealing with enums (flutter/packages#12633) 2026-09-09 engine-flutter-autoroll@skia.org Roll Flutter from b444e78 to 63b9518 (21 revisions) (flutter/packages#12814) 2026-09-09 116356835+AbdeMohlbi@users.noreply.github.com `[cupertino_ui]` replace identical checks with equality when dealing with enums (flutter/packages#12632) 2026-09-09 tarrinneal@gmail.com [pigeon] add support for multiple swift outputs (flutter/packages#12720) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

[material_ui] replace identical checks with equality when dealing w…

9460643

…ith enums

github-actions Bot added p: material_ui triage-design Should be looked at in design triage labels Aug 26, 2026

AbdeMohlbi mentioned this pull request Aug 26, 2026

[cupertino_ui] replace identical checks with equality when dealing with enums #12632

Merged

8 of 11 tasks

AbdeMohlbi added the CICD Run CI/CD label Aug 26, 2026

AbdeMohlbi mentioned this pull request Aug 26, 2026

Update more enum instances comparison to use equality == since dart has the correct behavior now flutter/flutter#191788

Merged

7 of 10 tasks

AbdeMohlbi added the override: no changelog needed Override the check requiring CHANGELOG updates for most changes label Aug 26, 2026

Merge branch 'main' into issue_1811_part_3

f402f31

AbdeMohlbi added the override: no versioning needed Override the check requiring version bumps for most changes label Aug 27, 2026

AbdeMohlbi and others added 2 commits August 27, 2026 08:47

Merge branch 'main' into issue_1811_part_3

1b8fcc6

update changelog

c6c7ca7

AbdeMohlbi removed override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Aug 29, 2026

AbdeMohlbi and others added 3 commits August 29, 2026 20:28

Merge branch 'main' into issue_1811_part_3

004c984

empty commit to trigger CI

a9f295c

revert empty commit

8ddfd97

AbdeMohlbi marked this pull request as ready for review August 29, 2026 21:12

gemini-code-assist Bot reviewed Aug 29, 2026

View reviewed changes

elliette marked this pull request as draft September 1, 2026 21:33

AbdeMohlbi marked this pull request as ready for review September 1, 2026 21:40

gemini-code-assist Bot reviewed Sep 1, 2026

View reviewed changes

QuncCccccc marked this pull request as draft September 8, 2026 21:39

AbdeMohlbi added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Sep 9, 2026

AbdeMohlbi and others added 2 commits September 9, 2026 08:37

remove new changelog entry

c2bcb04

Merge branch 'main' into issue_1811_part_3

f8bebf3

AbdeMohlbi marked this pull request as ready for review September 9, 2026 08:51

AbdeMohlbi requested a review from dkwingsmt September 9, 2026 08:51

gemini-code-assist Bot reviewed Sep 9, 2026

View reviewed changes

dkwingsmt approved these changes Sep 9, 2026

View reviewed changes

dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 9, 2026

auto-submit Bot merged commit 7723eaa into flutter:main Sep 9, 2026
13 checks passed

This was referenced Sep 10, 2026

Roll Packages from 36e088a75b9b to 8a35b1611d67 (12 revisions) flutter/flutter#192542

Closed

Roll Packages from 36e088a75b9b to 8a35b1611d67 (12 revisions) flutter/flutter#192550

Merged

Navigation Menu

Repository navigation

`[material_ui]` replace identical checks with equality when dealing with enums - #12633

`[material_ui]` replace identical checks with equality when dealing with enums#12633
auto-submit[bot] merged 9 commits into
flutter:mainfrom
AbdeMohlbi:issue_1811_part_3

AbdeMohlbi commented Aug 26, 2026 •

edited

Loading

Uh oh!

AbdeMohlbi commented Aug 26, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

elliette commented Sep 1, 2026

Uh oh!

AbdeMohlbi commented Sep 1, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

QuncCccccc commented Sep 8, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

dkwingsmt left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

AbdeMohlbi commented Aug 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Footnotes

Uh oh!

AbdeMohlbi commented Aug 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

elliette commented Sep 1, 2026

Uh oh!

AbdeMohlbi commented Sep 1, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

QuncCccccc commented Sep 8, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

dkwingsmt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

AbdeMohlbi commented Aug 26, 2026 •

edited

Loading

AbdeMohlbi commented Aug 26, 2026 •

edited

Loading