[material_ui] Set-up `tool/gen_defaults` sub-directory by elliette · Pull Request #12469 · flutter/packages

elliette · 2026-08-13T20:56:12Z

Work towards flutter/flutter#186906, flutter/flutter#191088

Ports over #11762 which landed on the m3e_migration feature branch.

Since CI was not set up to run on that branch, I've pushed up a few more changes after the ported commits to get all the repo checks/tests to pass.

Original PR description

Adds the initial gen_defaults sub-directory with the initial TokenTemplate and generator. This is simply the initial scaffold, we will need to add additional helper functions as necessary as we begin adding the actual templates.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩²

gemini-code-assist

Code Review

This pull request introduces a new gen_defaults tool under packages/material_ui/tool/gen_defaults to generate Material component theme data defaults from token data. It includes the generator script, base template classes, configuration files, and tests. Feedback suggests improving the robustness of the path resolution in materialLib by resolving paths relative to Platform.script instead of relying on the current working directory.

QuncCccccc

LGTM! Thank you!

elliette · 2026-08-17T20:29:35Z

@stuartmorgan-g do you mind checking if this directory structure looks good to you? Thanks!

Work towards flutter/flutter#186906 Adds the initial `gen_defaults` sub-directory with the initial `TokenTemplate` and generator. This is simply the initial scaffold, we will need to add additional helper functions as necessary as we begin adding the actual templates. - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] page, which explains my responsibilities. - [x] I read and followed the [relevant style guides] and ran [the auto-formatter]. - [x] I signed the [CLA]. - [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. `[shared_preferences]` - [x] I [linked to at least one issue that this PR fixes] in the description above. - [x] I followed [the version and CHANGELOG instructions], using [semantic versioning] and the [repository CHANGELOG style], or I have commented below to indicate which documented exception this PR falls under[^1]. - [x] I updated/added any relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1]. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.  [Contributor Guide]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md [relevant style guides]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md#style [the auto-formatter]: https://github.com/flutter/packages/blob/main/script/tool/README.md#format-code [CLA]: https://cla.developers.google.com/ [Discord]: https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md [linked to at least one issue that this PR fixes]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview [the version and CHANGELOG instructions]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#version-and-changelog-updates [semantic versioning]: https://dart.dev/tools/pub/versioning#semantic-versions [repository CHANGELOG style]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style [test exemption]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests

elliette · 2026-08-19T17:32:34Z

Added versioning exemption since these files are all in the /tool subdirectory that will be excluded from publishing. I'm not sure if this change even should have a changelog entry or if I should remove it as well.

This reverts commit 83626cb.

This reverts commit 742fb96.

This reverts commit 1ef5602.

stuartmorgan-g · 2026-08-24T13:23:36Z

Added versioning exemption since these files are all in the /tool subdirectory that will be excluded from publishing. I'm not sure if this change even should have a changelog entry or if I should remove it as well.

It shouldn't have a changelog entry, since tool/ is only for package developers. Our tooling already knowns not to flag it, so what I'm pretty sure is happening is that the .pubignore file is triggering this. We should add that to the dev-only file list in the tooling as well, and then this won't need a changelog entry or any override labels.

stuartmorgan-g

Having everything encapsulated in the tool/ directory LGTM! (I didn't review the Dart code itself.)

stuartmorgan-g · 2026-08-24T13:27:18Z

@@ -0,0 +1,2 @@
+# The tool/ directory is for package developer use only and should not be published.
+tool/


According to the docs, having .pubignore will cause .gitignore to be ignored, so I believe you'll need to duplicate the .gitignore contents into this file to avoid issues the next time the package is published.

Ah, I did not know that! I moved the .pubignore under material_ui/tool/ instead, that way we don't have to keep the contents of it and material_ui's .gitignore file in-sync. I did a test run with dart pub publish --dry-run to confirm that the tool directory is excluded.

Work towards flutter/flutter#186906, flutter/flutter#191088 **Ports over flutter#11762 which landed on the `m3e_migration` feature branch.** Since CI was not set up to run on that branch, I've pushed up a few more changes after the ported commits to get all the repo checks/tests to pass. ### Original PR description Adds the initial gen_defaults sub-directory with the initial TokenTemplate and generator. This is simply the initial scaffold, we will need to add additional helper functions as necessary as we begin adding the actual templates. ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

…r#191886) flutter/packages@740f093...bd3cbc1 2026-08-26 engine-flutter-autoroll@skia.org Roll Flutter from 9a82789 to 15d8908 (37 revisions) (flutter/packages#12619) 2026-08-26 stuartmorgan@google.com [google_maps_flutter] Convert simple object controllers to Swift (flutter/packages#12618) 2026-08-26 21270878+elliette@users.noreply.github.com [material_ui] `gen_defaults` should follow new versioning strategy (flutter/packages#12627) 2026-08-25 10687576+bparrishMines@users.noreply.github.com [material_ui] Fixes analysis_options migration from calling `flutter pub get` on pacakage (flutter/packages#12626) 2026-08-25 jason-simmons@users.noreply.github.com [material_ui] Declare Flutter SDK dependencies in the pubspec.yaml for tool/gen_defaults (flutter/packages#12623) 2026-08-25 21270878+elliette@users.noreply.github.com [material_ui] Set-up `tool/gen_defaults` sub-directory (flutter/packages#12469) 2026-08-25 stuartmorgan@google.com [google_maps_flutter] Convert top-level classes to Swift in `_sdk*` packages (flutter/packages#12307) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Work towards flutter/flutter#186906, flutter/flutter#191088 **Ports over flutter#11762 which landed on the `m3e_migration` feature branch.** Since CI was not set up to run on that branch, I've pushed up a few more changes after the ported commits to get all the repo checks/tests to pass. ### Original PR description Adds the initial gen_defaults sub-directory with the initial TokenTemplate and generator. This is simply the initial scaffold, we will need to add additional helper functions as necessary as we begin adding the actual templates. ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

github-actions Bot added triage-framework Should be looked at in framework triage p: material_ui labels Aug 13, 2026

elliette added the CICD Run CI/CD label Aug 13, 2026

elliette marked this pull request as ready for review August 13, 2026 22:06

elliette requested a review from QuncCccccc August 13, 2026 22:06

gemini-code-assist Bot reviewed Aug 13, 2026

View reviewed changes

Comment thread packages/material_ui/tool/gen_defaults/templates/template.dart

elliette mentioned this pull request Aug 13, 2026

[material_ui] Port PRs from m3e_migration feature branch to main branch flutter/flutter#191088

Closed

QuncCccccc approved these changes Aug 13, 2026

View reviewed changes

elliette force-pushed the migrate-pr-11762 branch from 3eac18f to ebedb7f Compare August 14, 2026 22:01

Piinks added triage-design Should be looked at in design triage and removed triage-framework Should be looked at in framework triage labels Aug 17, 2026

github-actions Bot added the triage-framework Should be looked at in framework triage label Aug 17, 2026

elliette requested a review from stuartmorgan-g August 17, 2026 20:29

Piinks removed the triage-framework Should be looked at in framework triage label Aug 17, 2026

elliette added 7 commits August 19, 2026 09:26

Add CHANGELOG entry

a1dc2c8

Remove workspace resolution

e3fa26e

Bump SDK

776cfba

Fix dashboard checks

10b8d80

Add .pubignore

67eab75

New line end of file

467afa4

elliette force-pushed the migrate-pr-11762 branch from eba20f2 to 467afa4 Compare August 19, 2026 16:26

github-actions Bot added the triage-framework Should be looked at in framework triage label Aug 19, 2026

elliette added the override: no versioning needed Override the check requiring version bumps for most changes label Aug 19, 2026

Exclude web unit testing on gen_defaults

1ef5602

github-actions Bot removed the triage-framework Should be looked at in framework triage label Aug 20, 2026

elliette added 2 commits August 20, 2026 09:00

Fix formatting

742fb96

Change path to fix package exclusion from tests

83626cb

elliette added 4 commits August 20, 2026 13:30

Revert "Change path to fix package exclusion from tests"

db04a2b

This reverts commit 83626cb.

Revert "Fix formatting"

dc16e01

This reverts commit 742fb96.

Revert "Exclude web unit testing on gen_defaults"

fe7e22c

This reverts commit 1ef5602.

Use dart_test.yaml file to prevent web testing instead

f082ed1

stuartmorgan-g reviewed Aug 24, 2026

View reviewed changes

elliette added 3 commits August 24, 2026 11:17

Try moving pubignore to subdirectory

9c99307

Remove new line EOF

0fb7c16

Remove quotes around vm in dart_test file

f48bc9d

elliette requested a review from stuartmorgan-g August 24, 2026 19:51

elliette added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 25, 2026

auto-submit Bot merged commit 3213414 into flutter:main Aug 25, 2026
13 checks passed

bparrishMines mentioned this pull request Aug 25, 2026

Revert "[material_ui] Set-up tool/gen_defaults sub-directory" #12625

Closed

elliette mentioned this pull request Aug 26, 2026

[material_ui] gen_defaults should follow new versioning strategy #12627

Merged

11 tasks done

engine-flutter-autoroll mentioned this pull request Aug 27, 2026

Roll Packages from 740f09361ccc to bd3cbc1b8c3f (7 revisions) flutter/flutter#191886

Merged

elliette mentioned this pull request Sep 2, 2026

[material_ui] Copies a11y_assessments #12686

Merged

11 tasks

Navigation Menu

Repository navigation

[material_ui] Set-up `tool/gen_defaults` sub-directory - #12469

[material_ui] Set-up `tool/gen_defaults` sub-directory#12469
auto-submit[bot] merged 17 commits into
flutter:mainfrom
elliette:migrate-pr-11762

elliette commented Aug 13, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

QuncCccccc left a comment

Uh oh!

elliette commented Aug 17, 2026

Uh oh!

elliette commented Aug 19, 2026

Uh oh!

stuartmorgan-g commented Aug 24, 2026

Uh oh!

stuartmorgan-g left a comment

Uh oh!

stuartmorgan-g Aug 24, 2026

Uh oh!

elliette Aug 24, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		@@ -0,0 +1,2 @@
		# The tool/ directory is for package developer use only and should not be published.
		tool/

Conversation

elliette commented Aug 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Original PR description

Pre-Review Checklist

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

elliette commented Aug 17, 2026

Uh oh!

elliette commented Aug 19, 2026

Uh oh!

stuartmorgan-g commented Aug 24, 2026

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Aug 24, 2026

Choose a reason for hiding this comment

Uh oh!

elliette Aug 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

elliette commented Aug 13, 2026 •

edited

Loading

elliette Aug 24, 2026 •

edited

Loading