[material_ui] Copies a11y_assessments by chunhtai · Pull Request #12686 · flutter/packages

chunhtai · 2026-08-28T23:03:41Z

as title.

Move the app in material gives us benefit that we can both fix accessibility issue and verify the fix on the app faster without waiting for a release cycle

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩²

gemini-code-assist

Code Review

This pull request introduces a new Flutter project, a11y_assessments, designed for accessibility testing across multiple platforms including Android, iOS, Linux, macOS, Web, and Windows. It implements a wide range of widget use cases to assess accessibility compliance, along with corresponding tests. Feedback on the changes highlights a potential compilation issue in utils.cpp due to the use of a non-standard macro UNICODE_STRING_MAX_CHARS, and identifies several unused variables in action_chip.dart, card.dart, and navigation_drawer.dart that should be removed.

chunhtai · 2026-08-31T21:44:14Z

reason for override: this is a sample app that won't be include in the release.

QuncCccccc

LGTM. Just have a question, I saw the original app in flutter/flutter also have a GEMINI.md file, is it for agent learning? Just curious whether we also want that in material_ui.

chunhtai · 2026-08-31T22:58:59Z

I saw the original app in flutter/flutter also have a GEMINI.md file, is it for agent learning? Just curious whether we also want that in material_ui.

I have no idea how it works, I think that is for gemini code assist, and I am not sure if it still working because the tech change fast. I will defer that to your team, but for now, I removed that file because packages repro doesn't have the same convention.

elliette · 2026-09-01T17:36:57Z

We should pubignore this directory so it's not released with material_ui (see https://github.com/flutter/packages/blob/main/packages/material_ui/tool/.pubignore for example)

I also wonder if it would make sense to add it in a subdirectory (e.g. material_ui/test_apps/a11y_assessments), especially if we are planning on having other apps in material_ui that aren't part of the examples.

@QuncCccccc what are your thoughts here?

QuncCccccc · 2026-09-01T18:24:24Z

Both suggestions make sense to me!

chunhtai · 2026-09-01T20:17:33Z

ok i will put it in test_apps

elliette

Thank you for updating the directory structure! Just one more change otherwise looks good.

elliette · 2026-09-02T18:25:20Z

Could we keep these as separate pubignores in tool and test_apps? See discussion here: #12469 (comment)

Basically if we have a pubignore here, we will have to keep it in-sync with the gitignore which sounds error prone to me ☹️

ah ok, the reason i moved it here is that the plugin tool only read the root pubignore, but looks like we shouldn't do that. will refer and see what to do

I updated the ci to be able to pick up pubingore in this case

chunhtai · 2026-09-02T20:14:21Z


  /// True if this package is located within a directory that is ignored
-  /// by the enclosing package's `.pubignore` file.
+  /// by the enclosing package's `.pubignore` file, or by a `.pubignore` file in


cc @stuartmorgan-g , in case there is a good reason not to.

I need this because I add a test app a11y_assessments to the material_ui, but the ci will read the pubignore only if it is in the root material_ui directory.

I can't think of any reason not to support this, we just didn't need it before.

elliette

LGTM! Thanks for fixing the isPubIgnored logic!

…r#192292) flutter/packages@f9b3954...9af9c60 2026-09-03 47866232+chunhtai@users.noreply.github.com [material_ui] Copies a11y_assessments (flutter/packages#12686) 2026-09-03 21270878+elliette@users.noreply.github.com [material_ui] Migrate M3 BottomSheet template to use new gen_defaults (flutter/packages#12731) 2026-09-03 21270878+elliette@users.noreply.github.com [material_ui] Migrate M3 ActionChip template to use new gen_defaults (flutter/packages#12732) 2026-09-03 bolling.ludwig@gmail.com [camera] Add setImageQuality for JPEG compression control (flutter/packages#11155) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

as title. Move the app in material gives us benefit that we can both fix accessibility issue and verify the fix on the app faster without waiting for a release cycle ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

github-actions Bot added platform-android platform-ios platform-linux platform-macos platform-web platform-windows p: material_ui triage-design Should be looked at in design triage labels Aug 28, 2026

chunhtai marked this pull request as ready for review August 31, 2026 20:54

chunhtai added the CICD Run CI/CD label Aug 31, 2026

gemini-code-assist Bot reviewed Aug 31, 2026

View reviewed changes

chunhtai requested review from QuncCccccc and elliette August 31, 2026 21:42

chunhtai added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Aug 31, 2026

QuncCccccc approved these changes Aug 31, 2026

View reviewed changes

chunhtai force-pushed the close_a11y_assessment branch from e6fb86f to 036f7b1 Compare September 1, 2026 20:25

elliette reviewed Sep 2, 2026

View reviewed changes

chunhtai commented Sep 2, 2026

View reviewed changes

chunhtai added 6 commits September 2, 2026 15:28

[material_ui] Copies a11y_assessments

1ca0c55

update

7f76b22

address review comment and ci

5fb4a6c

add ignore

ec9d6d4

fixes tests

22c156b

update

1fbe0bc

chunhtai added 4 commits September 2, 2026 15:28

update

5afc0c4

ci

3b6104a

Update

0f892f7

format

0df3700

chunhtai force-pushed the close_a11y_assessment branch from 26c3f23 to 0df3700 Compare September 2, 2026 22:28

elliette approved these changes Sep 2, 2026

View reviewed changes

chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 3, 2026

auto-submit Bot merged commit 9af9c60 into flutter:main Sep 3, 2026
13 checks passed

engine-flutter-autoroll mentioned this pull request Sep 4, 2026

Roll Packages from f9b3954a113d to 9af9c6076d79 (4 revisions) flutter/flutter#192292

Merged

suojae mentioned this pull request Oct 2, 2026

[material_ui] Scope MaterialBanner in a11y_assessments to its page #13106

Open

Conversation

chunhtai commented Aug 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chunhtai commented Aug 31, 2026

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

chunhtai commented Aug 31, 2026

Uh oh!

elliette commented Sep 1, 2026

Uh oh!

QuncCccccc commented Sep 1, 2026

Uh oh!

chunhtai commented Sep 1, 2026

Uh oh!

elliette left a comment

Choose a reason for hiding this comment

Uh oh!

elliette Sep 2, 2026

Choose a reason for hiding this comment

Uh oh!

chunhtai Sep 2, 2026

Choose a reason for hiding this comment

Uh oh!

chunhtai Sep 2, 2026

Choose a reason for hiding this comment

Uh oh!

chunhtai Sep 2, 2026

Choose a reason for hiding this comment

Uh oh!

chunhtai Sep 2, 2026

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Sep 3, 2026

Choose a reason for hiding this comment

Uh oh!

elliette left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

chunhtai commented Aug 28, 2026 •

edited

Loading