Sitelet https://github.com/flutter/flutter/pull/193251
Skip to content

[Android 17] Added Android 17 device to Firebase tests - #193251

Merged
auto-submit[bot] merged 2 commits into
flutter:masterfrom
jesswrd:update-firebase-test-37
Sep 29, 2026
Merged

auto-submit[bot] merged 2 commits into
flutter:masterfrom
jesswrd:update-firebase-test-37

Conversation

@jesswrd

@jesswrd jesswrd commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Added Android 17 device cubs to Firebase tests. Ran gcloud firebase test android models list to check the device exists.

Partially Addresses #189518

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new physical device configuration for the 'cubs' model to the CI targets in .ci.yaml. However, the specified Android version 37 does not exist yet and is unsupported by Firebase Test Lab, which will cause test failures. It is recommended to update the configuration to use a supported version, such as 34.

Comment thread .ci.yaml
@jesswrd jesswrd added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 29, 2026
@auto-submit
auto-submit Bot added this pull request to the merge queue Sep 29, 2026
Merged via the queue into flutter:master with commit 55b8f88 Sep 29, 2026
24 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 29, 2026
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Sep 29, 2026
flutter/flutter@c5a061b...55b8f88

2026-09-29 jesswon@google.com [Android 17] Added Android 17 device to Firebase tests (flutter/flutter#193251)
2026-09-29 bkonyi@google.com [engine] Fix remaining `unawaited_futures` lints (flutter/flutter#193508)
2026-09-29 chris@bracken.jp shell: Rename first-frame tests AddFirstFrameCallback* (flutter/flutter#193418)
2026-09-28 victorsanniay@gmail.com Enable `unawaited_futures` lint across the Flutter repository (flutter/flutter#193125)
2026-09-28 jesswon@google.com Upgrade flutter/flutter to Roblectric 4.17 (flutter/flutter#193369)
2026-09-28 63228361+krll-kov@users.noreply.github.com [engine] Decode animation frames with alpha after an opaque first frame (flutter/flutter#193113)
2026-09-28 15619084+vashworth@users.noreply.github.com Allow macOS tests to use macOS 15 or 26 (flutter/flutter#193317)
2026-09-28 nshahan@google.com Cleanup DDC SDK build targets (flutter/flutter#193193)

If this roll has caused a breakage, revert this CL and set the roller
to dry run mode using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC quncheng@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants