Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the .ci.yaml configuration file by upgrading the android_virtual_device dependency to android_37_google_apis_ps16k_x64.textpb and updating the corresponding avd_cipd_version build ID. There are no review comments, and I have no feedback to provide.
|
Wait until #193240 has been merged and soaked for around 200 commits. Let's ensure there are no flakes. |
linux_android_emu to 37 AVDlinux_android_emu to 37 AVD
|
Matt ran a bunch of LED builds of |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
autosubmit label was removed for flutter/flutter/193246, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Update
linux_android_emuto API 37 AVD.Wait until
linux_android_emu_unstablehas been updated to an API 37 AVD and has soaked against a small subset of tests before promotinglinux_android_emu. Monitor the tree to see if there are any flakes fromlinux_android_emu_usntable. If there are no flakes after around 200 commits, it is safe to merge this PR.Partially Addresses #189518
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.