[Windows] fix: Remove quotes from compiler warning suppression by Gustl22 · Pull Request #190873 · flutter/flutter

Gustl22 · 2026-08-10T20:02:23Z

When want to compile a windows project via another build system, here ninja (e.g. to have native code completion), an error occurs which states: cl : Command line error D8021 : invalid numeric argument '/wd"4100"'.

This is due to the fact, that quotes aren't supposed to be in the Compiler Warning Suppression flag:

/wdnnnn | Suppresses the compiler warning that is specified by nnnn. For example, /wd4326 suppresses compiler warning C4326.

See: https://learn.microsoft.com/en-us/cpp/build/reference/compiler-option-warning-level?view=msvc-170#remarks
And core developer of CMake discourages using quotes: https://gitlab.kitware.com/cmake/cmake/-/work_items/21396#note_854664

Fixes #103728
Towards #99584

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Regarding the tests: Support for CMake integration is still owing (see #99584). Testing this natively would likely need to fix this issue, too. So one can just test this ATM by just comparing the template with the output, which I didn't see an explicit test for (I guess it's tested anyways somewhere by comparing when creating a new project flutter create . with the stored output files). Please point me to the location, if there's a better testing strategy for this.

Regarding breaking change: I would not consider this as breaking change, although it has an influence on the user files. The compilation works the same before and after. It just plays a role for alternative compilation, which does not affect many people (besides developers for wanting debug native windows code).

gemini-code-assist

Code Review

This pull request updates multiple CMakeLists.txt files across various Windows build configurations and templates to remove the double quotes from the MSVC compiler option /wd"4100", changing it to /wd4100. There are no review comments, and I have no feedback to provide.

Gustl22 · 2026-08-10T20:29:26Z

To reproduce open the windows folder of a project in:

IntelliJ Ultimate 2026.2.1 with CLion (C & C++) plugin
Note: one has to set the ninja path in Visual Studio Toolchain via File -> Settings -> Build, Execution, Deployment -> Toolchains -> Visual Studio to e.g. C:\Program Files (x86)\Microsoft Visual Studio\18\BuildTools\Common7\IDE\CommonExtensions\Microsoft\CMake\Ninja\ninja.exe
CLion (not tested)
Visual Studio (not tested, but confirmed in [Windows] Newly created windows project fails to build in Visual Studio 2022 #103728)

mattkae

Reasonable by me. CC: @loic-sharma

…-ninja-build

Gustl22 · 2026-08-23T20:27:59Z

I can also add this test to create_test.dart for now:

  testUsingContext(
    'Windows CMakeLists.txt does not quote the compiler warning suppression flag',
    () async {
      final command = CreateCommand();
      final CommandRunner<void> runner = createTestCommandRunner(command);

      await runner.run(<String>['create', '--no-pub', '--platform=windows', projectDir.path]);

      final File cmakeLists = projectDir.childDirectory('windows').childFile('CMakeLists.txt');
      expect(cmakeLists, exists);
      final String contents = cmakeLists.readAsStringSync();
      expect(contents, isNot(matches(RegExp(r'/wd"\d+"'))));
    },
    overrides: {FeatureFlags: () => TestFeatureFlags(isWindowsEnabled: true)},
  );

But the better approach would be to test building an example project with ninja, as soon as supported, which also would cover this case.

loic-sharma

Thanks for bubbling up those links! LGTM

Gustl22 · 2026-08-31T16:09:35Z

Thank you for reviewing! Can you add the CICD label again? I merged master, as CI refused running, because it was out of sync. @mattkae Thank you!

flutter/flutter@c8c5e3b...0cbd1a4 2026-09-01 engine-flutter-autoroll@skia.org Roll Skia from 6be7f8547c3c to 3911a1fe7f7a (1 revision) (flutter/flutter#192110) 2026-09-01 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from EPzxifoyt36b5qiBy... to idslm9FikVLy2K_A-... (flutter/flutter#192104) 2026-09-01 engine-flutter-autoroll@skia.org Roll Skia from 47df2ae3226c to 6be7f8547c3c (1 revision) (flutter/flutter#192103) 2026-09-01 engine-flutter-autoroll@skia.org Roll Skia from e22ebf131e44 to 47df2ae3226c (4 revisions) (flutter/flutter#192099) 2026-09-01 engine-flutter-autoroll@skia.org Roll Skia from 5489a16a5998 to e22ebf131e44 (5 revisions) (flutter/flutter#192093) 2026-09-01 bkonyi@google.com [flutter_tools] Safely handle broken symlinks and existing files during plugin symlink creation (flutter/flutter#191496) 2026-09-01 97480502+b-luk@users.noreply.github.com Support wide gamut colors in gradient_generator's CreateGradientTexture (flutter/flutter#191980) 2026-09-01 47866232+chunhtai@users.noreply.github.com Clean up semantics code (flutter/flutter#191620) 2026-08-31 49662805+jesskuras@users.noreply.github.com Add website documentation item to PR pre-launch checklist (flutter/flutter#192080) 2026-08-31 kiran@kryali.com [windows] Fix null-deref in HostWindowPopup::UpdatePosition (Fixes #191478) (flutter/flutter#191479) 2026-08-31 47866232+chunhtai@users.noreply.github.com Removes deprecated ignoreSemantics parementers (flutter/flutter#191493) 2026-08-31 engine-flutter-autoroll@skia.org Roll Dart SDK from b319095e317b to 9164def35347 (1 revision) (flutter/flutter#192073) 2026-08-31 112751483+shivanshu877@users.noreply.github.com test: dynamic _tapOutside helper for TapRegion navigation tests (flutter/flutter#185397) 2026-08-31 git@reb0.org [Windows] fix: Remove quotes from compiler warning suppression (flutter/flutter#190873) 2026-08-31 47866232+chunhtai@users.noreply.github.com Migrate to listen package (flutter/flutter#189111) 2026-08-31 engine-flutter-autoroll@skia.org Roll Skia from 15db98a90bbd to 5489a16a5998 (2 revisions) (flutter/flutter#192070) 2026-08-31 110348311+Devasy@users.noreply.github.com Add regression test for plugin compileSdkExtension warning (flutter/flutter#191281) 2026-08-31 34871572+gmackall@users.noreply.github.com Explicitly disable HCPP in platform view benchmarks and integration tests (flutter/flutter#191908) 2026-08-31 matt.boetger@gmail.com Documentation and script for Gradle Distribution cache for CI (flutter/flutter#190323) 2026-08-31 engine-flutter-autoroll@skia.org Roll Skia from 5549c93c9a1c to 15db98a90bbd (2 revisions) (flutter/flutter#192068) 2026-08-31 engine-flutter-autoroll@skia.org Roll Packages from cd4cdd0 to d642322 (7 revisions) (flutter/flutter#192063) 2026-08-31 engine-flutter-autoroll@skia.org Roll Dart SDK from 48f641e8b249 to b319095e317b (1 revision) (flutter/flutter#192061) 2026-08-31 269567208+reidbaker-agent@users.noreply.github.com [tool] Migrate dev/tools from dart_skills_lint to skills_lint package (flutter/flutter#191997) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…r#12712) flutter/flutter@c8c5e3b...0cbd1a4 2026-09-01 engine-flutter-autoroll@skia.org Roll Skia from 6be7f8547c3c to 3911a1fe7f7a (1 revision) (flutter/flutter#192110) 2026-09-01 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from EPzxifoyt36b5qiBy... to idslm9FikVLy2K_A-... (flutter/flutter#192104) 2026-09-01 engine-flutter-autoroll@skia.org Roll Skia from 47df2ae3226c to 6be7f8547c3c (1 revision) (flutter/flutter#192103) 2026-09-01 engine-flutter-autoroll@skia.org Roll Skia from e22ebf131e44 to 47df2ae3226c (4 revisions) (flutter/flutter#192099) 2026-09-01 engine-flutter-autoroll@skia.org Roll Skia from 5489a16a5998 to e22ebf131e44 (5 revisions) (flutter/flutter#192093) 2026-09-01 bkonyi@google.com [flutter_tools] Safely handle broken symlinks and existing files during plugin symlink creation (flutter/flutter#191496) 2026-09-01 97480502+b-luk@users.noreply.github.com Support wide gamut colors in gradient_generator's CreateGradientTexture (flutter/flutter#191980) 2026-09-01 47866232+chunhtai@users.noreply.github.com Clean up semantics code (flutter/flutter#191620) 2026-08-31 49662805+jesskuras@users.noreply.github.com Add website documentation item to PR pre-launch checklist (flutter/flutter#192080) 2026-08-31 kiran@kryali.com [windows] Fix null-deref in HostWindowPopup::UpdatePosition (Fixes #191478) (flutter/flutter#191479) 2026-08-31 47866232+chunhtai@users.noreply.github.com Removes deprecated ignoreSemantics parementers (flutter/flutter#191493) 2026-08-31 engine-flutter-autoroll@skia.org Roll Dart SDK from b319095e317b to 9164def35347 (1 revision) (flutter/flutter#192073) 2026-08-31 112751483+shivanshu877@users.noreply.github.com test: dynamic _tapOutside helper for TapRegion navigation tests (flutter/flutter#185397) 2026-08-31 git@reb0.org [Windows] fix: Remove quotes from compiler warning suppression (flutter/flutter#190873) 2026-08-31 47866232+chunhtai@users.noreply.github.com Migrate to listen package (flutter/flutter#189111) 2026-08-31 engine-flutter-autoroll@skia.org Roll Skia from 15db98a90bbd to 5489a16a5998 (2 revisions) (flutter/flutter#192070) 2026-08-31 110348311+Devasy@users.noreply.github.com Add regression test for plugin compileSdkExtension warning (flutter/flutter#191281) 2026-08-31 34871572+gmackall@users.noreply.github.com Explicitly disable HCPP in platform view benchmarks and integration tests (flutter/flutter#191908) 2026-08-31 matt.boetger@gmail.com Documentation and script for Gradle Distribution cache for CI (flutter/flutter#190323) 2026-08-31 engine-flutter-autoroll@skia.org Roll Skia from 5549c93c9a1c to 15db98a90bbd (2 revisions) (flutter/flutter#192068) 2026-08-31 engine-flutter-autoroll@skia.org Roll Packages from cd4cdd0 to d642322 (7 revisions) (flutter/flutter#192063) 2026-08-31 engine-flutter-autoroll@skia.org Roll Dart SDK from 48f641e8b249 to b319095e317b (1 revision) (flutter/flutter#192061) 2026-08-31 269567208+reidbaker-agent@users.noreply.github.com [tool] Migrate dev/tools from dart_skills_lint to skills_lint package (flutter/flutter#191997) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

[Windows] fix: Remove quotes from compiler warning suppression

50e4677

Gustl22 requested a review from a team as a code owner August 10, 2026 20:02

github-actions Bot added tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos a: desktop Running on desktop labels Aug 10, 2026

gemini-code-assist Bot reviewed Aug 10, 2026

View reviewed changes

mattkae approved these changes Aug 12, 2026

View reviewed changes

mattkae requested a review from loic-sharma August 12, 2026 15:52

Gustl22 mentioned this pull request Aug 14, 2026

Make Visual Studio CMake integration work #99584

Open

Merge remote-tracking branch 'refs/remotes/upstream/main' into 103728…

bb77694

…-ninja-build

mattkae added the CICD Run CI/CD label Aug 31, 2026

loic-sharma approved these changes Aug 31, 2026

View reviewed changes

Merge branch 'master' into 103728-ninja-build

5d6ce74

flutter-dashboard Bot removed the CICD Run CI/CD label Aug 31, 2026

mattkae added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App labels Aug 31, 2026

auto-submit Bot added this pull request to the merge queue Aug 31, 2026

Merged via the queue into flutter:master with commit 74e9059 Aug 31, 2026
26 of 27 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 31, 2026

engine-flutter-autoroll mentioned this pull request Sep 1, 2026

Roll Flutter from c8c5e3bd7542 to 0cbd1a4be0a4 (23 revisions) flutter/packages#12712

Merged

Gustl22 deleted the 103728-ninja-build branch September 1, 2026 19:20

Navigation Menu

Repository navigation

[Windows] fix: Remove quotes from compiler warning suppression - #190873

[Windows] fix: Remove quotes from compiler warning suppression#190873
auto-submit[bot] merged 3 commits into
flutter:masterfrom
Gustl22:103728-ninja-build

Gustl22 commented Aug 10, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Gustl22 commented Aug 10, 2026

Uh oh!

mattkae left a comment

Uh oh!

Gustl22 commented Aug 23, 2026 •

edited

Loading

Uh oh!

loic-sharma left a comment

Uh oh!

Gustl22 commented Aug 31, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Gustl22 commented Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Gustl22 commented Aug 10, 2026

Uh oh!

mattkae left a comment

Choose a reason for hiding this comment

Uh oh!

Gustl22 commented Aug 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

loic-sharma left a comment

Choose a reason for hiding this comment

Uh oh!

Gustl22 commented Aug 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Gustl22 commented Aug 10, 2026 •

edited

Loading

Gustl22 commented Aug 23, 2026 •

edited

Loading

Gustl22 commented Aug 31, 2026 •

edited

Loading