Migrate to listen package by chunhtai · Pull Request #189111 · flutter/flutter

chunhtai · 2026-07-08T03:14:04Z

as title

will publish stable for listen package once this is approved

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

chunhtai · 2026-07-16T02:50:00Z

    # When updating to a new dartdoc version, please also update
    # `dartdoc_options.yaml` to include newly introduced error and warning types.
-    "$DART" pub global activate dartdoc 9.0.0
+    "$DART" pub global activate dartdoc 9.0.6


example directive support is added in 9.0.6, this is needed in order to build listen doc which pull into the main doc by the dartdoc

chunhtai · 2026-07-16T02:53:11Z

 /// framework.
 library foundation;

+export 'dart:ui' show VoidCallback;


This was exported by changenotifier before

gemini-code-assist

Code Review

This pull request replaces the internal implementation of ChangeNotifier and related classes in the foundation library with exports from the external listen package, updating dependencies and allowlists accordingly. Feedback on the changes suggests removing the redundant and eager initialization of Listenable hooks in BindingBase to avoid conflicts and performance overhead. Additionally, it is recommended to lazily set up these hooks in FlutterMemoryAllocations only when memory allocation tracking is enabled, and to use 'foundation' as the library name for consistency.

loic-sharma · 2026-07-18T16:55:40Z

+              library: 'foundation library',
+              context: ErrorDescription('while dispatching notifications for $Listenable'),
+            ),
+          );


Should we add a default case? Otherwise, adding a new ErrorContext enum value would be a breaking change here.

flutter suggest not to use default

Analyzing Flutter repository... 4.9s info • Invalid use of 'default' member in a switch. Try enumerating all the possible values of the switch expression • packages/flutter/lib/src/foundation/binding.dart:314:9 • no_default_cases

I agree with no_default_cases for enums that are declared in the Flutter SDK, but I'm not sure that I agree in this instance where the enum is in a separate package that the Flutter SDK depends on. A user can use an old version of the Flutter SDK with a newer version of package:listen.

The benefit of a default case is that we guarantee our logic handles all known enum cases. However, I don't think that benefit outweighs the drawback that adding a new enum value would be a breaking change that forces you to upgrade your Flutter SDK. I still lean towards using a default case here and suppressing no_default_cases. Let me know if I'm missing anything here though!

I disagree to use default case in general since it can potentially make things fail silently. For this case, it is probably fine since this is mostly just for logging and report error, but i still would like to follow the lint and not use default case just because i don't want to add a ignore and confuse people

Just to make sure the problem is clear: if we omit the default case and we add a new ErrorContext enum value, running flutter pub upgrade on your app will result in compilation errors. You'll also get compilation errors if you flutter create using an old Flutter SDK. You will need to either add a version constraint on package:listen, or, upgrade to a Flutter SDK that handles the new value (if one exists, which it might not yet due to the SDK's quarterly release cadence). This seems like a painful situation that we should avoid.

... but i still would like to follow the lint and not use default case just because i don't want to add a ignore and confuse people

Instead of failing silently, we could fallback to a FlutterError.reportError with a context like ErrorDescription('in an unknown location')? And to make it easier to remember to update this switch, we could update package:listenable's ErrorContext to add a // comment that if you add a new value to the enum, you must update the framework's Listenable.onError callback. What would you think of this approach?

loic-sharma

This looks good to me! I left some minor nitpicks and questions :)

chunhtai · 2026-07-31T02:06:00Z

google test fails because it require the listen package to be roll in first as the internal flutter sdk doesn't have access to pub

loic-sharma

Re-LGTM but I still lean towards adding a default case for the ErrorContext switch (comment).

chunhtai · 2026-08-17T21:55:52Z

still working on internal migration. it is a lot involved than I think, lots of code directly import the source file change_notifier.dart. I have been fixing them as well as build files

justinmc

LGTM 👍

justinmc · 2026-08-17T22:04:43Z

+            AssertionError(message: final Object? msg) => msg?.toString() ?? error.toString(),
+            _ => error.toString(),
+          };
+          throw FlutterError(message);


Do we lose the stacktrace here?

auto-submit · 2026-08-31T19:00:01Z

autosubmit label was removed for flutter/flutter/189111, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

flutter/flutter@c8c5e3b...0cbd1a4 2026-09-01 engine-flutter-autoroll@skia.org Roll Skia from 6be7f8547c3c to 3911a1fe7f7a (1 revision) (flutter/flutter#192110) 2026-09-01 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from EPzxifoyt36b5qiBy... to idslm9FikVLy2K_A-... (flutter/flutter#192104) 2026-09-01 engine-flutter-autoroll@skia.org Roll Skia from 47df2ae3226c to 6be7f8547c3c (1 revision) (flutter/flutter#192103) 2026-09-01 engine-flutter-autoroll@skia.org Roll Skia from e22ebf131e44 to 47df2ae3226c (4 revisions) (flutter/flutter#192099) 2026-09-01 engine-flutter-autoroll@skia.org Roll Skia from 5489a16a5998 to e22ebf131e44 (5 revisions) (flutter/flutter#192093) 2026-09-01 bkonyi@google.com [flutter_tools] Safely handle broken symlinks and existing files during plugin symlink creation (flutter/flutter#191496) 2026-09-01 97480502+b-luk@users.noreply.github.com Support wide gamut colors in gradient_generator's CreateGradientTexture (flutter/flutter#191980) 2026-09-01 47866232+chunhtai@users.noreply.github.com Clean up semantics code (flutter/flutter#191620) 2026-08-31 49662805+jesskuras@users.noreply.github.com Add website documentation item to PR pre-launch checklist (flutter/flutter#192080) 2026-08-31 kiran@kryali.com [windows] Fix null-deref in HostWindowPopup::UpdatePosition (Fixes #191478) (flutter/flutter#191479) 2026-08-31 47866232+chunhtai@users.noreply.github.com Removes deprecated ignoreSemantics parementers (flutter/flutter#191493) 2026-08-31 engine-flutter-autoroll@skia.org Roll Dart SDK from b319095e317b to 9164def35347 (1 revision) (flutter/flutter#192073) 2026-08-31 112751483+shivanshu877@users.noreply.github.com test: dynamic _tapOutside helper for TapRegion navigation tests (flutter/flutter#185397) 2026-08-31 git@reb0.org [Windows] fix: Remove quotes from compiler warning suppression (flutter/flutter#190873) 2026-08-31 47866232+chunhtai@users.noreply.github.com Migrate to listen package (flutter/flutter#189111) 2026-08-31 engine-flutter-autoroll@skia.org Roll Skia from 15db98a90bbd to 5489a16a5998 (2 revisions) (flutter/flutter#192070) 2026-08-31 110348311+Devasy@users.noreply.github.com Add regression test for plugin compileSdkExtension warning (flutter/flutter#191281) 2026-08-31 34871572+gmackall@users.noreply.github.com Explicitly disable HCPP in platform view benchmarks and integration tests (flutter/flutter#191908) 2026-08-31 matt.boetger@gmail.com Documentation and script for Gradle Distribution cache for CI (flutter/flutter#190323) 2026-08-31 engine-flutter-autoroll@skia.org Roll Skia from 5549c93c9a1c to 15db98a90bbd (2 revisions) (flutter/flutter#192068) 2026-08-31 engine-flutter-autoroll@skia.org Roll Packages from cd4cdd0 to d642322 (7 revisions) (flutter/flutter#192063) 2026-08-31 engine-flutter-autoroll@skia.org Roll Dart SDK from 48f641e8b249 to b319095e317b (1 revision) (flutter/flutter#192061) 2026-08-31 269567208+reidbaker-agent@users.noreply.github.com [tool] Migrate dev/tools from dart_skills_lint to skills_lint package (flutter/flutter#191997) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…r#12712) flutter/flutter@c8c5e3b...0cbd1a4 2026-09-01 engine-flutter-autoroll@skia.org Roll Skia from 6be7f8547c3c to 3911a1fe7f7a (1 revision) (flutter/flutter#192110) 2026-09-01 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from EPzxifoyt36b5qiBy... to idslm9FikVLy2K_A-... (flutter/flutter#192104) 2026-09-01 engine-flutter-autoroll@skia.org Roll Skia from 47df2ae3226c to 6be7f8547c3c (1 revision) (flutter/flutter#192103) 2026-09-01 engine-flutter-autoroll@skia.org Roll Skia from e22ebf131e44 to 47df2ae3226c (4 revisions) (flutter/flutter#192099) 2026-09-01 engine-flutter-autoroll@skia.org Roll Skia from 5489a16a5998 to e22ebf131e44 (5 revisions) (flutter/flutter#192093) 2026-09-01 bkonyi@google.com [flutter_tools] Safely handle broken symlinks and existing files during plugin symlink creation (flutter/flutter#191496) 2026-09-01 97480502+b-luk@users.noreply.github.com Support wide gamut colors in gradient_generator's CreateGradientTexture (flutter/flutter#191980) 2026-09-01 47866232+chunhtai@users.noreply.github.com Clean up semantics code (flutter/flutter#191620) 2026-08-31 49662805+jesskuras@users.noreply.github.com Add website documentation item to PR pre-launch checklist (flutter/flutter#192080) 2026-08-31 kiran@kryali.com [windows] Fix null-deref in HostWindowPopup::UpdatePosition (Fixes #191478) (flutter/flutter#191479) 2026-08-31 47866232+chunhtai@users.noreply.github.com Removes deprecated ignoreSemantics parementers (flutter/flutter#191493) 2026-08-31 engine-flutter-autoroll@skia.org Roll Dart SDK from b319095e317b to 9164def35347 (1 revision) (flutter/flutter#192073) 2026-08-31 112751483+shivanshu877@users.noreply.github.com test: dynamic _tapOutside helper for TapRegion navigation tests (flutter/flutter#185397) 2026-08-31 git@reb0.org [Windows] fix: Remove quotes from compiler warning suppression (flutter/flutter#190873) 2026-08-31 47866232+chunhtai@users.noreply.github.com Migrate to listen package (flutter/flutter#189111) 2026-08-31 engine-flutter-autoroll@skia.org Roll Skia from 15db98a90bbd to 5489a16a5998 (2 revisions) (flutter/flutter#192070) 2026-08-31 110348311+Devasy@users.noreply.github.com Add regression test for plugin compileSdkExtension warning (flutter/flutter#191281) 2026-08-31 34871572+gmackall@users.noreply.github.com Explicitly disable HCPP in platform view benchmarks and integration tests (flutter/flutter#191908) 2026-08-31 matt.boetger@gmail.com Documentation and script for Gradle Distribution cache for CI (flutter/flutter#190323) 2026-08-31 engine-flutter-autoroll@skia.org Roll Skia from 5549c93c9a1c to 15db98a90bbd (2 revisions) (flutter/flutter#192068) 2026-08-31 engine-flutter-autoroll@skia.org Roll Packages from cd4cdd0 to d642322 (7 revisions) (flutter/flutter#192063) 2026-08-31 engine-flutter-autoroll@skia.org Roll Dart SDK from 48f641e8b249 to b319095e317b (1 revision) (flutter/flutter#192061) 2026-08-31 269567208+reidbaker-agent@users.noreply.github.com [tool] Migrate dev/tools from dart_skills_lint to skills_lint package (flutter/flutter#191997) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

github-actions Bot added the framework flutter/packages/flutter repository. See also f: labels. label Jul 8, 2026

chunhtai added the CICD Run CI/CD label Jul 8, 2026

chunhtai force-pushed the migrate-listen branch from 2d8a137 to c417663 Compare July 10, 2026 00:25

github-actions Bot added a: tests "flutter test", flutter_test, or one of our tests tool Affects the "flutter" command-line tool. See also t: labels. labels Jul 10, 2026

chunhtai force-pushed the migrate-listen branch 3 times, most recently from dc49b21 to 7b24f9b Compare July 14, 2026 02:59

github-actions Bot removed a: tests "flutter test", flutter_test, or one of our tests tool Affects the "flutter" command-line tool. See also t: labels. labels Jul 14, 2026

chunhtai force-pushed the migrate-listen branch from 5414cca to 8bc2673 Compare July 16, 2026 02:47

github-actions Bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 16, 2026

chunhtai commented Jul 16, 2026

View reviewed changes

chunhtai marked this pull request as ready for review July 16, 2026 03:58

chunhtai requested review from justinmc and loic-sharma July 16, 2026 03:59

gemini-code-assist Bot reviewed Jul 16, 2026

View reviewed changes

Comment thread packages/flutter/lib/src/foundation/binding.dart Outdated

Comment thread packages/flutter/lib/src/foundation/memory_allocations.dart

chunhtai force-pushed the migrate-listen branch from 239e8c2 to b5e0841 Compare July 16, 2026 04:10

loic-sharma reviewed Jul 18, 2026

View reviewed changes

Comment thread packages/flutter/pubspec.yaml Outdated

loic-sharma reviewed Jul 18, 2026

View reviewed changes

Comment thread packages/flutter/lib/src/foundation/binding.dart Outdated

loic-sharma reviewed Jul 18, 2026

View reviewed changes

Comment thread dev/bots/docs.sh

loic-sharma previously approved these changes Jul 18, 2026

View reviewed changes

Piinks added this to Google Testing Queue Jul 21, 2026

jellynoone mentioned this pull request Jul 26, 2026

feat: Use the listen package schultek/jaspr#839

Closed

chunhtai dismissed loic-sharma’s stale review via 7849d0a July 31, 2026 00:32

chunhtai force-pushed the migrate-listen branch from b5e0841 to 7849d0a Compare July 31, 2026 00:32

chunhtai force-pushed the migrate-listen branch 2 times, most recently from bce695b to 8096439 Compare August 6, 2026 02:04

chunhtai requested a review from loic-sharma August 6, 2026 02:13

loic-sharma approved these changes Aug 8, 2026

View reviewed changes

zeykafx mentioned this pull request Aug 10, 2026

Refactor: Migrate to listen package schultek/jaspr#865

Merged

3 of 4 tasks

Piinks assigned chunhtai Aug 17, 2026

justinmc approved these changes Aug 17, 2026

View reviewed changes

chunhtai force-pushed the migrate-listen branch from 705d406 to e39efcb Compare August 25, 2026 17:23

nank1ro mentioned this pull request Aug 27, 2026

refactor: move signal Listenable support into solidart via package:listen nank1ro/solidart#178

Draft

chunhtai force-pushed the migrate-listen branch from e39efcb to 8950a7d Compare August 27, 2026 19:26

chunhtai added 4 commits August 31, 2026 10:18

Migrate to listen package

0c86e7b

update

e39fdb4

update

8ced640

revert default

ef05955

chunhtai force-pushed the migrate-listen branch from 8950a7d to ef05955 Compare August 31, 2026 17:19

chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 31, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 31, 2026

chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 31, 2026

auto-submit Bot added this pull request to the merge queue Aug 31, 2026

Merged via the queue into flutter:master with commit 5149053 Aug 31, 2026
29 checks passed

github-project-automation Bot moved this to Done in Google Testing Queue Aug 31, 2026

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 31, 2026

engine-flutter-autoroll mentioned this pull request Sep 1, 2026

Roll Flutter from c8c5e3bd7542 to 0cbd1a4be0a4 (23 revisions) flutter/packages#12712

Merged

Conversation

chunhtai commented Jul 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

chunhtai Jul 16, 2026

Choose a reason for hiding this comment

Uh oh!

chunhtai Jul 16, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

loic-sharma Jul 18, 2026

Choose a reason for hiding this comment

Uh oh!

chunhtai Aug 6, 2026

Choose a reason for hiding this comment

Uh oh!

loic-sharma Aug 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chunhtai Aug 10, 2026

Choose a reason for hiding this comment

Uh oh!

loic-sharma Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

loic-sharma left a comment

Choose a reason for hiding this comment

Uh oh!

chunhtai commented Jul 31, 2026

Uh oh!

loic-sharma left a comment

Choose a reason for hiding this comment

Uh oh!

chunhtai commented Aug 17, 2026

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc Aug 17, 2026

Choose a reason for hiding this comment

Uh oh!

auto-submit Bot commented Aug 31, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

chunhtai commented Jul 8, 2026 •

edited

Loading

loic-sharma Aug 7, 2026 •

edited

Loading

loic-sharma Aug 10, 2026 •

edited

Loading