Updated Remaining Engine Defaults to SDK 37 - #190429
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Code Review
This pull request upgrades the Android SDK version from 36 to 37 across the repository, updating build configurations, Gradle files, AndroidManifest.xml, and related tooling scripts. There are no review comments, and I have no feedback to provide.
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Wait for robolectric 4.17 PRs: #193369 and flutter/packages#13041 to merge before merging this one. |
both have been merged |
flutter/flutter@e89fd0a...d03768e 2026-10-02 engine-flutter-autoroll@skia.org Roll Skia from 7b7326917e77 to 9e88bf828078 (8 revisions) (flutter/flutter#193694) 2026-10-02 bkonyi@google.com [Widget Preview] Provide descriptive error when widget preview is unconstrained (flutter/flutter#193005) 2026-10-02 engine-flutter-autoroll@skia.org Roll Dart SDK from 0e7642b85457 to ac1a97aae47d (26 revisions) (flutter/flutter#193692) 2026-10-02 mbrase@google.com Remove unused Fuchsia sysmem header files (flutter/flutter#193244) 2026-10-02 57864509+tjcGoogle@users.noreply.github.com [Windows] Preserve composing extent in setEditingState (flutter/flutter#189968) 2026-10-02 brackenavaron@gmail.com [docs] Make Border.symmetric docs more explicit about their arguments (flutter/flutter#193222) 2026-10-02 60122246+xiaowei-guan@users.noreply.github.com [Embedder] Support render texture for vulkan (flutter/flutter#188855) 2026-10-02 jesswon@google.com Updated Remaining Engine Defaults to SDK 37 (flutter/flutter#190429) 2026-10-02 105214765+HibaChamkhi@users.noreply.github.com Document that enableSuggestions: false can disable keyboard languages on Android (flutter/flutter#192714) 2026-10-02 bkonyi@google.com [flutter_tools] Explicitly track host CPU architecture in command result analytics (flutter/flutter#191836) 2026-10-02 kevmoo@users.noreply.github.com [web] Preserve DOM focus on role update and honor isAccessibilityFocusBlocked (flutter/flutter#192963) 2026-10-02 mdebbar@google.com [flutter_tools] Include base href in web hot reload script paths (flutter/flutter#193678) 2026-10-02 kevmoo@users.noreply.github.com [Impeller] Deduplicate GLES render pass state (flutter/flutter#193427) 2026-10-02 engine-flutter-autoroll@skia.org Roll Skia from f2d68e0b8863 to 7b7326917e77 (16 revisions) (flutter/flutter#193676) 2026-10-01 bkonyi@google.com Fix analysis failures due to missing `const` (flutter/flutter#193685) 2026-10-01 47866232+chunhtai@users.noreply.github.com Removes a11y_assessment app (flutter/flutter#193671) 2026-10-01 codefu@google.com test: configure Xvfb and openbox for windowing_test (flutter/flutter#193529) 2026-10-01 154381524+flutteractionsbot@users.noreply.github.com Sync CHANGELOG.md from stable (flutter/flutter#193666) 2026-10-01 alexmarkov@google.com Avoid using relative path in Process.start (flutter/flutter#193664) 2026-10-01 269567208+reidbaker-agent@users.noreply.github.com [AGP 9.1.0 Migration #6] Deliver Flutter assets as a generated assets source directory on the app path (flutter/flutter#192488) 2026-10-01 codefu@google.com ci(bringup): android_java17_build_android_host_app_with_module_aar is green (flutter/flutter#193580) 2026-10-01 bkonyi@google.com [flutter_tools] Fix Use dependency graph to determine plugin initialization order (flutter/flutter#191591) 2026-10-01 bkonyi@google.com [flutter_tools] Migrate DaemonCommand and Daemon domains to constructor DI (flutter/flutter#193542) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC quncheng@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Updated engine defaults to SDK 37.
Helpful tip for future: All the tooling updates have the exact same naming conventions as whatever got uploaded to CIPD (so whatever is bundled with AS). Everything failed when I did updated to
"//flutter/third_party/android_tools/sdk/platforms/android-37/android.jar". Android tooling decided to change the naming convention to../platforms/android-37.0, so the above failed. I downloaded a recently uploaded SDK to check and lo and there was a.0.There was no need to update the Gradle version due to: #189417
Some defaults have already been updated by: #189962
Partially Addresses #189518
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.