[Android] Inject command line flags into manifest in release mode when not running pre-built binary by camsim99 · Pull Request #190222 · flutter/flutter

camsim99 · 2026-07-29T17:21:29Z

When a Flutter Android app is run in release mode WITHOUT a prebuilt binary, send the flags to the embedding via manifest injection instead of Intent extras.

Updated a pre-existing integration test to run in release mode to prove that passing flags via the command line still works as expected in release mode. Successful run: https://ci.chromium.org/ui/p/flutter/builders/try/Linux_android_emu%20android_engine_flags_release_test/5238/overview

Part of #190461.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

camsim99 · 2026-08-03T20:28:35Z

Unrelated change: Just updating the warning to reflect actual future work.

gemini-code-assist

Code Review

This pull request introduces a mechanism to pass command-line engine shell arguments to the Flutter Android embedding in release mode by injecting them into the application's AndroidManifest.xml metadata, avoiding reliance on deprecated Intent extras. It adds a new Gradle task GenerateEngineFlagsManifestTask to generate the manifest with Base64-encoded arguments, updates FlutterLoader to parse and apply these arguments, and adapts AndroidDevice and DebuggingOptions to handle the launch arguments. Feedback on the changes identifies that formatting modifications in VersionUtils.kt shifted version comparison comments to the wrong code blocks, which should be corrected.

mboetger

LGTM overall. A few comments.

mboetger · 2026-08-12T21:17:21Z

            when {
-                baseFlutterTask.buildMode == "debug" -> listOf("debug_android_application")
-                baseFlutterTask.deferredComponents!! ->
+                baseFlutterTask.buildMode == "debug" -> {


Seems like this file was re-formated, but didn't actually change? Can we just revert these changes to clean the diff up? Or am I missing something?

Sigh I think how I'm running ktlint locally keeps pulling in extra files unexpectedly. Apologies!

Happens to me all the time :)

flutter#191321) Fixes regression caused by flutter#190222 that accidentally stopped respecting the `enable-software-rendering` Intent flag in the Android embedding. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…line in release mode (flutter#191328) Follow up to flutter#190222. Routes `route` through the manifest when used in release mode to follow the precedent of other Android engine flags as part of the work towards flutter#190461. Separate PR created for clarity; `route` is parsed apart from most other engine flags. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

camsim99 added 3 commits July 28, 2026 16:21

first pass

e5f38e5

formatting

c77935f

Revert PR 2 engine changes

906116f

github-actions Bot added platform-android Android applications specifically tool Affects the "flutter" command-line tool. See also t: labels. team-android Owned by Android platform team labels Jul 29, 2026

camsim99 added 2 commits July 29, 2026 15:36

Improvements pt1. Still need lots of testing

eb18fe7

format

f1330e3

github-actions Bot added the engine flutter/engine related. See also e: labels. label Jul 29, 2026

camsim99 added 4 commits July 30, 2026 15:47

Review 2

c6a7863

format

369e6a1

Merge remote-tracking branch 'upstream/master' into secure_intents

3590908

fix java tests

2e9a146

camsim99 changed the title ~~[Android] Restrict ability to use Flutter CLI flags in release mode~~ [Android] Inject command line flags into manifest in release mode when not running pre-built binary Aug 3, 2026

camsim99 added 5 commits August 3, 2026 12:59

final edits

329df31

Merge remote-tracking branch 'upstream/master' into secure_intents

36ddfef

analyze issues

176bd0d

modify warning

f2a8338

nit

efd62bf

camsim99 commented Aug 3, 2026

View reviewed changes

camsim99 added the CICD Run CI/CD label Aug 3, 2026

camsim99 added 6 commits August 3, 2026 14:24

really?

a1fa01b

hopefully fix stack overflow

e88c09f

hopefully fix flags int test

d414170

attempt to fix formatting

8ed8dd5

add test flag back. oops

1bc982b

remove unused imports + add license headers

c8bba3d

camsim99 marked this pull request as ready for review August 4, 2026 22:26

camsim99 requested a review from a team as a code owner August 4, 2026 22:26

camsim99 removed the request for review from a team August 4, 2026 22:26

camsim99 requested a review from mboetger August 4, 2026 22:26

gemini-code-assist Bot reviewed Aug 4, 2026

View reviewed changes

Comment thread packages/flutter_tools/gradle/src/main/kotlin/VersionUtils.kt Outdated

camsim99 added 4 commits August 4, 2026 15:32

restore accidentally touched file

4728588

Merge remote-tracking branch 'upstream/master' into secure_intents

d22064e

fix analyze

b4443cb

Merge remote-tracking branch 'upstream/master' into secure_intents

1ad4726

camsim99 mentioned this pull request Aug 10, 2026

[Android] Update the CLI to reject passing engine configuration flags with a prebuilt binary in release mode #190870

Merged

10 tasks done

mboetger previously approved these changes Aug 12, 2026

View reviewed changes

camsim99 added 2 commits August 13, 2026 13:17

Merge remote-tracking branch 'upstream/master' into secure_intents

a0f7aec

oopsies

5caaf1e

camsim99 dismissed mboetger’s stale review via 5caaf1e August 13, 2026 20:19

camsim99 requested a review from mboetger August 13, 2026 20:21

mboetger approved these changes Aug 13, 2026

View reviewed changes

Merge branch 'master' into secure_intents

e6501bd

camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 18, 2026

auto-submit Bot added this pull request to the merge queue Aug 18, 2026

Merged via the queue into flutter:master with commit 7bff211 Aug 18, 2026
21 of 22 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 18, 2026

This was referenced Aug 18, 2026

[Android] Fix respecting--enable-software-rendering in the embedding #191321

Merged

[Android] Inject route into manifest when specified on the command line in release mode #191328

Merged

This was referenced Aug 19, 2026

Roll Flutter from c2437523d308 to a539e0ed6058 (126 revisions) flutter/packages#12510

Closed

Roll Flutter from c2437523d308 to 7099814fba85 (127 revisions) flutter/packages#12511

Closed

Navigation Menu

Repository navigation

[Android] Inject command line flags into manifest in release mode when not running pre-built binary - #190222

[Android] Inject command line flags into manifest in release mode when not running pre-built binary#190222
auto-submit[bot] merged 27 commits into
flutter:masterfrom
camsim99:secure_intents

camsim99 commented Jul 29, 2026 •

edited

Loading

Uh oh!

camsim99 Aug 3, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

mboetger left a comment

Uh oh!

Uh oh!

mboetger Aug 12, 2026

Uh oh!

camsim99 Aug 13, 2026

Uh oh!

mboetger Aug 13, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

camsim99 commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

camsim99 Aug 3, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

mboetger left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mboetger Aug 12, 2026

Choose a reason for hiding this comment

Uh oh!

camsim99 Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

mboetger Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

camsim99 commented Jul 29, 2026 •

edited

Loading