Repository navigation
Clarify CustomScrollView use cases - #189692
Merged
auto-submit[bot] merged 4 commits intoJul 29, 2026
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for CustomScrollView to describe it as combining and scrolling multiple kinds of content together, specifically adding a reference to wrapping box widgets in a SliverToBoxAdapter. Feedback suggests using the singular form 'a box widget' to prevent the implication that a single SliverToBoxAdapter can accept multiple child widgets.
victorsanni
reviewed
Jul 21, 2026
victorsanni
approved these changes
Jul 23, 2026
Piinks
force-pushed
the
docs/custom-scroll-view-use-case
branch
from
July 28, 2026 22:20
6475601 to
831acaf
Compare
This was referenced Jul 29, 2026
stuartmorgan-g
pushed a commit
to flutter/packages
that referenced
this pull request
Jul 30, 2026
…12325) Manual roll requested by stuartmorgan@google.com flutter/flutter@c83f80b...2a230d1 2026-07-29 zerouali.bardai.omar@gmail.com Clarify CustomScrollView use cases (flutter/flutter#189692) 2026-07-29 brunocorona.alcantar@gmail.com Fix TreeSliver first node clipping during expand/collapse animation (flutter/flutter#188626) 2026-07-29 chris@bracken.jp iOS: Migrate VSyncClient tests to Swift Testing (flutter/flutter#190054) 2026-07-29 32538273+ValentinVignal@users.noreply.github.com Remove no shuffle from flutter_driver extension_test.dart and mock flutter.process channel (flutter/flutter#187559) 2026-07-29 52160996+FMorschel@users.noreply.github.com Adds missing await on `instantiateImageCodecFromBuffer` (flutter/flutter#188910) 2026-07-29 1961493+harryterkelsen@users.noreply.github.com [web] Provide Content-Length header for CanvasKit files in flutter test (flutter/flutter#190155) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the
CustomScrollViewAPI documentation to describe its common use case more directly: combining different kinds of scrollable content. The introduction now also calls outSliverToBoxAdapter, so readers can see how regular box widgets fit alongside lists, grids, and expanding headers.Fixes #142673.
Tests: not run (documentation-only change; comment-only changes are automatically test-exempt).
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.