Repository navigation
Adds missing await on instantiateImageCodecFromBuffer - #188910
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Code Review
This pull request modifies the instantiateImageCodecFromBuffer function in painting.dart to be asynchronous by adding the async modifier and awaiting the call to engine.renderer.instantiateImageCodec. There are no review comments, and I have no feedback to provide.
|
test-exempt: unblocks future Dart roll |
|
Since you've reviewed the other PR (I'm not sure how familiar you are with this, but it doesn't hurt to try), would you mind looking at this one, @navaronbracke and @dkwingsmt (for the Google bots, please)? |
|
I'm familiar with the context of the new rule, so yes :) |
|
@yjbanov, PTAL. Thanks! |
…12325) Manual roll requested by stuartmorgan@google.com flutter/flutter@c83f80b...2a230d1 2026-07-29 zerouali.bardai.omar@gmail.com Clarify CustomScrollView use cases (flutter/flutter#189692) 2026-07-29 brunocorona.alcantar@gmail.com Fix TreeSliver first node clipping during expand/collapse animation (flutter/flutter#188626) 2026-07-29 chris@bracken.jp iOS: Migrate VSyncClient tests to Swift Testing (flutter/flutter#190054) 2026-07-29 32538273+ValentinVignal@users.noreply.github.com Remove no shuffle from flutter_driver extension_test.dart and mock flutter.process channel (flutter/flutter#187559) 2026-07-29 52160996+FMorschel@users.noreply.github.com Adds missing await on `instantiateImageCodecFromBuffer` (flutter/flutter#188910) 2026-07-29 1961493+harryterkelsen@users.noreply.github.com [web] Provide Content-Length header for CanvasKit files in flutter test (flutter/flutter#190155) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…r#191129) This merely refactors a `try`, so it works as expected by the authors. I'm not sure why the bot didn't trigger this case along with flutter#188910. Still work towards: - dart-lang/sdk#62555. We are now making the new `analyzer` warning trigger on non-`async` cases too because that is probably what the code is _meant_ to do. I don't expect this change to break any tests. If it does, we caught an untracked error. CC @navaronbracke ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Mohellebi Abdessalem <116356835+AbdeMohlbi@users.noreply.github.com>
This is merely a work towards:
We are now making the new
analyzerwarning trigger on non-asynccases too because that is probably what the code is meant to do.I don't expect this change to break any tests. If it does, we caught an untracked error.
Pre-launch Checklist
///).