Use reachable final spill accesses when placing heap buffers - #388
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
sbillig
added this pull request to stack #390
October 4, 2026 17:25
sbillig
force-pushed
the
perf/reachable-final-spill-bounds
branch
4 times, most recently
from
October 4, 2026 18:26
4bcef3e to
358cf1b
Compare
sbillig
force-pushed
the
perf/reachable-final-spill-bounds
branch
from
October 4, 2026 19:44
358cf1b to
f50ea9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compute each heap allocation's final-spill floor from the spill accesses reachable from its boundary. This avoids reserving spill space belonging only to unrelated control-flow paths.
Also exclude fixed terminal writes when every successor path halts before any further allocator memory access or internal call. This prevents finished return and revert buffers from unnecessarily raising spill reservations. Loops, internal returns, and possible later loads or stores retain their exclusions, preserving interference in both directions.
Stacked on #387.