Limit unknown-pointer liveness to reachable allocations - #387
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
sbillig
added this pull request to stack #390
October 4, 2026 17:25
sbillig
force-pushed
the
perf/reachable-object-lifetimes
branch
3 times, most recently
from
October 4, 2026 18:26
df4c582 to
a1a7954
Compare
Base automatically changed from
perf/rematerialize-cheap-calldata-loads
to
main
October 4, 2026 18:26
sbillig
force-pushed
the
perf/reachable-object-lifetimes
branch
from
October 4, 2026 18:26
a1a7954 to
37cb078
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restrict unknown-pointer object closures to allocations that may have executed before the use. Track allocation availability through the CFG and use predecessor-exit information for phi operands.
Expanding an unknown pointer to every allocation in the function made buffers in mutually exclusive dispatcher branches interfere. The narrower closure allows those buffers to share storage while retaining allocations reachable through loop backedges and preserving known provenance and escape constraints.
Stacked on #386.