Sitelet https://github.com/dotnet/Docker.DotNet/pull/591
Skip to content

fix(#590): Do not pull non existing images in monitor event unit tests - #591

Merged
galvesribeiro merged 1 commit into
dotnet:masterfrom
HofmeisterAn:bugfix/remove-unnecessary-createimageasync
Sep 23, 2022
Merged

galvesribeiro merged 1 commit into
dotnet:masterfrom
HofmeisterAn:bugfix/remove-unnecessary-createimageasync

Conversation

@HofmeisterAn

Copy link
Copy Markdown
Contributor

No description provided.

@HofmeisterAn

Copy link
Copy Markdown
Contributor Author

@aDisplayName @galvesribeiro I think this is better. We do not need to pull images (that do not exist) to test the monitor event API.

@galvesribeiro galvesribeiro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@galvesribeiro
galvesribeiro merged commit 30181cc into dotnet:master Sep 23, 2022
@HofmeisterAn
HofmeisterAn deleted the bugfix/remove-unnecessary-createimageasync branch September 23, 2022 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants