Handle Reponse Error when building image - #590

#555

@HofmeisterAn , can you take a look?

All CLA requirements met.

That is great. I stumbled across this issue too. Thanks for fixing it. Can you add a small test too?

I need to figure it out... It seems the existing tests were done against actual docker hub registry.

So instead, I tries a real non-existing repo, and finger crossed no one will create such repository for real in the future.

@HofmeisterAn , The test has been added.

@galvesribeiro , can you help to take a look as well? Thank you.

Alright, so who is the "maintainer" that can approve for the workflow?

Okay, it looks like by enabling the error handling and throwing out the exception, some of the other tests utilizing the bug have failed. .... Let me figure out whether should we disable those tests:

Docker.DotNet.Tests.ISystemOperationsTests.MonitorEventsAsync_Succeeds();
Docker.DotNet.Tests.ISystemOperationsTests.MonitorEventsFiltered_Succeeds();

@galvesribeiro has permissions to merge it. Let's wait until he caught up. No one is maintaining the project full time.

Let me figure out whether should we disable those tests.

We should fix the tests instead. I can take a look at it in the next days if you need some help. Just let me know.

@galvesribeiro has permissions to merge it. Let's wait until he caught up. No one is maintaining the project full time.

Let me figure out whether should we disable those tests.

We should fix the tests instead. I can take a look at it in the next days if you need some help. Just let me know.

I've updated those tests.
Docker.DotNet.Tests.ISystemOperationsTests.MonitorEventsAsync_Succeeds(); seems kind of fishy at the moment.

@galvesribeiro That was a bit to early 😀, I was just replying - sorry.

I think the last commit is wrong. We should revert it and remove CreateImageAsync in both tests. They make no sense. The image does not exist and cannot pulled or imported. IMO the right fix would be (in addition the test class had way to many unnecessary changes):

diff --git a/test/Docker.DotNet.Tests/ISystemOperations.Tests.cs b/test/Docker.DotNet.Tests/ISystemOperations.Tests.cs
index 0157d54..fea6c01 100644
--- a/test/Docker.DotNet.Tests/ISystemOperations.Tests.cs
+++ b/test/Docker.DotNet.Tests/ISystemOperations.Tests.cs
@@ -111,8 +111,6 @@ namespace Docker.DotNet.Tests
                 progressMessage,
                 cts.Token);
 
-            await _dockerClient.Images.CreateImageAsync(new ImagesCreateParameters { FromImage = $"{_repositoryName}:{_tag}" }, null, progressJSONMessage, _cts.Token);
-
             await _dockerClient.Images.TagImageAsync($"{_repositoryName}:{_tag}", new ImageTagParameters { RepositoryName = _repositoryName, Tag = newTag }, _cts.Token);
 
             await _dockerClient.Images.DeleteImageAsync(
@@ -267,8 +265,6 @@ namespace Docker.DotNet.Tests
             using var cts = CancellationTokenSource.CreateLinkedTokenSource(_cts.Token);
             var task = Task.Run(() => _dockerClient.System.MonitorEventsAsync(eventsParams, progress, cts.Token));
 
-            await _dockerClient.Images.CreateImageAsync(new ImagesCreateParameters { FromImage = $"{_repositoryName}:{_tag}" }, null, new Progress<JSONMessage>());
-
             await _dockerClient.Images.TagImageAsync($"{_repositoryName}:{_tag}", new ImageTagParameters { RepositoryName = _repositoryName, Tag = newTag });
             await _dockerClient.Images.DeleteImageAsync($"{_repositoryName}:{newTag}", new ImageDeleteParameters());

Should I create another pull request?

No problem. Can you create another PR and submit the fix?

Thank you!

No problem. Can you create another PR and submit the fix?

Thank you!

Yep, I'll do. Give me a few minutes.

@HofmeisterAn , I believe my last commit has already changed those non-existing image to the well-known 'hello-world:latest'. Or are you talking about other places?

@galvesribeiro @HofmeisterAn , would any of you have some estimation when the next release will be triggered?

Sorry, cannot help here. Waiting for a release as well.