Sitelet https://github.com/dotnet/Docker.DotNet/pull/580
Skip to content

Feature/add http custom headers - #580

Merged
galvesribeiro merged 2 commits into
dotnet:masterfrom
HofmeisterAn:feature/add-http-custom-headers
Aug 17, 2022
Merged

galvesribeiro merged 2 commits into
dotnet:masterfrom
HofmeisterAn:feature/add-http-custom-headers

Conversation

@HofmeisterAn

Copy link
Copy Markdown
Contributor

@galvesribeiro this allows the clients to set custom HTTP request headers. Depending on the API endpoint, this allows to enable or configure further features.

The first commit refactors some basics. It orders properties, methods, etc. by their modifier and applies ConfigureAwait to each await task.

The second commit adds the ability to set custom HTTP headers.

@HofmeisterAn
HofmeisterAn force-pushed the feature/add-http-custom-headers branch from d5c1ac5 to beb931a Compare August 5, 2022 16:15
@HofmeisterAn

Copy link
Copy Markdown
Contributor Author

@galvesribeiro Can you take a look at this? Getting this feature merged would help us a lot.

@galvesribeiro
galvesribeiro merged commit 6285c9a into dotnet:master Aug 17, 2022
@galvesribeiro

Copy link
Copy Markdown
Member

Ops, sorry, I've missed this. Thanks @HofmeisterAn !

@HofmeisterAn
HofmeisterAn deleted the feature/add-http-custom-headers branch August 17, 2022 19:01
@HofmeisterAn

Copy link
Copy Markdown
Contributor Author

Ops, sorry, I've missed this. Thanks @HofmeisterAn !

No worries, thanks.

@BenasB

BenasB commented Aug 24, 2022

Copy link
Copy Markdown

Hi @galvesribeiro. I'm new to the project and just wanted to ask if there's any information about when this change will be released? I would like to use this, but unfortunately I can't reach the development package source from my corporate network.

@HofmeisterAn

Copy link
Copy Markdown
Contributor Author

@BenasB I think we can expect a new version with #579.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants