Sitelet https://github.com/dotnet/Docker.DotNet/pull/579
Skip to content

Bugfix/578 allow chunked read stream write operations - #579

Merged
galvesribeiro merged 5 commits into
dotnet:masterfrom
HofmeisterAn:bugfix/578-allow-chunked-read-stream-write-operations
Aug 30, 2022
Merged

Bugfix/578 allow chunked read stream write operations#579
galvesribeiro merged 5 commits into
dotnet:masterfrom
HofmeisterAn:bugfix/578-allow-chunked-read-stream-write-operations

Conversation

@HofmeisterAn

@HofmeisterAn HofmeisterAn commented Jul 22, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Relates to #578. FYI @JonasBenz.

@HofmeisterAn
HofmeisterAn force-pushed the bugfix/578-allow-chunked-read-stream-write-operations branch from b6de525 to e3ab167 Compare July 22, 2022 17:56
@JonasBenz

JonasBenz commented Jul 22, 2022

Copy link
Copy Markdown

Relates to #578. FYI @JonasBenz.

Oh wow, thanks a lot for your effort.

@HofmeisterAn

HofmeisterAn commented Aug 17, 2022

Copy link
Copy Markdown
Contributor Author

@galvesribeiro Is there anything against adopting the changes, see #581, #578, #554?

@galvesribeiro

galvesribeiro commented Aug 17, 2022

Copy link
Copy Markdown
Member

No. I believe they are good. Please rebase it on the main branch and force push and we can merge it to push a release.

Thanks!

@HofmeisterAn

HofmeisterAn commented Aug 17, 2022

Copy link
Copy Markdown
Contributor Author

No. I believe they are good. Please rebase it on the main branch and force push and we can merge it to push a release.

Thanks!

Great, thanks a lot 🙏. I'll rebase and push the changes tomorrow.

@HofmeisterAn
HofmeisterAn force-pushed the bugfix/578-allow-chunked-read-stream-write-operations branch from e3ab167 to 6a4ab2b Compare August 18, 2022 17:15
@HofmeisterAn
HofmeisterAn force-pushed the bugfix/578-allow-chunked-read-stream-write-operations branch from 6a4ab2b to 35f2b2a Compare August 18, 2022 17:21
@HofmeisterAn

HofmeisterAn commented Aug 18, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I have added my changes that refactors the TestFixture too. The fixture now uses IAsyncLifetime and the async API. The test classes now access the fixture properties consistently. I fixed the clean up of the containers and images (they previously remain).

@HofmeisterAn HofmeisterAn mentioned this pull request Aug 24, 2022
Merged
@HofmeisterAn

HofmeisterAn commented Aug 29, 2022

Copy link
Copy Markdown
Contributor Author

@galvesribeiro Is there anything missing? Could you adopt the changes, please?

Just let me know if I can take care of any specific following task, otherwise I will take a look at another open pull requests or issue.

@galvesribeiro

galvesribeiro commented Aug 30, 2022

Copy link
Copy Markdown
Member

Sorry for the delay. LGTM. Is there any other PR you wanna go with the same build?

galvesribeiro
galvesribeiro approved these changes Aug 30, 2022
View reviewed changes

@galvesribeiro galvesribeiro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@galvesribeiro
galvesribeiro merged commit 6fd2c5b into dotnet:master Aug 30, 2022
@HofmeisterAn
HofmeisterAn deleted the bugfix/578-allow-chunked-read-stream-write-operations branch August 30, 2022 03:56
@HofmeisterAn

HofmeisterAn commented Aug 30, 2022

Copy link
Copy Markdown
Contributor Author

Sorry for the delay. LGTM. Is there any other PR you wanna go with the same build?

No problem. No, not for now. Having the last two PRs helps us a lot to continue. I’ll look through the other PRs and issues afterwards.

@HofmeisterAn HofmeisterAn mentioned this pull request Sep 3, 2022
Closed
This was referenced Sep 3, 2022
Merged
Merged
Merged
Merged
@renovate-bot renovate-bot mentioned this pull request Sep 3, 2022
Merged
1 task
@renovate renovate Bot mentioned this pull request Sep 4, 2022
Merged
1 task
@renovate-bot renovate-bot mentioned this pull request Sep 15, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@galvesribeiro galvesribeiro galvesribeiro approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HofmeisterAn @JonasBenz @galvesribeiro