Sitelet https://github.com/codeRIT/hackathon-manager/compare/v1.18.0...v1.19.0
Skip to content
This repository was archived by the owner on Mar 1, 2026. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: codeRIT/hackathon-manager
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.18.0
Choose a base ref
...
head repository: codeRIT/hackathon-manager
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.19.0
Choose a head ref
  • 19 commits
  • 14 files changed
  • 4 contributors

Commits on Aug 16, 2019

  1. bugfix: validate the asset to contain a url

    @dquach217
    dquach217 committed Aug 16, 2019
    Configuration menu
    Copy the full SHA
    edb9f39 View commit details
    Browse the repository at this point in the history

  2. resolve issues mention by codeclimate and hound

    @dquach217
    dquach217 committed Aug 16, 2019
    Configuration menu
    Copy the full SHA
    1cb0397 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2019

  1. Update app/controllers/manage/configs_controller.rb 

    Co-Authored-By: Stuart Olivera <stuart@stuartolivera.com>
    @dquach217 @sman591
    dquach217 and sman591 authored Aug 18, 2019
    Configuration menu
    Copy the full SHA
    dc20a1b View commit details
    Browse the repository at this point in the history

  2. update test to properly capture redirects

    @dquach217
    dquach217 committed Aug 18, 2019
    Configuration menu
    Copy the full SHA
    c5ce3df View commit details
    Browse the repository at this point in the history

  3. Update test/controllers/manage/configs_controller_test.rb 

    Co-Authored-By: Stuart Olivera <stuart@stuartolivera.com>
    @dquach217 @sman591
    dquach217 and sman591 authored Aug 18, 2019
    Configuration menu
    Copy the full SHA
    b9b256e View commit details
    Browse the repository at this point in the history

  4. display information on the admin detail page, having issues with disp… 

    …laying data to admin datatable
    @dquach217
    dquach217 committed Aug 18, 2019
    Configuration menu
    Copy the full SHA
    9fa1ab5 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2019

  1. fix getting the data from the javascript side and changing the naming… 

    … convention of table
    @dquach217
    dquach217 committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    ecaec45 View commit details
    Browse the repository at this point in the history

  2. update so that when encountering ::1 render 127.0.0.1

    @dquach217
    dquach217 committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    ca6d61b View commit details
    Browse the repository at this point in the history

  3. remove the format that my editor applied

    @dquach217
    dquach217 committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    cd91161 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2019

  1. Merge pull request #178 from codeRIT/issue_164 

    fix: Validate asset config values are URLs
    @dquach217
    dquach217 authored Aug 25, 2019
    Configuration menu
    Copy the full SHA
    b2021b3 View commit details
    Browse the repository at this point in the history

  2. update changes on per Stuart's request

    @dquach217
    dquach217 committed Aug 25, 2019
    Configuration menu
    Copy the full SHA
    b85759d View commit details
    Browse the repository at this point in the history

  3. for hound

    @dquach217
    dquach217 committed Aug 25, 2019
    Configuration menu
    Copy the full SHA
    fd769ac View commit details
    Browse the repository at this point in the history

  4. fix for the tests

    @dquach217
    dquach217 committed Aug 25, 2019
    Configuration menu
    Copy the full SHA
    93dde55 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #181 from codeRIT/issue_128 

    feat: Display sign-in info on the admin detail & admin table list
    @dquach217
    dquach217 authored Aug 25, 2019
    Configuration menu
    Copy the full SHA
    f0be0e3 View commit details
    Browse the repository at this point in the history

  6. test: Fix _asset config test

    @sman591
    sman591 committed Aug 25, 2019
    Configuration menu
    Copy the full SHA
    63f49ec View commit details
    Browse the repository at this point in the history

  7. maint: Code reformat

    @sman591
    sman591 committed Aug 25, 2019
    Configuration menu
    Copy the full SHA
    123eafc View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2019

  1. build(deps): bump devise from 4.6.2 to 4.7.1 (#183) 

    Bumps [devise](https://github.com/plataformatec/devise) from 4.6.2 to 4.7.1.
- [Release notes](https://github.com/plataformatec/devise/releases)
- [Changelog](https://github.com/plataformatec/devise/blob/master/CHANGELOG.md)
- [Commits](heartcombo/devise@v4.6.2...v4.7.1)

Signed-off-by: dependabot[bot] <support@github.com>
    @dependabot @sman591
    dependabot[bot] authored and sman591 committed Sep 11, 2019
    Configuration menu
    Copy the full SHA
    ccc6514 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2019

  1. feat: Add ability to close registration completely (#176) 

    * feat: Support SMTP as an alternative email provider to Sparkpost (#172)

test: Fix _asset config test

maint: Code reformat

* fix: when registration is over it should redirect to the root path

* use alert instead of failure or error because looking at the docs they only have alert and notice to be used

* Update app/controllers/users/registrations_controller.rb

Co-Authored-By: Stuart Olivera <stuart@stuartolivera.com>

* check only during the create or new registration

* Update app/controllers/manage/questionnaires_controller.rb

Co-Authored-By: Stuart Olivera <stuart@stuartolivera.com>

* end to close def block

* Update app/controllers/manage/questionnaires_controller.rb

Co-Authored-By: Stuart Olivera <stuart@stuartolivera.com>

* test: add new tests for registration and questionnaire

* test: remove response method

* test: resolve for registration controller

* test: remove trailing white space

* test: update test

* test: get the :new

* fix: move the test for questionnaires to be moved to config since that is where it should be housed. Remove the check for response due to root redirecting to sign in page.

* fix: remove failing test, it touches both config and questionnaire

* fix: remove failing test
    @dquach217
    dquach217 authored Oct 5, 2019
    Configuration menu
    Copy the full SHA
    457781d View commit details
    Browse the repository at this point in the history

  2. chore(release): 1.19.0 [skip ci] 

    # [1.19.0](v1.18.0...v1.19.0) (2019-10-05)

### Features

* Add ability to close registration completely ([#176](#176)) ([457781d](457781d)), closes [#172](#172)

### Maintenance

* Code reformat ([123eafc](123eafc))

### Tests

* Fix _asset config test ([63f49ec](63f49ec))
    @semantic-release-bot
    semantic-release-bot committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    0f91b5d View commit details
    Browse the repository at this point in the history
Loading