This repository was archived by the owner on Mar 1, 2026. It is now read-only.
Repository navigation
Conversation
…laying data to admin datatable
… convention of table
houndci-bot
reviewed
Aug 21, 2019
sman591
suggested changes
Aug 24, 2019
sman591
left a comment
Member
There was a problem hiding this comment.
Nice! Few small tweaks then good to go
houndci-bot
reviewed
Aug 25, 2019
Contributor
Author
|
@sman591 I finished applying all changes requested |
sman591
suggested changes
Aug 25, 2019
sman591
left a comment
Member
There was a problem hiding this comment.
Looks like tests are currently failing because display_datetime is incompatible with nil values... if you add this to the beginning of https://github.com/codeRIT/hackathon-manager/blob/master/app/helpers/hackathon_manager_helper.rb#L94 it should fix it:
if datetime.blank?
return ""
end
sman591
approved these changes
Aug 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #128